From 8fb5936f92641e8dc0d673274ce1cf0eb502b2b5 Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Wed, 10 Jul 2019 13:49:50 +0200 Subject: [PATCH] Fix kubernetes runner on py3 instance_id is a string, so this can't be compared to an integer on python 3. Broken in ac1b25ed4c069abf1c8d810ba26d5be43717766d, prior to that the comparison was `len(self._galaxy_instance_id) > 0:` --- lib/galaxy/jobs/runners/util/pykube_util.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/galaxy/jobs/runners/util/pykube_util.py b/lib/galaxy/jobs/runners/util/pykube_util.py index a86601c324f..0203b9f5046 100644 --- a/lib/galaxy/jobs/runners/util/pykube_util.py +++ b/lib/galaxy/jobs/runners/util/pykube_util.py @@ -47,7 +47,7 @@ def produce_unique_k8s_job_name(app_prefix=None, instance_id=None, job_id=None): if app_prefix: job_name += "%s-" % app_prefix - if instance_id and instance_id > 0: + if instance_id and len(instance_id) > 0: job_name += "%s-" % instance_id return job_name + job_id