mirror of
https://github.com/galaxyproject/galaxy.git
synced 2026-09-24 16:30:27 +08:00
Fix refactor action dropping outputs on subworkflow connection
I thought it would be cleaner to make a distinction between the output name and the output label when reasoning about a subworkflow step in the context of a parent workflow (https://github.com/galaxyproject/galaxy/pull/14473/commits/b0727be9e0b096a2dacacb767a1f4ac0fc3e6540#diff-a50bcc5c08ade11249449c4100ea8c286727df601b52a5b9588eb2a385d97da7R543), in case we'd later want to do something with the label. I don't think I thought about this correctly though, and it breaks connections between steps that were made by referencing the subworkflow's output name. This wasn't necessary for the main goal of https://github.com/galaxyproject/galaxy/pull/14473, so I'm partially reverting that here. Fixes https://github.com/galaxyproject/planemo/pull/1262#issuecomment-1223874571
This commit is contained in:
@@ -244,9 +244,9 @@ def test_subworkflow_new_outputs():
|
||||
outputs = subworkflow_module.get_data_outputs()
|
||||
assert len(outputs) == 2, len(outputs)
|
||||
output1, output2 = outputs
|
||||
assert output1["label"] == "out1"
|
||||
assert output1["name"] == "out1"
|
||||
assert output1["extensions"] == ["input"]
|
||||
assert output2["label"] == "4:out_file1", output2["label"]
|
||||
assert output2["name"] == "4:out_file1", output2["name"]
|
||||
|
||||
|
||||
class MapOverTestCase(NamedTuple):
|
||||
|
||||
Reference in New Issue
Block a user