diff --git a/lib/galaxy/datatypes/data.py b/lib/galaxy/datatypes/data.py index 0c35466e7d4..f5410a558c2 100644 --- a/lib/galaxy/datatypes/data.py +++ b/lib/galaxy/datatypes/data.py @@ -409,7 +409,7 @@ class Data(metaclass=DataMeta): return self._archive_composite_dataset(trans, data, do_action=kwd.get('do_action', 'zip')) else: trans.response.headers['Content-Length'] = str(os.stat(data.file_name).st_size) - filename = self._download_filename(data, to_ext, hdca=kwd.get("hdca"), element_identifier=kwd.get("element_identifier"), filename_pattern=kwd.get("filename_pattern")) + filename = self._download_filename(data, to_ext, hdca=kwd.get("hdca"), element_identifier=kwd.get("element_identifier")) trans.response.set_content_type("application/octet-stream") # force octet-stream so Safari doesn't append mime extensions to filename trans.response.headers["Content-Disposition"] = 'attachment; filename="%s"' % filename return open(data.file_name, 'rb') @@ -472,7 +472,7 @@ class Data(metaclass=DataMeta): return open(filename, mode='rb') - def _download_filename(self, dataset, to_ext, hdca=None, element_identifier=None, filename_pattern=None): + def _download_filename(self, dataset, to_ext, hdca=None, element_identifier=None): def escape(raw_identifier): return ''.join(c in FILENAME_VALID_CHARS and c or '_' for c in raw_identifier)[0:150] @@ -487,11 +487,7 @@ class Data(metaclass=DataMeta): "hid": dataset.hid, } - if not filename_pattern: - if hdca is None: - filename_pattern = DOWNLOAD_FILENAME_PATTERN_DATASET - else: - filename_pattern = DOWNLOAD_FILENAME_PATTERN_COLLECTION_ELEMENT + filename_pattern = DOWNLOAD_FILENAME_PATTERN_DATASET if hdca is not None: # Use collection context to build up filename. @@ -499,6 +495,8 @@ class Data(metaclass=DataMeta): template_values["hdca_name"] = escape(hdca.name) template_values["hdca_hid"] = hdca.hid + filename_pattern = DOWNLOAD_FILENAME_PATTERN_COLLECTION_ELEMENT + return string.Template(filename_pattern).substitute(**template_values) def display_name(self, dataset):