From 2ad4dde0729bbce690f744730b4b2f2af39b1fef Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Tue, 29 May 2018 10:00:28 -0400 Subject: [PATCH 1/2] Convert history-contents urlroot to instance var --- client/galaxy/scripts/mvc/history/history-contents.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/galaxy/scripts/mvc/history/history-contents.js b/client/galaxy/scripts/mvc/history/history-contents.js index 538ea914e06..a57c28cef16 100644 --- a/client/galaxy/scripts/mvc/history/history-contents.js +++ b/client/galaxy/scripts/mvc/history/history-contents.js @@ -36,7 +36,6 @@ var HistoryContents = _super.extend(BASE_MVC.LoggableMixin).extend({ order: "hid", /** root api url */ - urlRoot: `${Galaxy.root}api/histories`, /** complete api url */ url: function() { @@ -50,6 +49,7 @@ var HistoryContents = _super.extend(BASE_MVC.LoggableMixin).extend({ }); options = options || {}; + this.urlRoot = `${Galaxy.root}api/histories`; _super.prototype.initialize.call(this, models, options); this.history = options.history || null; From 54ec854c130f92f49d2c3f42e2e8971d6676a79a Mon Sep 17 00:00:00 2001 From: Martin Cech Date: Fri, 8 Jun 2018 13:19:13 -0400 Subject: [PATCH 2/2] remove outdated comment --- client/galaxy/scripts/mvc/history/history-contents.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/client/galaxy/scripts/mvc/history/history-contents.js b/client/galaxy/scripts/mvc/history/history-contents.js index a57c28cef16..65052d2c667 100644 --- a/client/galaxy/scripts/mvc/history/history-contents.js +++ b/client/galaxy/scripts/mvc/history/history-contents.js @@ -35,8 +35,6 @@ var HistoryContents = _super.extend(BASE_MVC.LoggableMixin).extend({ /** @type {String} order used here and when fetching from server */ order: "hid", - /** root api url */ - /** complete api url */ url: function() { return `${this.urlRoot}/${this.historyId}/contents`;