From 82f26d40ac4290d4038b2d38195a736eb15134cd Mon Sep 17 00:00:00 2001
From: mvdbeek <m.vandenbeek@gmail.com>
Date: Tue, 23 Feb 2021 08:53:43 +0100
Subject: [PATCH] Disable tool document cache by default

It's kind of brittle, and https://github.com/galaxyproject/galaxy/pull/10804
has improved the parsing so much that it doesn't add much benefit.
Instances on Anvil start up in ~ 32 seconds, with all of main's toolbox.
---
 doc/source/admin/galaxy_options.rst         | 12 ++++++------
 lib/galaxy/config/sample/galaxy.yml.sample  | 14 +++++++-------
 lib/galaxy/webapps/galaxy/config_schema.yml |  6 +++---
 3 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/doc/source/admin/galaxy_options.rst b/doc/source/admin/galaxy_options.rst
index 86479656e0d..15e415178ab 100644
--- a/doc/source/admin/galaxy_options.rst
+++ b/doc/source/admin/galaxy_options.rst
@@ -1054,13 +1054,13 @@
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 :Description:
-    Set this to false to disable the tool document cache. This cache
-    stores expanded xml strings. Disabling the tool cache results in
-    slower startup times. The tool cache is backed by sqlite database,
-    which cannot be stored on certain network disks. The cache
-    location is configurable using the ``tool_cache_data_dir``
+    Set this to true to enable the tool document cache. This cache
+    stores expanded xml strings. Enabling the tool cache results in
+    slightly faster startup times. The tool cache is backed by sqlite
+    database, which cannot be stored on certain network disks. The
+    cache location is configurable using the ``tool_cache_data_dir``
     setting, but can be disabled completely here.
-:Default: ``true``
+:Default: ``false``
 :Type: bool
 
 
diff --git a/lib/galaxy/config/sample/galaxy.yml.sample b/lib/galaxy/config/sample/galaxy.yml.sample
index 9bf13d71da0..1b06f9e55a6 100644
--- a/lib/galaxy/config/sample/galaxy.yml.sample
+++ b/lib/galaxy/config/sample/galaxy.yml.sample
@@ -617,13 +617,13 @@ galaxy:
   # generated commands run in sh.
   #default_job_shell: /bin/bash
 
-  # Set this to false to disable the tool document cache. This cache
-  # stores expanded xml strings. Disabling the tool cache results in
-  # slower startup times. The tool cache is backed by sqlite database,
-  # which cannot be stored on certain network disks. The cache location
-  # is configurable using the ``tool_cache_data_dir`` setting, but can
-  # be disabled completely here.
-  #enable_tool_document_cache: true
+  # Set this to true to enable the tool document cache. This cache
+  # stores expanded xml strings. Enabling the tool cache results in
+  # slightly faster startup times. The tool cache is backed by sqlite
+  # database, which cannot be stored on certain network disks. The cache
+  # location is configurable using the ``tool_cache_data_dir`` setting,
+  # but can be disabled completely here.
+  #enable_tool_document_cache: false
 
   # Tool related caching. Fully expanded tools and metadata will be
   # stored at this path. Per tool_conf cache locations can be configured
diff --git a/lib/galaxy/webapps/galaxy/config_schema.yml b/lib/galaxy/webapps/galaxy/config_schema.yml
index ed024e7d944..663c3ba2c17 100644
--- a/lib/galaxy/webapps/galaxy/config_schema.yml
+++ b/lib/galaxy/webapps/galaxy/config_schema.yml
@@ -767,11 +767,11 @@ mapping:
 
       enable_tool_document_cache:
         type: bool
-        default: true
+        default: false
         required: false
         desc: |
-          Set this to false to disable the tool document cache. This cache stores
-          expanded xml strings. Disabling the tool cache results in slower startup
+          Set this to true to enable the tool document cache. This cache stores
+          expanded xml strings. Enabling the tool cache results in slightly faster startup
           times. The tool cache is backed by sqlite database, which cannot
           be stored on certain network disks. The cache location is configurable
           using the ``tool_cache_data_dir`` setting, but can be disabled completely here.