Merge pull request #17365 from mvdbeek/warn_unreachable

Enable ``warn_unreachable`` mypy option

test/unit/app/authnz/test_custos_authnz.py

@@ -6,6 +6,7 @@ from datetime import (
     datetime,
     timedelta,
 )
+from typing import Optional
 from unittest import SkipTest
 from urllib.parse import (
     parse_qs,
@@ -189,7 +190,7 @@ class TestCustosAuthnz(TestCase):
         class Query:
             external_user_id = None
             provider = None
-            custos_authnz_token = None
+            custos_authnz_token: Optional[CustosAuthnzToken] = None
 
             def filter_by(self, email=None, external_user_id=None, provider=None, username=None):
                 self.external_user_id = external_user_id

test/unit/app/managers/test_HistoryManager.py

@@ -267,7 +267,7 @@ class TestHistoryManager(BaseTestCase):
         assert len(self.history_manager.get_share_assocs(item1, user=non_owner)) == 1
         assert isinstance(item1.slug, str)
 
-        self.log("should be able to unshare with specific users")
+        self.log("should be able to unshare with specific users")  # type: ignore[unreachable]
         share_assoc = self.history_manager.unshare_with(item1, non_owner)
         assert isinstance(share_assoc, model.HistoryUserShareAssociation)
         assert not self.history_manager.is_accessible(item1, non_owner)

test/unit/tool_shed/test_tool_panel_manager.py

@@ -107,7 +107,7 @@ class TestToolPanelManager(BaseToolBoxTestCase):
             # New GUID replaced old one in tool panel but both
             # appear in integrated tool panel.
             if previous_guid:
-                assert (f"tool_{previous_guid}") not in section.panel_items()
+                assert (f"tool_{previous_guid}") not in section.panel_items()  # type: ignore[unreachable]
             assert (f"tool_{guid}") in self.toolbox._integrated_tool_panel["tid1"].panel_items()
             previous_guid = guid