From 3b0494192570e0d0799eb0f99d0cba3196d383bf Mon Sep 17 00:00:00 2001 From: will Date: Mon, 3 Jun 2019 15:42:47 -0400 Subject: [PATCH 1/8] change # to javascript:void(0) so that the screen reader does not interpret the links as already visited --- .../galaxy/scripts/mvc/workflow/workflow-view.js | 6 +++--- templates/webapps/galaxy/workflow/editor.mako | 14 +++++++------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/client/galaxy/scripts/mvc/workflow/workflow-view.js b/client/galaxy/scripts/mvc/workflow/workflow-view.js index f4a29b16cf1..ec7a1d0bd7d 100644 --- a/client/galaxy/scripts/mvc/workflow/workflow-view.js +++ b/client/galaxy/scripts/mvc/workflow/workflow-view.js @@ -453,7 +453,7 @@ export default Backbone.View.extend({ // Tool menu $("div.toolSectionBody").hide(); - $("div.toolSectionTitle > span").wrap(""); + $("div.toolSectionTitle > span").wrap(""); var last_expanded = null; $("div.toolSectionTitle").each(function() { var body = $(this).next("div.toolSectionBody"); @@ -494,7 +494,7 @@ export default Backbone.View.extend({ var $section = $( '
' + '
' + - 'Workflows' + + 'Workflows' + "
" + '
' + '
' + @@ -530,7 +530,7 @@ export default Backbone.View.extend({ } }); var $add = $("") - .attr("href", "#") + .attr("href", "javascript:void(0)") .html(workflow.name) .on("click", () => { self.add_node_for_subworkflow(workflow.latest_id, workflow.name); diff --git a/templates/webapps/galaxy/workflow/editor.mako b/templates/webapps/galaxy/workflow/editor.mako index 187f634ca99..cfd0be69b9d 100644 --- a/templates/webapps/galaxy/workflow/editor.mako +++ b/templates/webapps/galaxy/workflow/editor.mako @@ -80,9 +80,9 @@ %if "[[" in tool.description and "]]" in tool.description: ${tool.description.replace( '[[', '' % tool.id ).replace( "]]", "" )} %elif tool.name: - ${tool.name | h} ${tool.description} + ${tool.name | h} ${tool.description} %else: - ${tool.description} + ${tool.description} %endif
%else: @@ -126,7 +126,7 @@
%for module in module_section["modules"]:
- + ${module['description']}
@@ -232,13 +232,13 @@
- + - + - +
@@ -287,7 +287,7 @@
- + ## Workflow tags. <%namespace file="/tagging_common.mako" import="render_individual_tagging_element" />
From 84ff9f35e135cea0b6d965024dfd9f178e4698f9 Mon Sep 17 00:00:00 2001 From: will Date: Tue, 4 Jun 2019 14:37:20 -0400 Subject: [PATCH 2/8] Add aria labels and roles screen readers --- client/galaxy/scripts/layout/masthead.js | 4 ++-- client/galaxy/scripts/mvc/tool/tools.js | 2 +- .../scripts/mvc/workflow/workflow-view.js | 17 +++++++++++++---- templates/webapps/galaxy/workflow/editor.mako | 14 +++++++------- templates/webapps/tool_shed/base_panels.mako | 4 ++-- 5 files changed, 25 insertions(+), 16 deletions(-) diff --git a/client/galaxy/scripts/layout/masthead.js b/client/galaxy/scripts/layout/masthead.js index dc41a0b738d..367f280f814 100644 --- a/client/galaxy/scripts/layout/masthead.js +++ b/client/galaxy/scripts/layout/masthead.js @@ -98,8 +98,8 @@ const View = Backbone.View.extend({ _template: function() { return `
diff --git a/client/galaxy/docs/galaxy-buttons.md b/client/galaxy/docs/galaxy-buttons.md index b959cb7ce60..30675603809 100644 --- a/client/galaxy/docs/galaxy-buttons.md +++ b/client/galaxy/docs/galaxy-buttons.md @@ -5,21 +5,21 @@ ``` ```vue -An anchor with .action-button +An anchor with .action-button ``` All the crazy permutations of menu button... ```vue -An anchor with .menu-button +An anchor with .menu-button ``` ```vue -An anchor with .menu-button.popup +An anchor with .menu-button.popup ``` ```vue - + An anchor with .menu-button.popup.split ``` diff --git a/client/galaxy/scripts/components/Tags/StatelessTags.vue b/client/galaxy/scripts/components/Tags/StatelessTags.vue index c45ab737cdd..4f8be8b4697 100644 --- a/client/galaxy/scripts/components/Tags/StatelessTags.vue +++ b/client/galaxy/scripts/components/Tags/StatelessTags.vue @@ -4,7 +4,7 @@ upstream component or environment that is accessed through props and events -->