From 7bbc46658a77d74a2447095b61b28e6e4ca32e06 Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Sat, 3 Feb 2018 18:09:29 +0100 Subject: [PATCH] Fix setting job failure exception This can happen when the job's tool is unavailble and outputs_to_working_directory is activated. Fixes https://github.com/galaxyproject/galaxy/issues/5424. --- lib/galaxy/jobs/__init__.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/galaxy/jobs/__init__.py b/lib/galaxy/jobs/__init__.py index bfb10fe37fa..5e4f3bbd876 100644 --- a/lib/galaxy/jobs/__init__.py +++ b/lib/galaxy/jobs/__init__.py @@ -1762,9 +1762,13 @@ class JobWrapper(object, HasResourceParameters): method should be removed ASAP and replaced with some properly generic and stateful way of determining link-only datasets. -nate """ - job = self.get_job() - param_dict = job.get_param_values(self.app) - return self.tool.id == 'upload1' and param_dict.get('link_data_only', None) == 'link_to_files' + if self.tool: + job = self.get_job() + param_dict = job.get_param_values(self.app) + return self.tool.id == 'upload1' and param_dict.get('link_data_only', None) == 'link_to_files' + else: + # The tool is unavailable, we try to move the outputs. + return False def _change_ownership(self, username, gid): job = self.get_job()