From 75ccacd6e389c800372f952c392e355f08d43dbc Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Wed, 4 Feb 2015 11:07:58 -0500 Subject: [PATCH] Update commentary per previous commit re: API request handling. --- lib/galaxy/web/framework/webapp.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/lib/galaxy/web/framework/webapp.py b/lib/galaxy/web/framework/webapp.py index d123ace98bb..1315414455e 100644 --- a/lib/galaxy/web/framework/webapp.py +++ b/lib/galaxy/web/framework/webapp.py @@ -212,14 +212,11 @@ class GalaxyWebTransaction( base.DefaultWebTransaction, if config.require_login: self._ensure_logged_in_user( environ, session_cookie ) if config.session_duration: - # TODO DBTODO Session-based API requests need to be handled - # correctly here. Disabled for now. The issue is that API - # request response error codes aren't handled in a consistent - # way on the client side. All ajax calls from the client need - # to go through a single point of control where we can do things - # like redirect/etc. This is API calls as well as something - # like 40 @web.json requests that might not get handled well on - # the clientside. + # TODO DBTODO All ajax calls from the client need to go through + # a single point of control where we can do things like + # redirect/etc. This is API calls as well as something like 40 + # @web.json requests that might not get handled well on the + # clientside. # # Make sure we're not past the duration, and either log out or # update timestamp.