From 75b641b89cfdb34e227db561014b636b4bbe71b0 Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Wed, 10 Mar 2021 18:36:04 +0100 Subject: [PATCH] Tweak release issue template --- scripts/bootstrap_history.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/bootstrap_history.py b/scripts/bootstrap_history.py index 72ee21a0dc1..7e694137915 100644 --- a/scripts/bootstrap_history.py +++ b/scripts/bootstrap_history.py @@ -211,7 +211,7 @@ RELEASE_ISSUE_TEMPLATE = string.Template(""" make release-create-rc RELEASE_CURR=${version} RELEASE_NEXT=${next_version} - [ ] Open PRs from your fork of branch ``version-${version}`` to upstream ``release_${version}`` and of ``version-${next_version}.dev`` to ``dev``. - - [ ] Update ``next_milestone`` in [P4's configuration](https://github.com/galaxyproject/p4) to `${next_version}` so it properly tags new PRs. + - [ ] Update ``MILESTONE_NUMBER`` in the [ maintenance bot](https://github.com/galaxyproject/galaxy/blob/dev/.github/workflows/maintenance_bot.yaml) to `${next_version}` so it properly tags new PRs. - [ ] **Issue Review Timeline Notes** - [ ] Ensure any security fixes will be ready prior to ${freeze_date} + 1 week, to allow time for notification prior to release. @@ -255,6 +255,10 @@ RELEASE_ISSUE_TEMPLATE = string.Template(""" - [ ] Ensure all [blocking milestone PRs](https://github.com/galaxyproject/galaxy/pulls?q=is%3Aopen+is%3Apr+milestone%3A${version}) have been merged or closed. make release-check-blocking-prs RELEASE_CURR=${version} + - [ ] Ensure all PRs merged into the pre-release branch during the freeze have [milestones attached](https://github.com/galaxyproject/galaxy/pulls?q=is%3Apr+is%3Aclosed+base%3Arelease_{version}+is%3Amerged+no%3Amilestone) and that they are the not [${next_version} milestones](https://github.com/galaxyproject/galaxy/pulls?q=is%3Apr+is%3Aclosed+base%3Arelease_{version}+is%3Amerged+milestone%3A{next_version}) + - [ ] Ensure release notes include all PRs added during the freeze by re-running the release note bootstrapping: + + make release-bootstrap-history RELEASE_CURR=${version} - [ ] Ensure previous release is merged into current. [GitHub branch comparison](https://github.com/galaxyproject/galaxy/compare/release_${version}...release_${previous_version}) - [ ] Create and push release tag: