From 6ee2422648f014c1a64cdb888e0e4b1964501b6e Mon Sep 17 00:00:00 2001 From: Greg Von Kuster Date: Tue, 25 Jun 2013 09:51:26 -0400 Subject: [PATCH] Fix the Galaxy API for installing tool shed repositories when attempting to install a repository that was previously installed but is not longer in the installed state. --- lib/galaxy/webapps/galaxy/api/tool_shed_repositories.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/galaxy/webapps/galaxy/api/tool_shed_repositories.py b/lib/galaxy/webapps/galaxy/api/tool_shed_repositories.py index 92951eefefd..434b58df2b7 100644 --- a/lib/galaxy/webapps/galaxy/api/tool_shed_repositories.py +++ b/lib/galaxy/webapps/galaxy/api/tool_shed_repositories.py @@ -266,11 +266,7 @@ class ToolShedRepositoriesController( BaseAPIController ): action='show', id=trans.security.encode_id( tool_shed_repository.id ) ) installed_tool_shed_repositories.append( tool_shed_repository_dict ) - elif message: - log.error( message, exc_info=True ) - trans.response.status = 500 - return dict( status='error', error=message ) - elif not created_or_updated_tool_shed_repositories and not message: + else: # We're attempting to install more than 1 repository, and all of them have already been installed. return dict( status='error', error='All repositories that you are attempting to install have been previously installed.' ) # Display the list of installed repositories.