From bf1938b1075633b2827aded350a5199a621a0289 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Thu, 26 Jan 2023 15:03:07 -0500
Subject: [PATCH 1/4] Hide metadata auto-detection option if dataset is in
 improper state

---
 .../src/components/DatasetInformation/DatasetAttributes.vue   | 4 ++--
 lib/galaxy/webapps/galaxy/controllers/dataset.py              | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/client/src/components/DatasetInformation/DatasetAttributes.vue b/client/src/components/DatasetInformation/DatasetAttributes.vue
index dd942966dd0..fbb1aa44e52 100644
--- a/client/src/components/DatasetInformation/DatasetAttributes.vue
+++ b/client/src/components/DatasetInformation/DatasetAttributes.vue
@@ -20,12 +20,12 @@
                                 @click="submit('attribute', 'attributes')">
                                 <font-awesome-icon icon="save" class="mr-1" />{{ "Save" | l }}
                             </b-button>
-                            <b-button @click="submit('attribute', 'autodetect')">
+                            <b-button v-if="!result['metadata_disable']" @click="submit('attribute', 'autodetect')">
                                 <font-awesome-icon icon="redo" class="mr-1" />{{ "Auto-detect" | l }}
                             </b-button>
                         </div>
                     </b-tab>
-                    <b-tab v-if="!result['conversion_disable'] || !result['datatype_disable']">
+                    <b-tab v-if="(!result['conversion_disable'] || !result['datatype_disable']) && !result['metadata_disable']">
                         <template v-slot:title>
                             <span v-if="!result['conversion_disable']">
                                 <font-awesome-icon icon="cog" class="mr-1" />{{ "Convert" | l }}
diff --git a/lib/galaxy/webapps/galaxy/controllers/dataset.py b/lib/galaxy/webapps/galaxy/controllers/dataset.py
index 0473f7d2a1f..c496a8aedeb 100644
--- a/lib/galaxy/webapps/galaxy/controllers/dataset.py
+++ b/lib/galaxy/webapps/galaxy/controllers/dataset.py
@@ -291,6 +291,7 @@ class DatasetInterface(BaseUIController, UsesAnnotations, UsesItemRatings, UsesE
             if data.missing_meta():
                 message = 'Required metadata values are missing. Some of these values may not be editable by the user. Selecting "Auto-detect" will attempt to fix these values.'
                 status = "warning"
+            metadata_disable = data.state not in [trans.model.Dataset.states.OK, trans.model.Dataset.states.FAILED_METADATA]
             # datatype conversion
             conversion_options = [
                 (f"{convert_id} (using '{convert_name}')", convert_id)
@@ -369,6 +370,7 @@ class DatasetInterface(BaseUIController, UsesAnnotations, UsesItemRatings, UsesE
                 "message": message,
                 "status": status,
                 "dataset_id": dataset_id,
+                "metadata_disable": metadata_disable,
                 "attribute_inputs": attribute_inputs,
                 "conversion_inputs": conversion_inputs,
                 "conversion_disable": conversion_disable,

From ec7b8b01401e2eb3b4cfb74d4120e95efca8ddbd Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Thu, 26 Jan 2023 15:09:09 -0500
Subject: [PATCH 2/4] Fix linting

---
 .../src/components/DatasetInformation/DatasetAttributes.vue | 6 +++++-
 client/src/components/Workflow/Editor/modules/terminals.ts  | 4 ++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/client/src/components/DatasetInformation/DatasetAttributes.vue b/client/src/components/DatasetInformation/DatasetAttributes.vue
index fbb1aa44e52..73874c5f601 100644
--- a/client/src/components/DatasetInformation/DatasetAttributes.vue
+++ b/client/src/components/DatasetInformation/DatasetAttributes.vue
@@ -25,7 +25,11 @@
                             </b-button>
                         </div>
                     </b-tab>
-                    <b-tab v-if="(!result['conversion_disable'] || !result['datatype_disable']) && !result['metadata_disable']">
+                    <b-tab
+                        v-if="
+                            (!result['conversion_disable'] || !result['datatype_disable']) &&
+                            !result['metadata_disable']
+                        ">
                         <template v-slot:title>
                             <span v-if="!result['conversion_disable']">
                                 <font-awesome-icon icon="cog" class="mr-1" />{{ "Convert" | l }}
diff --git a/client/src/components/Workflow/Editor/modules/terminals.ts b/client/src/components/Workflow/Editor/modules/terminals.ts
index 1e354149ffa..9b145699bed 100644
--- a/client/src/components/Workflow/Editor/modules/terminals.ts
+++ b/client/src/components/Workflow/Editor/modules/terminals.ts
@@ -490,10 +490,10 @@ export class InputParameterTerminal extends BaseInputTerminal {
         const effectiveThisType = this.effectiveType(this.type);
         const otherType = ("type" in other && other.type) || "data";
         const effectiveOtherType = this.effectiveType(otherType);
-        const canAccept = effectiveThisType === effectiveOtherType
+        const canAccept = effectiveThisType === effectiveOtherType;
         return new ConnectionAcceptable(
             canAccept,
-            canAccept ? null: `Cannot attach a ${effectiveOtherType} parameter to a ${effectiveThisType} input`
+            canAccept ? null : `Cannot attach a ${effectiveOtherType} parameter to a ${effectiveThisType} input`
         );
     }
 }

From d71472f07143b712c85ca1005c129ebca4007b55 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Thu, 26 Jan 2023 15:49:27 -0500
Subject: [PATCH 3/4] Fix python linting

---
 lib/galaxy/webapps/galaxy/controllers/dataset.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/galaxy/webapps/galaxy/controllers/dataset.py b/lib/galaxy/webapps/galaxy/controllers/dataset.py
index c496a8aedeb..95bdbb1632d 100644
--- a/lib/galaxy/webapps/galaxy/controllers/dataset.py
+++ b/lib/galaxy/webapps/galaxy/controllers/dataset.py
@@ -291,6 +291,10 @@ class DatasetInterface(BaseUIController, UsesAnnotations, UsesItemRatings, UsesE
             if data.missing_meta():
                 message = 'Required metadata values are missing. Some of these values may not be editable by the user. Selecting "Auto-detect" will attempt to fix these values.'
                 status = "warning"
+            metadata_disable = data.state not in [
+                trans.model.Dataset.states.OK,
+                trans.model.Dataset.states.FAILED_METADATA,
+            ]
             metadata_disable = data.state not in [trans.model.Dataset.states.OK, trans.model.Dataset.states.FAILED_METADATA]
             # datatype conversion
             conversion_options = [

From b0187d6670659b5e82aa808d04bc5e6e536dd2fa Mon Sep 17 00:00:00 2001
From: Martin Cech <emulatorer@gmail.com>
Date: Fri, 27 Jan 2023 00:47:51 +0100
Subject: [PATCH 4/4] drop duplicated statement

---
 lib/galaxy/webapps/galaxy/controllers/dataset.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/galaxy/webapps/galaxy/controllers/dataset.py b/lib/galaxy/webapps/galaxy/controllers/dataset.py
index 95bdbb1632d..fe1578907b9 100644
--- a/lib/galaxy/webapps/galaxy/controllers/dataset.py
+++ b/lib/galaxy/webapps/galaxy/controllers/dataset.py
@@ -295,7 +295,6 @@ class DatasetInterface(BaseUIController, UsesAnnotations, UsesItemRatings, UsesE
                 trans.model.Dataset.states.OK,
                 trans.model.Dataset.states.FAILED_METADATA,
             ]
-            metadata_disable = data.state not in [trans.model.Dataset.states.OK, trans.model.Dataset.states.FAILED_METADATA]
             # datatype conversion
             conversion_options = [
                 (f"{convert_id} (using '{convert_name}')", convert_id)