diff --git a/lib/galaxy/web/controllers/dataset.py b/lib/galaxy/web/controllers/dataset.py index 0e00fd9345c..ec299dde3a1 100644 --- a/lib/galaxy/web/controllers/dataset.py +++ b/lib/galaxy/web/controllers/dataset.py @@ -44,7 +44,7 @@ class DatasetInterface( BaseController ): @web.expose def errors( self, trans, id ): dataset = model.HistoryDatasetAssociation.get( id ) - return trans.fill_template( "dataset/errors.tmpl", dataset=dataset ) + return trans.fill_template( "dataset/errors.mako", dataset=dataset ) @web.expose def stderr( self, trans, id ): diff --git a/lib/galaxy/web/controllers/root.py b/lib/galaxy/web/controllers/root.py index 8c7fea94441..eeb29ca8ece 100644 --- a/lib/galaxy/web/controllers/root.py +++ b/lib/galaxy/web/controllers/root.py @@ -547,29 +547,29 @@ class RootController( BaseController ): # return trans.fill_template( "/root/masthead.mako", brand=brand, wiki_url=wiki_url, # blog_url=blog_url,bugs_email=bugs_email, screencasts_url=screencasts_url, admin_user=admin_user, active_view=active_view ) - @web.expose - def dataset_errors( self, trans, id=None, **kwd ): - """View/fix errors associated with dataset""" - data = trans.app.model.HistoryDatasetAssociation.get( id ) - p = kwd - if p.get("fix_errors", None): - # launch tool to create new, (hopefully) error free dataset - tool_params = {} - tool_params["tool_id"] = 'fix_errors' - tool_params["runtool_btn"] = 'T' - tool_params["input"] = id - tool_params["ext"] = data.ext - # send methods selected - repair_methods = data.datatype.repair_methods( data ) - methods = [] - for method, description in repair_methods: - if method in p: methods.append(method) - tool_params["methods"] = ",".join(methods) - url = "/tool_runner/index?" + urllib.urlencode(tool_params) - trans.response.send_redirect(url) - else: - history = trans.app.model.History.get( data.history_id ) - return trans.fill_template('dataset/validation.tmpl', data=data, history=history) + # @web.expose + # def dataset_errors( self, trans, id=None, **kwd ): + # """View/fix errors associated with dataset""" + # data = trans.app.model.HistoryDatasetAssociation.get( id ) + # p = kwd + # if p.get("fix_errors", None): + # # launch tool to create new, (hopefully) error free dataset + # tool_params = {} + # tool_params["tool_id"] = 'fix_errors' + # tool_params["runtool_btn"] = 'T' + # tool_params["input"] = id + # tool_params["ext"] = data.ext + # # send methods selected + # repair_methods = data.datatype.repair_methods( data ) + # methods = [] + # for method, description in repair_methods: + # if method in p: methods.append(method) + # tool_params["methods"] = ",".join(methods) + # url = "/tool_runner/index?" + urllib.urlencode(tool_params) + # trans.response.send_redirect(url) + # else: + # history = trans.app.model.History.get( data.history_id ) + # return trans.fill_template('dataset/validation.tmpl', data=data, history=history) # ---- Debug methods ---------------------------------------------------- diff --git a/templates/dataset/errors.tmpl b/templates/dataset/errors.mako similarity index 67% rename from templates/dataset/errors.tmpl rename to templates/dataset/errors.mako index 86f69327a34..77ae84d7f97 100644 --- a/templates/dataset/errors.tmpl +++ b/templates/dataset/errors.mako @@ -18,31 +18,31 @@

Dataset generation errors

-

Dataset $dataset.hid: $dataset.display_name

+

Dataset ${dataset.hid}: ${dataset.display_name()}

- #if $dataset.creating_job_associations - #set job = $dataset.creating_job_associations[0].job - #if job.traceback + %if dataset.creating_job_associations: + <% job = dataset.creating_job_associations[0].job %> + %if job.traceback: The Galaxy framework encountered the following error while attempting to run the tool:
${job.traceback}
- #end if - #if $job.stderr or $job.info + %endif + %if job.stderr or job.info: Tool execution generated the following error message: - #if $job.stderr + %if job.stderr:
${job.stderr}
- #elif $job.info + %elif job.info:
${job.info}
- #end if - #else + %endif + %else: Tool execution did not generate any error messages. - #end if - #if $job.stdout + %endif + %if job.stdout: The tool produced the following additional output:
${job.stdout}
- #end if - #else + %endif + %else: The tool did not create any additional job / error info. - #end if + %endif

Report this error to the Galaxy Team

@@ -56,12 +56,15 @@

Error Report
- - - - -
Your Email:
Message:
-
+ +
+ + +
+
+ +