From f3208503f69bae63ef48e18deb85e7aa974e20c5 Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Tue, 12 Feb 2019 14:18:01 -0500 Subject: [PATCH 1/3] Drop 'fade in' classes on iframe; prefer static display without extra animations and fixes opacity issue from biostar. --- client/galaxy/scripts/layout/communication-server-view.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/galaxy/scripts/layout/communication-server-view.js b/client/galaxy/scripts/layout/communication-server-view.js index 11296718303..45102f92b88 100644 --- a/client/galaxy/scripts/layout/communication-server-view.js +++ b/client/galaxy/scripts/layout/communication-server-view.js @@ -26,7 +26,7 @@ export var CommunicationServerView = Backbone.View.extend({ var $el_chat_modal_header = null; var $el_chat_modal_body = null; - var iframe_template = ``; + var iframe_template = ``; var header_template = '' + From bfeb2727573a6c1c77551369bf46acf93d78190b Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Tue, 12 Feb 2019 14:18:44 -0500 Subject: [PATCH 2/3] drop redundant communication server frame styles. --- client/galaxy/scripts/layout/communication-server-view.js | 2 +- client/galaxy/style/scss/base.scss | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/client/galaxy/scripts/layout/communication-server-view.js b/client/galaxy/scripts/layout/communication-server-view.js index 45102f92b88..1051062e906 100644 --- a/client/galaxy/scripts/layout/communication-server-view.js +++ b/client/galaxy/scripts/layout/communication-server-view.js @@ -26,7 +26,7 @@ export var CommunicationServerView = Backbone.View.extend({ var $el_chat_modal_header = null; var $el_chat_modal_body = null; - var iframe_template = ``; + var iframe_template = ``; var header_template = '' + diff --git a/client/galaxy/style/scss/base.scss b/client/galaxy/style/scss/base.scss index 206b5e79e44..c4c00579500 100644 --- a/client/galaxy/style/scss/base.scss +++ b/client/galaxy/style/scss/base.scss @@ -1893,11 +1893,6 @@ div.toolTitleNoSection { padding: 2px; } -.communication-iframe { - width: 100%; - height: 100%; -} - .close-modal { float: right; cursor: pointer; From b29b8b5c17f4126b0af597c0bccac850767f5aff Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Tue, 12 Feb 2019 14:27:49 -0500 Subject: [PATCH 3/3] Use standard bootstrap classes for sizing here since it's only used in one spot. --- client/galaxy/scripts/layout/communication-server-view.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/galaxy/scripts/layout/communication-server-view.js b/client/galaxy/scripts/layout/communication-server-view.js index 1051062e906..93aa670ff9b 100644 --- a/client/galaxy/scripts/layout/communication-server-view.js +++ b/client/galaxy/scripts/layout/communication-server-view.js @@ -26,7 +26,7 @@ export var CommunicationServerView = Backbone.View.extend({ var $el_chat_modal_header = null; var $el_chat_modal_body = null; - var iframe_template = ``; + var iframe_template = ``; var header_template = '' +