From 454cca05b80fdc184bc15f93091dc948d4656143 Mon Sep 17 00:00:00 2001 From: guerler Date: Tue, 13 Aug 2019 11:21:59 -0400 Subject: [PATCH] Disable visualizations button for history datasets if visualizations are disabled in configuration --- client/galaxy/scripts/mvc/dataset/dataset-li-edit.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/client/galaxy/scripts/mvc/dataset/dataset-li-edit.js b/client/galaxy/scripts/mvc/dataset/dataset-li-edit.js index 87417282ce6..254f8c7afd9 100644 --- a/client/galaxy/scripts/mvc/dataset/dataset-li-edit.js +++ b/client/galaxy/scripts/mvc/dataset/dataset-li-edit.js @@ -263,15 +263,15 @@ var DatasetListItemEdit = _super.extend( /** Render an icon-button or popupmenu of links based on the applicable visualizations */ _renderVisualizationsButton: function() { //TODO: someday - lazyload visualizations - var visualizations = this.model.get("visualizations"); - if (this.model.isDeletedOrPurged() || !this.hasUser || !this.model.hasData() || _.isEmpty(visualizations)) { + const Galaxy = getGalaxyInstance(); + let visualizations = this.model.get("visualizations"); + if (!Galaxy.config.visualizations_visible || this.model.isDeletedOrPurged() || !this.hasUser || !this.model.hasData() || _.isEmpty(visualizations)) { return null; } if (!_.isObject(visualizations[0])) { this.warn("Visualizations have been switched off"); return null; } - if (visualizations.length >= 1) { const dsid = this.model.get("id"); const url = getAppRoot() + "visualizations?dataset_id=" + dsid; @@ -281,7 +281,6 @@ var DatasetListItemEdit = _super.extend( classes: "visualization-link", faIcon: "fa-bar-chart-o", onclick: ev => { - const Galaxy = getGalaxyInstance(); if (Galaxy.frame && Galaxy.frame.active) { ev.preventDefault(); Galaxy.frame.add({ url: url, title: "Visualization" });