From 44ac26da4c53dedad3499cfef6d9d4cb61364a05 Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Wed, 20 Apr 2022 06:53:09 -0400 Subject: [PATCH] Standardize vue component property order. --- .../Collections/ListCollectionCreator.vue | 12 +- .../ListDatasetCollectionElementView.vue | 18 +- .../Collections/PairCollectionCreator.vue | 16 +- .../Collections/PairedElementView.vue | 30 +-- .../PairedListCollectionCreator.vue | 148 +++++------ .../Collections/common/CollectionCreator.vue | 20 +- .../Collections/common/CollectionEditView.vue | 18 +- .../Collections/common/DatabaseEditTab.vue | 16 +- .../common/SuitableConvertersTab.vue | 10 +- .../Dataset/DatasetAsImage/DatasetAsImage.vue | 10 +- .../Dataset/DatasetIndex/DatasetIndex.vue | 34 +-- .../Dataset/DatasetLink/DatasetLink.vue | 30 +-- .../DatasetInformation/DatasetError.vue | 14 +- .../DatasetInformation/DatasetInformation.vue | 12 +- client/src/components/DecodedId.vue | 6 +- client/src/components/DisplayStructured.vue | 6 +- .../components/FilesDialog/FilesDialog.vue | 16 +- .../src/components/FilesDialog/FilesInput.vue | 16 +- client/src/components/Form/FormDisplay.vue | 14 +- client/src/components/Form/FormGeneric.vue | 10 +- client/src/components/Form/FormMessage.vue | 10 +- .../Content/Dataset/DatasetActions.vue | 2 +- .../CurrentHistory/HistoryMessages.vue | 10 +- .../CurrentHistory/HistoryNavigation.vue | 2 +- .../HistoryOperations/SelectionOperations.vue | 14 +- .../History/CurrentHistory/HistoryPanel.vue | 12 +- .../src/components/History/Layout/Listing.vue | 10 +- .../History/Modals/SelectorModal.vue | 16 +- .../src/components/HistoryExport/ToLink.vue | 12 +- .../components/HistoryExport/ToRemoteFile.vue | 10 +- client/src/components/HistoryImport.vue | 20 +- client/src/components/HistoryView.vue | 6 +- .../JobDependencies/JobDependencies.vue | 6 +- .../JobDestinationParams.vue | 12 +- .../JobParameters/JobParameters.vue | 28 +- .../JobStates/CollectionJobStates.vue | 8 +- .../components/Libraries/LibrariesList.vue | 10 +- .../Libraries/LibraryFolder/LibraryFolder.vue | 34 +-- .../LibraryFolderDataset/LibraryDataset.vue | 28 +- .../LibraryFolderDatasetPermissions.vue | 22 +- .../LibraryFolderPermissions.vue | 10 +- .../Libraries/LibraryFolder/SearchField.vue | 12 +- .../LibraryFolder/TopToolbar/FolderTopBar.vue | 32 +-- .../LibraryPermissions/LibraryPermissions.vue | 10 +- .../LibraryPermissions/PermissionsHeader.vue | 6 +- .../PermissionsInputField.vue | 16 +- client/src/components/License/License.vue | 14 +- .../components/License/LicenseSelector.vue | 26 +- .../CollectionDisplay.vue | 12 +- .../Elements/Workflow/WorkflowDisplay.vue | 12 +- client/src/components/Masthead/Masthead.vue | 66 ++--- .../NewUserWelcome/NewUserWelcome.vue | 6 +- .../components/PageDisplay/PageDisplay.vue | 10 +- .../src/components/PageEditor/PageEditor.vue | 10 +- .../PageEditor/PageEditorMarkdown.vue | 10 +- .../Panels/Buttons/FavoritesButton.vue | 10 +- .../components/Panels/Common/ToolSection.vue | 36 +-- .../src/components/Panels/ToolBoxWorkflow.vue | 12 +- .../RuleBuilder/IdentifierDisplay.vue | 16 +- .../components/RuleBuilder/RuleComponent.vue | 22 +- .../RuleBuilder/SavedRulesSelector.vue | 10 +- .../src/components/RuleCollectionBuilder.vue | 244 +++++++++--------- .../components/RulesDisplay/RulesDisplay.vue | 20 +- .../components/SchemaOrg/OrganizationForm.vue | 2 +- .../SchemaOrg/OrganizationViewer.vue | 2 +- .../src/components/SchemaOrg/PersonForm.vue | 2 +- .../src/components/SchemaOrg/PersonViewer.vue | 2 +- client/src/components/Select2.vue | 26 +- .../SelectionDialog/DataDialogTable.vue | 16 +- .../SelectionDialog/SelectionDialog.vue | 6 +- client/src/components/SingleItemSelector.vue | 10 +- client/src/components/Tool/ToolCard.vue | 10 +- client/src/components/Tool/ToolFooter.vue | 10 +- client/src/components/Tool/ToolForm.vue | 32 +-- .../ToolEntryPoints/ToolEntryPoints.vue | 10 +- client/src/components/ToolRecommendation.vue | 6 +- .../ToolsView/ToolsSchemaJson/ToolsJson.vue | 30 +-- client/src/components/Toolshed/Index.vue | 10 +- .../Toolshed/InstalledList/Details.vue | 8 +- .../Toolshed/SearchList/Categories.vue | 10 +- .../components/Toolshed/SearchList/Index.vue | 16 +- .../Toolshed/SearchList/Repositories.vue | 16 +- client/src/components/Upload/Collection.vue | 36 +-- client/src/components/Upload/Composite.vue | 38 +-- client/src/components/Upload/Default.vue | 36 +-- client/src/components/Upload/RulesInput.vue | 16 +- client/src/components/Upload/UploadButton.vue | 16 +- client/src/components/Upload/UploadModal.vue | 10 +- .../components/Upload/UploadModalContent.vue | 104 ++++---- .../components/User/CloudAuth/CloudAuth.vue | 6 +- .../Cleanup/CleanupOperationSummary.vue | 22 +- .../Cleanup/CleanupResultDialog.vue | 6 +- .../Cleanup/ReviewCleanupDialog.vue | 118 ++++----- .../ExternalIdentities/ExternalIdentities.vue | 6 +- .../User/ExternalIdentities/ExternalLogin.vue | 14 +- .../src/components/User/UserPreferences.vue | 36 +-- .../components/Workflow/Editor/Attributes.vue | 6 +- .../Workflow/Editor/Forms/FormOutput.vue | 6 +- .../Workflow/Editor/Forms/FormSection.vue | 6 +- .../src/components/Workflow/Editor/Index.vue | 36 +-- .../src/components/Workflow/Editor/Lint.vue | 112 ++++---- .../Workflow/Editor/MessagesModal.vue | 10 +- .../src/components/Workflow/Editor/Node.vue | 60 ++--- .../components/Workflow/Editor/NodeInput.vue | 40 +-- .../components/Workflow/Editor/NodeOutput.vue | 8 +- .../Workflow/Editor/StateUpgradeModal.vue | 14 +- .../components/Workflow/InvocationReport.vue | 16 +- .../Workflow/Run/WorkflowRunDefaultStep.vue | 14 +- .../Workflow/Run/WorkflowRunSuccess.vue | 16 +- client/src/components/Workflow/TrsImport.vue | 8 +- client/src/components/Workflow/TrsSearch.vue | 22 +- .../Workflow/TrsServerSelection.vue | 8 +- .../components/Workflow/WorkflowDropdown.vue | 2 +- .../WorkflowInvocationState/JobStep.vue | 20 +- .../admin/DataManager/DataManager.vue | 18 +- .../admin/DataManager/DataManagerJob.vue | 10 +- .../admin/DataManager/DataManagerTable.vue | 28 +- client/src/components/admin/DataTables.vue | 39 ++- .../src/components/admin/DataTablesGrid.vue | 7 +- client/src/components/admin/DataTypes.vue | 24 +- .../admin/Dependencies/ContainerIndex.vue | 98 +++---- .../admin/Dependencies/ResolutionIndex.vue | 12 +- .../admin/Dependencies/UnusedIndex.vue | 6 +- client/src/components/admin/Home.vue | 12 +- client/src/components/admin/JobLock.vue | 6 +- client/src/components/admin/Jobs.vue | 48 ++-- client/src/components/admin/SanitizeAllow.vue | 9 +- client/src/components/login/Index.vue | 30 +-- 128 files changed, 1393 insertions(+), 1396 deletions(-) diff --git a/client/src/components/Collections/ListCollectionCreator.vue b/client/src/components/Collections/ListCollectionCreator.vue index 2f9acfc8c3e..545c8663fbb 100644 --- a/client/src/components/Collections/ListCollectionCreator.vue +++ b/client/src/components/Collections/ListCollectionCreator.vue @@ -213,13 +213,8 @@ library.add(faSortAlphaDown, faUndo); Vue.use(BootstrapVue); export default { - mixins: [mixin], - created() { - this._instanceSetUp(); - this._elementsSetUp(); - this.saveOriginalNames(); - }, components: { DatasetCollectionElementView, draggable, FontAwesomeIcon }, + mixins: [mixin], data: function () { return { state: "build", //error @@ -274,6 +269,11 @@ export default { return this.duplicateNames.length > 0; }, }, + created() { + this._instanceSetUp(); + this._elementsSetUp(); + this.saveOriginalNames(); + }, methods: { l(str) { // _l conflicts private methods of Vue internals, expose as l instead diff --git a/client/src/components/Collections/ListDatasetCollectionElementView.vue b/client/src/components/Collections/ListDatasetCollectionElementView.vue index b9638404b76..2e6d0bb1d66 100644 --- a/client/src/components/Collections/ListDatasetCollectionElementView.vue +++ b/client/src/components/Collections/ListDatasetCollectionElementView.vue @@ -11,9 +11,7 @@ import _l from "utils/localization"; import ClickToEdit from "./common/ClickToEdit"; export default { - created: function () { - this.elementName = this.element.name; - }, + components: { ClickToEdit }, props: { element: { required: true, @@ -27,7 +25,14 @@ export default { elementName: "", }; }, - components: { ClickToEdit }, + watch: { + elementName() { + this.$emit("onRename", this.elementName); + }, + }, + created: function () { + this.elementName = this.element.name; + }, methods: { l(str) { // _l conflicts private methods of Vue internals, expose as l instead @@ -41,11 +46,6 @@ export default { return "ListDatasetCollectionElementView()"; }, }, - watch: { - elementName() { - this.$emit("onRename", this.elementName); - }, - }, }; diff --git a/client/src/components/Collections/PairCollectionCreator.vue b/client/src/components/Collections/PairCollectionCreator.vue index eb3517d4393..3afefe4d07c 100644 --- a/client/src/components/Collections/PairCollectionCreator.vue +++ b/client/src/components/Collections/PairCollectionCreator.vue @@ -158,14 +158,6 @@ import BootstrapVue from "bootstrap-vue"; Vue.use(BootstrapVue); export default { mixins: [mixin], - created() { - this._elementsSetUp(); - this.initialSuggestedName = this._guessNameForPair( - this.workingElements[0], - this.workingElements[1], - this.removeExtensions - ); - }, data: function () { return { state: "build", //error @@ -201,6 +193,14 @@ export default { return this.workingElements.length == 2; }, }, + created() { + this._elementsSetUp(); + this.initialSuggestedName = this._guessNameForPair( + this.workingElements[0], + this.workingElements[1], + this.removeExtensions + ); + }, methods: { l(str) { // _l conflicts private methods of Vue internals, expose as l instead diff --git a/client/src/components/Collections/PairedElementView.vue b/client/src/components/Collections/PairedElementView.vue index a742f3eb900..22e1af316bf 100644 --- a/client/src/components/Collections/PairedElementView.vue +++ b/client/src/components/Collections/PairedElementView.vue @@ -19,16 +19,6 @@ import ClickToEdit from "./common/ClickToEdit.vue"; import _l from "utils/localization"; export default { components: { ClickToEdit }, - created: function () { - this.name = this.pair.name; - }, - data: function () { - return { - unpairButtonTitle: _l("Unpair"), - titlePairName: _l("Click to rename"), - name: "", - }; - }, props: { pair: { required: true, @@ -38,11 +28,12 @@ export default { type: Function, }, }, - methods: { - l(str) { - // _l conflicts private methods of Vue internals, expose as l instead - return _l(str); - }, + data: function () { + return { + unpairButtonTitle: _l("Unpair"), + titlePairName: _l("Click to rename"), + name: "", + }; }, watch: { pair() { @@ -52,5 +43,14 @@ export default { this.$emit("onPairRename", this.name); }, }, + created: function () { + this.name = this.pair.name; + }, + methods: { + l(str) { + // _l conflicts private methods of Vue internals, expose as l instead + return _l(str); + }, + }, }; diff --git a/client/src/components/Collections/PairedListCollectionCreator.vue b/client/src/components/Collections/PairedListCollectionCreator.vue index 36238198529..b9b9bfff122 100644 --- a/client/src/components/Collections/PairedListCollectionCreator.vue +++ b/client/src/components/Collections/PairedListCollectionCreator.vue @@ -422,15 +422,6 @@ import BootstrapVue from "bootstrap-vue"; Vue.use(BootstrapVue); export default { - mixins: [mixin], - created() { - this.strategy = this.autopairLCS; - //TODO convert to Fwd/Rev - // Setup inital filters and shallow copy the items - this.forwardFilter = this.commonFilters[this.DEFAULT_FILTERS][0]; - this.reverseFilter = this.commonFilters[this.DEFAULT_FILTERS][1]; - this._elementsSetUp(); - }, components: { UnpairedDatasetElementView, PairedElementView, @@ -438,6 +429,7 @@ export default { Pane, draggable, }, + mixins: [mixin], data: function () { return { state: "build", //error, duplicates @@ -533,6 +525,79 @@ export default { duplicatePairNames: [], }; }, + computed: { + forwardElements: { + get() { + return this.filterElements(this.workingElements, this.forwardFilter); + }, + }, + reverseElements: { + get() { + return this.filterElements(this.workingElements, this.reverseFilter); + }, + }, + pairableElements: { + get() { + var pairable = []; + this.forwardElements.forEach((elem, index) => { + if (this.reverseElements[index] && elem.id != this.reverseElements[index].id) { + pairable.push({ + forward: this.forwardElements[index], + reverse: this.reverseElements[index], + }); + } + }); + return pairable; + }, + }, + numOfUnpairedForwardElements: function () { + return this.forwardElements.length; + }, + numOfFilteredOutForwardElements: function () { + return this.workingElements.length - this.numOfUnpairedForwardElements; + }, + numOfUnpairedReverseElements: function () { + return this.reverseElements.length; + }, + numOfFilteredOutReverseElements: function () { + return this.workingElements.length - this.numOfUnpairedReverseElements; + }, + numOfPairs: function () { + return this.pairedElements.length; + }, + returnInvalidElementsLength: function () { + return this.invalidElements.length > 0; + }, + returnInvalidElements: function () { + return this.invalidElements; + }, + allElementsAreInvalid: function () { + return this.initialElements.length == this.invalidElements.length; + }, + noElementsSelected: function () { + return this.initialElements.length == 0; + }, + tooFewElementsSelected: function () { + return this.workingElements.length < 2 && this.pairedElements.length == 0; + }, + showDuplicateError() { + return this.duplicatePairNames.length > 0; + }, + noUnpairedElementsDisplayed() { + return this.numOfUnpairedForwardElements + this.numOfUnpairedReverseElements == 0; + }, + renderPairButton() { + return this; + }, + }, + created() { + this.strategy = this.autopairLCS; + //TODO convert to Fwd/Rev + // Setup inital filters and shallow copy the items + this.forwardFilter = this.commonFilters[this.DEFAULT_FILTERS][0]; + this.reverseFilter = this.commonFilters[this.DEFAULT_FILTERS][1]; + this._elementsSetUp(); + }, methods: { l(str) { // _l conflicts private methods of Vue internals, expose as l instead @@ -947,71 +1012,6 @@ export default { return name.includes(".") ? name.substring(0, name.lastIndexOf(".")) : name; }, }, - computed: { - forwardElements: { - get() { - return this.filterElements(this.workingElements, this.forwardFilter); - }, - }, - reverseElements: { - get() { - return this.filterElements(this.workingElements, this.reverseFilter); - }, - }, - pairableElements: { - get() { - var pairable = []; - this.forwardElements.forEach((elem, index) => { - if (this.reverseElements[index] && elem.id != this.reverseElements[index].id) { - pairable.push({ - forward: this.forwardElements[index], - reverse: this.reverseElements[index], - }); - } - }); - return pairable; - }, - }, - numOfUnpairedForwardElements: function () { - return this.forwardElements.length; - }, - numOfFilteredOutForwardElements: function () { - return this.workingElements.length - this.numOfUnpairedForwardElements; - }, - numOfUnpairedReverseElements: function () { - return this.reverseElements.length; - }, - numOfFilteredOutReverseElements: function () { - return this.workingElements.length - this.numOfUnpairedReverseElements; - }, - numOfPairs: function () { - return this.pairedElements.length; - }, - returnInvalidElementsLength: function () { - return this.invalidElements.length > 0; - }, - returnInvalidElements: function () { - return this.invalidElements; - }, - allElementsAreInvalid: function () { - return this.initialElements.length == this.invalidElements.length; - }, - noElementsSelected: function () { - return this.initialElements.length == 0; - }, - tooFewElementsSelected: function () { - return this.workingElements.length < 2 && this.pairedElements.length == 0; - }, - showDuplicateError() { - return this.duplicatePairNames.length > 0; - }, - noUnpairedElementsDisplayed() { - return this.numOfUnpairedForwardElements + this.numOfUnpairedReverseElements == 0; - }, - renderPairButton() { - return this; - }, - }, };