opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add missing var declarations.

Browse Source 
In all these cases, a variable was not declared to be a local using `var` (and hence was implicitly interpreted as a global variable), but all uses of that variable were preceded by a definition within the same function, suggesting that the variable was, in fact, meant to be local, not global.
This commit is contained in:
Max Schaefer
2017-08-16 15:22:42 +01:00
parent 7ef9b4cdaf
commit 43ddd47320
52 changed files with 125 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/communication/template/communication.js
+3 -3
View File
@@ -70,7 +70,7 @@ var events_module = {
}
else { // normal message sharing when connected
var room = utils.check_room_by_roomname( click_events.connected_room, msg.chatroom );
$el_room_msg = $( '#all_messages_' + room.id );
var $el_room_msg = $( '#all_messages_' + room.id );
utils.append_message( $el_room_msg, utils.build_message( msg ) );
utils.vertical_center_align_gravatar( $( '#all_messages_' + room.id + ' .message' ) );
utils.fancyscroll_to_last( $( "#galaxy_tabroom_" + room.id ) );
@@ -192,8 +192,8 @@ var click_events = {
},
// makes disconnect and raises disconnect event at the server
make_disconnect: function ( uid, $el_input_text, $el_online_status ) {
var send_data = {}
disconnected_message = 'You are now disconnected. To send/receive messages, please connect';
var send_data = {};
var disconnected_message = 'You are now disconnected. To send/receive messages, please connect';
click_events.is_connected = false;
socket.emit( 'event disconnect', send_data );
sessionStorage.removeItem( uid );