From 3dfbbc7e081cae0c8b95b727e3791915afcc47ec Mon Sep 17 00:00:00 2001
From: Dannon Baker <dannon.baker@gmail.com>
Date: Fri, 1 Dec 2017 14:41:20 -0500
Subject: [PATCH] Provide Galaxy.config var to indicate whether onload webhooks
 should kick off; use it.  Fixes shed/reports use of them.

---
 client/galaxy/scripts/onload.js               | 29 ++++++++++---------
 lib/galaxy/webapps/galaxy/controllers/root.py |  1 +
 2 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/client/galaxy/scripts/onload.js b/client/galaxy/scripts/onload.js
index 7ab257568f8..20822afc8f1 100644
--- a/client/galaxy/scripts/onload.js
+++ b/client/galaxy/scripts/onload.js
@@ -204,20 +204,23 @@ $(document).ready(() => {
     }
 
     function onloadWebhooks() {
-        if (Galaxy.root !== undefined) {
-            // Load all webhooks with the type 'onload'
-            $.getJSON(`${Galaxy.root}api/webhooks/onload/all`, webhooks => {
-                _.each(webhooks, webhook => {
-                    if (webhook.activate && webhook.script) {
-                        $("<script/>", { type: "text/javascript" })
-                            .text(webhook.script)
-                            .appendTo("head");
-                        $("<style/>", { type: "text/css" })
-                            .text(webhook.styles)
-                            .appendTo("head");
-                    }
+        // Wait until Galaxy.config is loaded.
+        if (Galaxy.config) {
+            if (Galaxy.config.enable_webhooks){
+                // Load all webhooks with the type 'onload'
+                $.getJSON(`${Galaxy.root}api/webhooks/onload/all`, webhooks => {
+                    _.each(webhooks, webhook => {
+                        if (webhook.activate && webhook.script) {
+                            $("<script/>", { type: "text/javascript" })
+                                .text(webhook.script)
+                                .appendTo("head");
+                            $("<style/>", { type: "text/css" })
+                                .text(webhook.styles)
+                                .appendTo("head");
+                        }
+                    });
                 });
-            });
+            }
         } else {
             setTimeout(onloadWebhooks, 100);
         }
diff --git a/lib/galaxy/webapps/galaxy/controllers/root.py b/lib/galaxy/webapps/galaxy/controllers/root.py
index 7dbb88015f5..dcf876cfb9f 100644
--- a/lib/galaxy/webapps/galaxy/controllers/root.py
+++ b/lib/galaxy/webapps/galaxy/controllers/root.py
@@ -52,6 +52,7 @@ class RootController(controller.JSAppLauncher, UsesAnnotations):
         config = {
             'active_view'                   : 'analysis',
             'enable_cloud_launch'           : app.config.get_bool('enable_cloud_launch', False),
+            'enable_webhooks'               : True if app.webhooks_registry.webhooks else False,
             # TODO: next two should be redundant - why can't we build one from the other?
             'toolbox'                       : app.toolbox.to_dict(trans, in_panel=False),
             'toolbox_in_panel'              : app.toolbox.to_dict(trans),