From 3dae54a672815be5f52a9e6e89340fd4ac4a0bb6 Mon Sep 17 00:00:00 2001 From: Matthias Bernt Date: Mon, 11 Mar 2024 15:23:52 +0100 Subject: [PATCH] make it a warning --- lib/galaxy/tool_util/linters/general.py | 2 +- test/unit/tool_util/test_tool_linters.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/galaxy/tool_util/linters/general.py b/lib/galaxy/tool_util/linters/general.py index 35642210f06..10fe98e9000 100644 --- a/lib/galaxy/tool_util/linters/general.py +++ b/lib/galaxy/tool_util/linters/general.py @@ -240,4 +240,4 @@ class BioToolsValid(Linter): continue metadata_source = ApiBiotoolsMetadataSource() if not metadata_source.get_biotools_metadata(xref["value"]): - lint_ctx.error(f'No entry {xref["value"]} in bio.tools.', linter=cls.name(), node=tool_node) + lint_ctx.warn(f'No entry {xref["value"]} in bio.tools.', linter=cls.name(), node=tool_node) diff --git a/test/unit/tool_util/test_tool_linters.py b/test/unit/tool_util/test_tool_linters.py index 324825c44e2..77f47be6b71 100644 --- a/test/unit/tool_util/test_tool_linters.py +++ b/test/unit/tool_util/test_tool_linters.py @@ -1095,11 +1095,11 @@ def test_general_valid_new_profile_fmt(lint_ctx): def test_general_valid_biotools(lint_ctx): tool_source = get_xml_tool_source(GENERAL_VALID_BIOTOOLS) run_lint_module(lint_ctx, general, tool_source) - assert "No entry johnscoolbowtie in bio.tools." in lint_ctx.error_messages + assert "No entry johnscoolbowtie in bio.tools." in lint_ctx.warn_messages assert not lint_ctx.info_messages assert len(lint_ctx.valid_messages) == 4 - assert not lint_ctx.warn_messages - assert len(lint_ctx.error_messages) == 1 + assert len(lint_ctx.warn_messages) == 1 + assert not lint_ctx.error_messages def test_help_multiple(lint_ctx):