From 14259b11d9a5f6238153556ed5a28bf89468e2b4 Mon Sep 17 00:00:00 2001 From: Nicola Soranzo Date: Wed, 13 Dec 2017 20:56:37 +0000 Subject: [PATCH 1/2] Python3: finish first pass on whole codebase --- .ci/py3_sources.txt | 84 ------------------- .../demo/tour_generator/helper/__init__.py | 2 +- lib/galaxy/containers/docker_swarm_manager.py | 4 +- lib/galaxy/datatypes/proteomics.py | 4 +- lib/galaxy/jobs/handler.py | 8 +- lib/galaxy/jobs/runners/chronos.py | 4 +- lib/galaxy/managers/hdas.py | 4 +- lib/galaxy/managers/workflows.py | 8 +- lib/galaxy/openid/providers.py | 8 +- lib/galaxy/tools/__init__.py | 2 +- lib/galaxy/tools/cwl/representation.py | 8 +- lib/galaxy/tools/imp_exp/__init__.py | 2 +- lib/galaxy/util/permutations.py | 9 +- lib/galaxy/util/script.py | 2 +- .../visualization/data_providers/basic.py | 2 +- .../visualization/data_providers/genome.py | 20 ++--- lib/galaxy/webapps/config_manage.py | 7 +- lib/galaxy/webapps/galaxy/api/authenticate.py | 3 +- .../webapps/galaxy/api/configuration.py | 2 +- lib/galaxy/webapps/galaxy/api/datasets.py | 2 +- lib/galaxy/webapps/galaxy/api/datatypes.py | 6 +- .../webapps/galaxy/api/folder_contents.py | 2 +- .../webapps/galaxy/api/history_contents.py | 4 +- lib/galaxy/webapps/galaxy/api/jobs.py | 4 +- .../galaxy/api/tool_shed_repositories.py | 6 +- lib/galaxy/webapps/galaxy/api/tools.py | 19 +++-- lib/galaxy/webapps/galaxy/api/toolshed.py | 4 +- .../webapps/galaxy/controllers/admin.py | 4 +- .../webapps/galaxy/controllers/async.py | 8 +- .../galaxy/controllers/data_manager.py | 2 +- .../webapps/galaxy/controllers/dataset.py | 24 +++--- lib/galaxy/webapps/galaxy/controllers/root.py | 2 +- lib/galaxy/webapps/galaxy/controllers/user.py | 4 +- .../webapps/galaxy/controllers/workflow.py | 18 ++-- .../webapps/tool_shed/api/repositories.py | 4 +- .../webapps/tool_shed/controllers/admin.py | 4 +- .../tool_shed/controllers/repository.py | 8 +- .../webapps/tool_shed/security/__init__.py | 4 +- .../webapps/tool_shed/util/hgweb_config.py | 9 +- scripts/build_universe_config.py | 3 +- scripts/data_libraries/build_lucene_index.py | 8 +- scripts/galaxy-main | 7 +- scripts/helper.py | 3 +- scripts/loc_files/create_all_fasta_loc.py | 31 ++----- scripts/microbes/create_bacteria_loc_file.py | 22 ++--- scripts/microbes/create_bacteria_table.py | 34 ++++---- scripts/microbes/create_nib_seq_loc_file.py | 22 ++--- scripts/microbes/get_builds_lengths.py | 22 ++--- scripts/microbes/harvest_bacteria.py | 4 +- scripts/microbes/ncbi_to_ucsc.py | 27 +++--- scripts/microbes/util.py | 11 ++- scripts/others/incorrect_gops_jobs.py | 4 +- scripts/others/incorrect_gops_join_jobs.py | 4 +- scripts/paster.py | 5 +- scripts/set_dataset_sizes.py | 2 +- scripts/set_user_disk_usage.py | 3 +- scripts/sync_reports_config.py | 3 +- .../api/get_filtered_repository_revisions.py | 4 +- .../bootstrap_tool_shed/bootstrap_util.py | 10 +-- .../create_user_with_api_key.py | 8 +- scripts/tool_shed/check_download_urls.py | 8 +- .../migrate_tools_to_repositories.py | 6 +- scripts/transfer.py | 23 ++--- scripts/update_shed_config_path.py | 4 +- tools/genomespace/genomespace_importer.py | 4 +- 65 files changed, 259 insertions(+), 344 deletions(-) delete mode 100644 .ci/py3_sources.txt diff --git a/.ci/py3_sources.txt b/.ci/py3_sources.txt deleted file mode 100644 index 9f3df8c309d..00000000000 --- a/.ci/py3_sources.txt +++ /dev/null @@ -1,84 +0,0 @@ -client/galaxy/style/source_material/circle.py -contrib/ -cron/ -doc/parse_gx_xsd.py -doc/patch.py -lib/galaxy/actions/ -lib/galaxy/auth/ -lib/galaxy/config.py -lib/galaxy/containers/ -lib/galaxy/dataset_collections/ -lib/galaxy/datatypes/ -lib/galaxy/dependencies/ -lib/galaxy/eggs/ -lib/galaxy/exceptions/ -lib/galaxy/external_services/ -lib/galaxy/forms/ -lib/galaxy/jobs/ -lib/galaxy/managers/ -lib/galaxy/model/ -lib/galaxy/objectstore/ -lib/galaxy/openid/ -lib/galaxy/quota/ -lib/galaxy/sample_tracking/ -lib/galaxy/security/ -lib/galaxy/tags/ -lib/galaxy/tools/ -lib/galaxy/tours/ -lib/galaxy/util/ -lib/galaxy/visualization/ -lib/galaxy/web/ -lib/galaxy/webapps/galaxy/api/histories.py -lib/galaxy/webapps/galaxy/api/library_datasets.py -lib/galaxy/webapps/galaxy/api/tours.py -lib/galaxy/webapps/galaxy/api/users.py -lib/galaxy/webapps/galaxy/api/workflows.py -lib/galaxy/webapps/galaxy/buildapp.py -lib/galaxy/webapps/galaxy/controllers/admin_toolshed.py -lib/galaxy/webapps/galaxy/controllers/external_services.py -lib/galaxy/webapps/galaxy/controllers/forms.py -lib/galaxy/webapps/galaxy/controllers/history.py -lib/galaxy/webapps/galaxy/controllers/library_common.py -lib/galaxy/webapps/galaxy/controllers/search.py -lib/galaxy/webapps/galaxy/controllers/userskeys.py -lib/galaxy/webapps/reports/config.py -lib/galaxy/webapps/reports/controllers/tools.py -lib/galaxy/webapps/reports/__init__.py -lib/galaxy/webapps/tool_shed/config.py -lib/galaxy/webapps/tool_shed/controllers/groups.py -lib/galaxy/webapps/tool_shed/controllers/user.py -lib/galaxy/webapps/tool_shed/framework/middleware/remoteuser.py -lib/galaxy/webapps/tool_shed/__init__.py -lib/galaxy/webapps/tool_shed/model/__init__.py -lib/galaxy/webapps/tool_shed/search/repo_search.py -lib/galaxy/webapps/tool_shed/util/ratings_util.py -lib/galaxy/webhooks/ -lib/galaxy/work/ -lib/galaxy/workflow/ -lib/galaxy_ext/ -lib/log_tempfile.py -lib/mimeparse.py -lib/psyco_full.py -lib/tool_shed/ -scripts/api/ -scripts/auth/ -scripts/bootstrap_history.py -scripts/build_toolbox.py -scripts/check_eggs.py -scripts/check_galaxy.py -scripts/check_python.py -scripts/cleanup_datasets/ -scripts/communication/ -scripts/data_libraries/build_whoosh_index.py -scripts/db_shell.py -scripts/drmaa_external_runner.py -scripts/metagenomics/ -scripts/microbes/BeautifulSoup.py -scripts/microbes/harvest_bacteria.py -scripts/secret_decoder_ring.py -scripts/tool_shed/api/common.py -scripts/tool_shed/build_ts_whoosh_index.py -scripts/tool_shed/deprecate_repositories_without_metadata.py -test/ -tool_list.py -tools/ diff --git a/config/plugins/webhooks/demo/tour_generator/helper/__init__.py b/config/plugins/webhooks/demo/tour_generator/helper/__init__.py index 932997f4a10..3d0c6e11c38 100644 --- a/config/plugins/webhooks/demo/tour_generator/helper/__init__.py +++ b/config/plugins/webhooks/demo/tour_generator/helper/__init__.py @@ -174,7 +174,7 @@ class TourGenerator(object): elif input.type == 'select': params = [] if name in test_inputs: - for option in self._tool.inputs[name].static_options: + for option in input.static_options: for test_option in self._test.inputs[name]: if test_option == option[1]: params.append(option[0]) diff --git a/lib/galaxy/containers/docker_swarm_manager.py b/lib/galaxy/containers/docker_swarm_manager.py index 9a937377f16..2cd6c64e522 100644 --- a/lib/galaxy/containers/docker_swarm_manager.py +++ b/lib/galaxy/containers/docker_swarm_manager.py @@ -46,7 +46,7 @@ SWARM_MANAGER_CONF_DEFAULTS = { 'service_wait_count_limit': 0, 'service_wait_time_limit': 5, 'slots_min_limit': 0, - 'slots_max_limit': sys.maxint, + 'slots_max_limit': sys.maxsize, 'slots_min_spare': 0, 'node_idle_limit': 120, 'limits': [], @@ -137,7 +137,7 @@ class SwarmManager(object): state = node_state['state'] if not nodes: nodes = self._docker_interface.nodes() - node = (filter(lambda x: x.name == name, nodes) + [None])[0] + node = ([x for x in nodes if x.name == name] + [None])[0] if not node: if elapsed > self._conf.spawn_wait_time: log.warning("spawning node '%s' not found in `docker node ls` and spawn_wait_time exceeded! %d seconds have elapsed", name, elapsed) diff --git a/lib/galaxy/datatypes/proteomics.py b/lib/galaxy/datatypes/proteomics.py index a50afb720dd..2ca7ff891f3 100644 --- a/lib/galaxy/datatypes/proteomics.py +++ b/lib/galaxy/datatypes/proteomics.py @@ -449,7 +449,7 @@ class ImzML(Binary): def generate_primary_file(self, dataset=None): rval = ['imzML Composite Dataset

'] rval.append('

This composite dataset is composed of the following files: