From e86216a64f15dc2733fd4fdec1817b3206c5e651 Mon Sep 17 00:00:00 2001 From: Assunta DeSanto Date: Tue, 2 Mar 2021 17:21:20 -0500 Subject: [PATCH 1/6] Create pull_request_template.md Proposed PR Template based on Contributing Guidelines --- pull_request_template.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 pull_request_template.md diff --git a/pull_request_template.md b/pull_request_template.md new file mode 100644 index 00000000000..88f3238fc72 --- /dev/null +++ b/pull_request_template.md @@ -0,0 +1,18 @@ +## Why did you make this change? +(cite Issue # OR provide rationalization of changes if no issue exists) + + + +## What did you do? +- [add implementation details here] +- + + +## How to test the changes? +(select the most appropriate option; if the latter, provide steps for testing below) +- [ ] I've included a unit or integration test +- [ ] I've included instructions on how to test my changes + +## Steps for testing: +1. [add testing steps here or delete this section if you wrote a test for your changes] +2. From bd9a5e1dfbba936146c888241d80aa3a8dfcde4f Mon Sep 17 00:00:00 2001 From: Assunta DeSanto Date: Tue, 2 Mar 2021 22:36:16 -0500 Subject: [PATCH 2/6] Updates to pull_request_template.md Updates out of review --- pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 88f3238fc72..bd8e6d1ccc1 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -4,13 +4,13 @@ ## What did you do? -- [add implementation details here] +- [describe the proposed changes] - ## How to test the changes? (select the most appropriate option; if the latter, provide steps for testing below) -- [ ] I've included a unit or integration test +- [ ] I've included appropriate automated tests - [ ] I've included instructions on how to test my changes ## Steps for testing: From 699919c46b8dca5c60bf963c5a6635908b796598 Mon Sep 17 00:00:00 2001 From: Assunta DeSanto Date: Wed, 3 Mar 2021 10:51:01 -0500 Subject: [PATCH 3/6] Update pull_request_template.md --- pull_request_template.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index bd8e6d1ccc1..4e274c0622b 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -10,9 +10,10 @@ ## How to test the changes? (select the most appropriate option; if the latter, provide steps for testing below) -- [ ] I've included appropriate automated tests +- [ ] I've included appropriate automated tests (https://docs.galaxyproject.org/en/latest/dev/writing_tests.html) - [ ] I've included instructions on how to test my changes + i. [add testing steps here or delete this section if you wrote a test for your changes] + ii. -## Steps for testing: -1. [add testing steps here or delete this section if you wrote a test for your changes] -2. +## For UI Components +- [ ] I've included a screenshot of the changes From 4f6d7b3a61af9524ca315551bc098866c5d5b347 Mon Sep 17 00:00:00 2001 From: Assunta DeSanto Date: Wed, 3 Mar 2021 10:59:28 -0500 Subject: [PATCH 4/6] Update to pull_request_template.md --- pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 4e274c0622b..4255c3e383e 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -11,9 +11,9 @@ ## How to test the changes? (select the most appropriate option; if the latter, provide steps for testing below) - [ ] I've included appropriate automated tests (https://docs.galaxyproject.org/en/latest/dev/writing_tests.html) -- [ ] I've included instructions on how to test my changes - i. [add testing steps here or delete this section if you wrote a test for your changes] - ii. +- [ ] Instructions for manual testing is as follows: + +1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes] ## For UI Components - [ ] I've included a screenshot of the changes From 84a33e6ecb2e3086d2b1f6f6ff3431ff6214d2dc Mon Sep 17 00:00:00 2001 From: Assunta DeSanto Date: Wed, 3 Mar 2021 11:01:35 -0500 Subject: [PATCH 5/6] Grammar edit --- pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pull_request_template.md b/pull_request_template.md index 4255c3e383e..2aa5a2b0707 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -11,7 +11,7 @@ ## How to test the changes? (select the most appropriate option; if the latter, provide steps for testing below) - [ ] I've included appropriate automated tests (https://docs.galaxyproject.org/en/latest/dev/writing_tests.html) -- [ ] Instructions for manual testing is as follows: +- [ ] Instructions for manual testing are as follows: 1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes] From aa00e58f083e97b4fa2c95f19dde96ce287bcbd0 Mon Sep 17 00:00:00 2001 From: Assunta DeSanto Date: Wed, 3 Mar 2021 17:09:20 -0500 Subject: [PATCH 6/6] Updated order and added suggested changes to Why --- pull_request_template.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 2aa5a2b0707..2affb105a5f 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,13 +1,13 @@ -## Why did you make this change? -(cite Issue # OR provide rationalization of changes if no issue exists) - - - ## What did you do? - [describe the proposed changes] - +## Why did you make this change? +(Cite Issue number OR provide rationalization of changes if no issue exists) +(If fixing a bug, please add any relevant error or traceback) + + ## How to test the changes? (select the most appropriate option; if the latter, provide steps for testing below) - [ ] I've included appropriate automated tests (https://docs.galaxyproject.org/en/latest/dev/writing_tests.html)