From 35dcde758cd2a25857573231b7a55e00d14029e0 Mon Sep 17 00:00:00 2001 From: Nicola Soranzo Date: Mon, 13 Apr 2026 17:17:21 +0100 Subject: [PATCH] Pin rocrate<0.15.0 until roc-validator supports RO-Crate Metadata Specification 1.2 rocrate 0.15.0 produces crates conforming to 1.2 spec by default, which causes roc-validator validation errors like: ``` The RO-Crate metadata file descriptor MUST have a `conformsTo` property with the RO-Crate specification version ``` xref https://github.com/crs4/rocrate-validator/issues/107 Also: - Remove unused `BaseWorkflowPopulator.validate_invocation_crate_directory()` method. --- lib/galaxy_test/base/populators.py | 7 ------- packages/data/setup.cfg | 2 +- pyproject.toml | 2 +- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/galaxy_test/base/populators.py b/lib/galaxy_test/base/populators.py index 3033812c5ed..48c4e4b6b40 100644 --- a/lib/galaxy_test/base/populators.py +++ b/lib/galaxy_test/base/populators.py @@ -2551,13 +2551,6 @@ class BaseWorkflowPopulator(BasePopulator): ) return ROCrate(crate_response) - def validate_invocation_crate_directory(self, crate_directory): - # TODO: where can a ro_crate be extracted - metadata_json_path = crate_directory / "ro-crate-metadata.json" - with metadata_json_path.open() as f: - metadata_json = json.load(f) - assert metadata_json["@context"] == "https://w3id.org/ro/crate/1.1/context" - def invoke_workflow_raw(self, workflow_id: str, request: dict, assert_ok: bool = False) -> Response: url = f"workflows/{workflow_id}/invocations" invocation_response = self._post(url, data=request, json=True) diff --git a/packages/data/setup.cfg b/packages/data/setup.cfg index 1f66931764d..2710d967275 100644 --- a/packages/data/setup.cfg +++ b/packages/data/setup.cfg @@ -59,7 +59,7 @@ install_requires = pypng python-magic pysam>=0.21 - rocrate + rocrate<0.15.0 social-auth-core>=4.5.0 SQLAlchemy>=2.0.37,<2.1,!=2.0.41 tifffile diff --git a/pyproject.toml b/pyproject.toml index 8d02fa693b0..b932a121cc8 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -91,7 +91,7 @@ dependencies = [ "refgenconf>=0.13.0", # https://github.com/refgenie/refgenconf/pull/149 "regex", "requests", - "rocrate", + "rocrate<0.15.0", # https://github.com/crs4/rocrate-validator/issues/107 "Routes", "s3fs>=2023.1.0", "schema-salad>=8.7.20240905150001", # Python 3.13 support