opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4576 from jmchilton/selenium_fixes_21

Browse Source 
Make submitting logins for Selenium tests a bit more robust.
This commit is contained in:
Martin Cech
2017-09-08 15:00:44 -04:00
committed by GitHub
parent 508fdb9d2b 46b799dfbb
commit 28fd37be40
2 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/selenium_tests/test_login.py
+4 -4
View File
@@ -10,7 +10,7 @@ class LoginTestCase(SeleniumTestCase):
self.register(email)
self.logout_if_needed()
self.home()
self.submit_login(email)
self.submit_login(email, assert_valid=True)
with self.main_panel():
self.assert_no_error_message()
assert self.is_logged_in()
@@ -20,7 +20,7 @@ class LoginTestCase(SeleniumTestCase):
bad_emails = ['test2@test.org', 'test', '', "'; SELECT * FROM galaxy_user WHERE 'u' = 'u';"]
for bad_email in bad_emails:
self.home()
self.submit_login(bad_email)
self.submit_login(bad_email, assert_valid=False)
with self.main_panel():
self.assert_error_message()
@@ -29,7 +29,7 @@ class LoginTestCase(SeleniumTestCase):
bad_passwords = ['1234', '', '; SELECT * FROM galaxy_user']
for bad_password in bad_passwords:
self.home()
self.submit_login(self._get_random_email(), password=bad_password)
self.submit_login(self._get_random_email(), password=bad_password, assert_valid=False)
with self.main_panel():
self.assert_error_message()
@@ -39,6 +39,6 @@ class LoginTestCase(SeleniumTestCase):
self.register(email)
self.logout_if_needed()
self.home()
self.submit_login(email, password="12345678")
self.submit_login(email, password="12345678", assert_valid=False)
with self.main_panel():
self.assert_error_message()