From 2783fb6018d3640f4f1960fb2c8a82db454ee44b Mon Sep 17 00:00:00 2001 From: John Davis Date: Wed, 31 Jan 2024 18:45:41 -0500 Subject: [PATCH] Ignore lines starting with # in build packages script --- packages/build_packages.sh | 11 ++++++----- packages/test.sh | 11 ++++++----- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/packages/build_packages.sh b/packages/build_packages.sh index dde18ce1132..33a13039eca 100755 --- a/packages/build_packages.sh +++ b/packages/build_packages.sh @@ -8,12 +8,13 @@ set -ex # Change to packages directory. cd "$(dirname "$0")" -# ensure ordered by dependency dag +# Ensure ordered by dependency dag while read -r package_dir; do - if [ -z "$package_dir" ]; then - # Skip empty lines - continue - fi + # Ignore empty lines + [[ -z "$package_dir" ]] && continue + # Ignore lines beginning with `#` + [[ "$package_dir" =~ ^#.* ]] && continue + printf "\n========= RELEASING PACKAGE %s =========\n\n" "$package_dir" cd "$package_dir" diff --git a/packages/test.sh b/packages/test.sh index 0e41ee92268..a19b2d982ce 100755 --- a/packages/test.sh +++ b/packages/test.sh @@ -31,12 +31,13 @@ if [ $FOR_PULSAR -eq 0 ]; then pip install -r../lib/galaxy/dependencies/pinned-typecheck-requirements.txt fi -# ensure ordered by dependency DAG +# Ensure ordered by dependency DAG while read -r package_dir || [ -n "$package_dir" ]; do # https://stackoverflow.com/questions/12916352/shell-script-read-missing-last-line - if [ -z "$package_dir" ]; then - # Skip empty lines - continue - fi + # Ignore empty lines + [[ -z "$package_dir" ]] && continue + # Ignore lines beginning with `#` + [[ "$package_dir" =~ ^#.* ]] && continue + printf "\n========= TESTING PACKAGE ${package_dir} =========\n\n" cd "$package_dir"