From 23164decedb2f20bed341f6f08cff1d140d1ff8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20L=C3=B3pez?= <46503462+davelopez@users.noreply.github.com> Date: Tue, 16 Apr 2024 17:01:42 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: John Davis --- .../config/templates/mail/notifications/message-email.html | 6 +++--- .../config/templates/mail/notifications/message-email.txt | 2 +- .../templates/mail/notifications/new_shared_item-email.html | 4 ++-- .../templates/mail/notifications/new_shared_item-email.txt | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/galaxy/config/templates/mail/notifications/message-email.html b/lib/galaxy/config/templates/mail/notifications/message-email.html index 1ebccda977a..e690ecc3266 100644 --- a/lib/galaxy/config/templates/mail/notifications/message-email.html +++ b/lib/galaxy/config/templates/mail/notifications/message-email.html @@ -1,12 +1,12 @@ -Use this template to customize the HTML email your users will receive +Use this template to customize the HTML-formatted email your users will receive when a new notification of category "message" is sent to them. Copy the file to {{ templates_dir }}/mail/notifications/message-email.html and modify as required. -If you are adding URLs into this, remember that only absolute URLS (with +If you are adding URLs, remember that only absolute URLs (with a domain name) make sense in email! They can be served from any stable location, including your Galaxy server or GitHub. -The following variables are available for inserting into the html with Jinja2 +The following variables are available for inserting into the HTML with Jinja2 syntax, like {{ variable_name }}. They will be rendered into the text before the email is sent: diff --git a/lib/galaxy/config/templates/mail/notifications/message-email.txt b/lib/galaxy/config/templates/mail/notifications/message-email.txt index 1cecfd06a05..2e40a42d185 100644 --- a/lib/galaxy/config/templates/mail/notifications/message-email.txt +++ b/lib/galaxy/config/templates/mail/notifications/message-email.txt @@ -2,7 +2,7 @@ Use this template to customize the text email your users will receive when a new notification of category "message" is sent to them. Copy the file to {{ templates_dir }}/mail/notifications/message-email.txt and modify as required. -If you are adding URLs into this, remember that only absolute URLS (with +If you are adding URLs, remember that only absolute URLs (with a domain name) make sense in email! They can be served from any stable location, including your Galaxy server or GitHub. diff --git a/lib/galaxy/config/templates/mail/notifications/new_shared_item-email.html b/lib/galaxy/config/templates/mail/notifications/new_shared_item-email.html index 9dec5fe3bed..cb6905a6ec9 100644 --- a/lib/galaxy/config/templates/mail/notifications/new_shared_item-email.html +++ b/lib/galaxy/config/templates/mail/notifications/new_shared_item-email.html @@ -2,11 +2,11 @@ Use this template to customize the HTML email your users will receive when a new notification of category "new_shared_item" is sent to them. Copy the file to {{ templates_dir }}/mail/notifications/new_shared_item-email.html and modify as required. -If you are adding URLs into this, remember that only absolute URLS (with +If you are adding URLs, remember that only absolute URLs (with a domain name) make sense in email! They can be served from any stable location, including your Galaxy server or GitHub. -The following variables are available for inserting into the html with Jinja2 +The following variables are available for inserting into the HTML with Jinja2 syntax, like {{ variable_name }}. They will be rendered into the text before the email is sent: diff --git a/lib/galaxy/config/templates/mail/notifications/new_shared_item-email.txt b/lib/galaxy/config/templates/mail/notifications/new_shared_item-email.txt index d38983bf458..32fb37a5b88 100644 --- a/lib/galaxy/config/templates/mail/notifications/new_shared_item-email.txt +++ b/lib/galaxy/config/templates/mail/notifications/new_shared_item-email.txt @@ -2,7 +2,7 @@ Use this template to customize the text email your users will receive when a new notification of category "new_shared_item" is sent to them. Copy the file to {{ templates_dir }}/mail/notifications/new_shared_item-email.txt and modify as required. -If you are adding URLs into this, remember that only absolute URLS (with +If you are adding URLs, remember that only absolute URLs (with a domain name) make sense in email! They can be served from any stable location, including your Galaxy server or GitHub.