From 1c9bed3419d156ed3e4be9f979480d4e1456dce5 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Wed, 28 Dec 2022 13:00:28 -0500
Subject: [PATCH] Remove unused code path related to show alert mechanism and
 associated dom objects

---
 .../src/components/Form/Elements/FormText.vue | 79 ++++++-------------
 client/src/utils/navigation/navigation.yml    |  2 +-
 .../selenium/test_personal_information.py     |  2 +-
 3 files changed, 28 insertions(+), 55 deletions(-)

diff --git a/client/src/components/Form/Elements/FormText.vue b/client/src/components/Form/Elements/FormText.vue
index 9554b292a43..8a07155ae4f 100644
--- a/client/src/components/Form/Elements/FormText.vue
+++ b/client/src/components/Form/Elements/FormText.vue
@@ -1,38 +1,29 @@
 <template>
-    <div>
-        <b-alert v-if="errorMessage" class="mt-2" :show="dismissCountDown" variant="info" @dismissed="resetAlert">
-            {{ errorMessage }}
-        </b-alert>
-        <b-row align-v="center">
-            <b-col>
-                <b-form-textarea
-                    v-if="inputArea"
-                    :id="id"
-                    v-model="currentValue"
-                    :class="['ui-text-area', cls]"
-                    :readonly="readonly"
-                    :placeholder="placeholder"
-                    :style="style"
-                    @change="resetAlert">
-                </b-form-textarea>
-                <b-form-input
-                    v-else
-                    :id="id"
-                    v-model="currentValue"
-                    :class="['ui-input', cls]"
-                    :readonly="readonly"
-                    :placeholder="placeholder"
-                    :style="style"
-                    :type="acceptedTypes"
-                    :list="`${id}-datalist`"
-                    @change="resetAlert">
-                </b-form-input>
-                <datalist v-if="datalist && !inputArea" :id="`${id}-datalist`">
-                    <option v-for="data in datalist" :key="data.value" :label="data.label" :value="data.value"></option>
-                </datalist>
-            </b-col>
-        </b-row>
-    </div>
+    <b-row align-v="center">
+        <b-col>
+            <b-form-textarea
+                v-if="inputArea"
+                :id="id"
+                v-model="currentValue"
+                :class="['ui-text-area', cls]"
+                :readonly="readonly"
+                :placeholder="placeholder"
+                :style="style" />
+            <b-form-input
+                v-else
+                :id="id"
+                v-model="currentValue"
+                :class="['ui-input', cls]"
+                :readonly="readonly"
+                :placeholder="placeholder"
+                :style="style"
+                :type="acceptedTypes"
+                :list="`${id}-datalist`" />
+            <datalist v-if="datalist && !inputArea" :id="`${id}-datalist`">
+                <option v-for="data in datalist" :key="data.value" :label="data.label" :value="data.value" />
+            </datalist>
+        </b-col>
+    </b-row>
 </template>
 
 <script>
@@ -70,7 +61,7 @@ export default {
         },
         color: {
             type: String,
-            default: "",
+            default: null,
         },
         cls: {
             // Refers to an optional custom css class name
@@ -83,13 +74,6 @@ export default {
             default: null,
         },
     },
-    data() {
-        return {
-            dismissSecs: 5,
-            dismissCountDown: 0,
-            errorMessage: "",
-        };
-    },
     computed: {
         acceptedTypes() {
             return ["text", "password"].includes(this.type) ? this.type : "text";
@@ -125,17 +109,6 @@ export default {
                 : null;
         },
     },
-    methods: {
-        showAlert(error) {
-            if (error) {
-                this.errorMessage = error;
-                this.dismissCountDown = this.dismissSecs;
-            }
-        },
-        resetAlert() {
-            this.dismissCountDown = 0;
-        },
-    },
 };
 </script>
 <style scoped>
diff --git a/client/src/utils/navigation/navigation.yml b/client/src/utils/navigation/navigation.yml
index cbdfc365b03..869da96d6ae 100644
--- a/client/src/utils/navigation/navigation.yml
+++ b/client/src/utils/navigation/navigation.yml
@@ -487,7 +487,7 @@ tool_form:
     execute: 'button#execute'
     parameter_div: 'div.ui-form-element[id="form-element-${parameter}"]'
     parameter_checkbox: 'div.ui-form-element[id="form-element-${parameter}"] .ui-switch'
-    parameter_input: 'div.ui-form-element[id="form-element-${parameter}"] .text-input'
+    parameter_input: 'div.ui-form-element[id="form-element-${parameter}"] .ui-input'
     parameter_textarea: 'div.ui-form-element[id="form-element-${parameter}"] textarea'
     reference: '.formatted-reference'
     about: '.tool-footer'
diff --git a/lib/galaxy_test/selenium/test_personal_information.py b/lib/galaxy_test/selenium/test_personal_information.py
index dfc14479609..74fdcb7e99b 100644
--- a/lib/galaxy_test/selenium/test_personal_information.py
+++ b/lib/galaxy_test/selenium/test_personal_information.py
@@ -136,7 +136,7 @@ class TestManageInformation(SeleniumTestCase):
 
     def get_address_input_field(self, address_form, input_field_label):
         return address_form.find_element(
-            self.by.CSS_SELECTOR, f"[data-label='{input_field_label}'] > div > div > div > input"
+            self.by.CSS_SELECTOR, f"[data-label='{input_field_label}'] > div > div > input"
         )