From 196c52bb8743d902d322375cbc936d7c5d2f430d Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Sun, 17 May 2026 12:38:39 -0400 Subject: [PATCH] Drop the dead lgtm comments. GitHub's CodeQL doesn't honor the lgtm[...] inline-suppression syntax -- that was the LGTM.com convention, retired in 2022. The two history_id alerts are now dismissed via the code-scanning API as confirmed false positives, so the comments do nothing but sit there as cruft. Remove them; the original false-positive context lives in the dismissal reason on alerts #407 and #410. --- test/evals/seed_staining_quantification_history.py | 3 --- test/integration/test_live_evals.py | 4 ---- 2 files changed, 7 deletions(-) diff --git a/test/evals/seed_staining_quantification_history.py b/test/evals/seed_staining_quantification_history.py index 5e25bc8e770..27cf95587e1 100644 --- a/test/evals/seed_staining_quantification_history.py +++ b/test/evals/seed_staining_quantification_history.py @@ -158,9 +158,6 @@ def _standalone_main(argv: Optional[list[str]] = None) -> int: # signature only names the test type. Cast at this boundary. populator = DatasetPopulator(cast(ApiTestInteractor, interactor)) history_id = seed_demo_history(populator) - # lgtm[py/clear-text-logging-sensitive-data] -- history_id is a Galaxy - # history id, not a credential. CodeQL flags it because the populator - # was constructed with args.galaxy_api_key. print(f"Seeded history '{HISTORY_NAME}' at id {history_id}") return 0 diff --git a/test/integration/test_live_evals.py b/test/integration/test_live_evals.py index c18b8c08f57..fbc28532a90 100644 --- a/test/integration/test_live_evals.py +++ b/test/integration/test_live_evals.py @@ -108,10 +108,6 @@ class TestLiveEvals(IntegrationTestCase): documented at the top of the file. """ history_id = seed_demo_history(self.dataset_populator) - # lgtm[py/clear-text-logging-sensitive-data] -- history_id is a - # Galaxy history id, not a credential. CodeQL flags it because the - # populator was constructed with self.galaxy_interactor (which holds - # an api_key), so any value derived from it inherits the taint. log.info("Seeded staining quantification fixture history: %s", history_id) datasets = [