From 5df78304246243488629838fad6635b6211036b0 Mon Sep 17 00:00:00 2001 From: John Chilton Date: Mon, 21 Mar 2016 12:06:35 +0000 Subject: [PATCH] Do not use "is not" to compare strings. http://stackoverflow.com/questions/1504717/why-does-comparing-strings-in-python-using-either-or-is-sometimes-produce --- lib/galaxy/tools/parameters/basic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/galaxy/tools/parameters/basic.py b/lib/galaxy/tools/parameters/basic.py index 62331e0c130..5ffcc8e92e3 100644 --- a/lib/galaxy/tools/parameters/basic.py +++ b/lib/galaxy/tools/parameters/basic.py @@ -187,7 +187,7 @@ class ToolParameter( object, Dictifiable ): return value def validate( self, value, trans=None ): - if value is not '' or not self.optional: + if value != '' or not self.optional: for validator in self.validators: validator.validate( value, trans )