From 0fec22d0159d783ae772e56a3db990b4bff0cff7 Mon Sep 17 00:00:00 2001
From: will <theappdev@protonmail.com>
Date: Thu, 16 May 2019 15:30:09 -0400
Subject: [PATCH] remove href from a tag to prevent backbone page reload and
 change some vars to const

---
 client/galaxy/scripts/components/Sharing.vue | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/client/galaxy/scripts/components/Sharing.vue b/client/galaxy/scripts/components/Sharing.vue
index e4c00dcbffe..709659ca1c4 100644
--- a/client/galaxy/scripts/components/Sharing.vue
+++ b/client/galaxy/scripts/components/Sharing.vue
@@ -25,7 +25,7 @@
                         <span id="item-url-text" style="display: none">
                             {{ item_url_parts[0] }}<span id="item-identifier">{{ item_url_parts[1] }}</span>
                         </span>
-                        <a href="#" id="edit-identifier"><img :src="pencil_url"/></a>
+                        <a href="javascript:void(0)" id="edit-identifier"><img :src="pencil_url" alt="Edit Share Url"/></a>
                     </blockquote>
                     <div v-if="item.published">
                         <p>
@@ -263,7 +263,7 @@ export default {
                 .catch(error => (this.err_msg = error.response.data.err_msg));
         },
         createSlugHandler: function() {
-            var on_start = function(text_elt) {
+            const on_start = function(text_elt) {
                 // Replace URL with URL text.
                 $("#item-url").hide();
                 $("#item-url-text").show();
@@ -279,14 +279,14 @@ export default {
                     );
                 });
             };
-            var on_finish = function(text_elt) {
+            const on_finish = function(text_elt) {
                 // Replace URL text with URL.
                 $("#item-url-text").hide();
                 $("#item-url").show();
 
                 // Set URL to new value.
-                var new_url = $("#item-url-text").text();
-                var item_url_obj = $("#item-url");
+                const new_url = $("#item-url-text").text();
+                const item_url_obj = $("#item-url");
                 item_url_obj.attr("href", new_url);
                 item_url_obj.text(new_url);
             };