From 025c6db2991351b2ff50d0a078d7dc6346e7aba3 Mon Sep 17 00:00:00 2001 From: M Bernt Date: Mon, 28 Sep 2020 16:15:56 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Marius van den Beek --- lib/galaxy/tools/parameters/dynamic_options.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/galaxy/tools/parameters/dynamic_options.py b/lib/galaxy/tools/parameters/dynamic_options.py index 40a9cd0b6fa..a08d554d083 100644 --- a/lib/galaxy/tools/parameters/dynamic_options.py +++ b/lib/galaxy/tools/parameters/dynamic_options.py @@ -165,8 +165,8 @@ class DataMetaFilter(Filter): def _add_meta(meta_value, m): if isinstance(m, list): meta_value |= set(m) - elif isinstance(m, dict) or isinstance(m, OrderedDict): - meta_value |= set(["%s,%s" % (k, v) for k, v in m.iteritems()]) + elif isinstance(m, dict): + meta_value |= set(["%s,%s" % (k, v) for k, v in m.items()]) elif isinstance(m, str) and os.path.isfile(m): with open(m) as fh: for line in fh: