Commit Graph
47 Commits
Author SHA1 Message Date
Oliver Eyton-WilliamsandShaun Hamilton d7848ae01a feat: migrate to pnpm for better workspace DX (#49293)
* feat: npm -> pnpm 

This resolves the issues with the gatsby client (gatsby-plugin-pnpm
deals with the fact that gatsby is relying on its own dependencies
being de-duped)
and challenge-editor (which doesn't seem to want to automatically install
codemirror and needed its own eslint config)

* fix: correct mocha path for curriculum tests

* fix: use select workspace with -F not -w

* fix: reorganise packages and restrict hoisting

pnpm works best if the workspaces keep their own dependencies, since
dependencies are not flattened and then what node resolves from a
require is predictable.

@types seem to be a special case and more care is required to prevent
them getting smushed together in the root (hence the .npmrc)

* fix: add types for tools + root

* fix: decouple challenge-auditor from client

* fix: add ui-components types

* fix(client): use the latest types for react 16

* fix: prettify

* fix: prettierignore pnpm-lock

* fix: relax hoisting

Turns out pnpm works just fine with types. I don't know what was going
wrong before, but there are no-longer any type conflicts.

* fix: add @redux-saga/core to fix eslint issue

It seems to only be redux-saga that import/named can't cope with, so it
is probably okay to work around this one.

* chore: add chai to tools/scripts/build

* fix: add store to root for cypress

* fix: allow cypress to download binaries

If we want to keep preventing cypress from downloading binaries, we can
figure out a workaround, but I'm allowing it to ease the transition to
pnpm.

My guess about why this is happening is that npm triggers Cypress's
postinstall script, but pnpm does not (because pnpm install only
installs if necessary, perferring to link)

* chore: re-enable pre/post scripts

* fix: update build scripts for client

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: update engines to use pnpm


* fix: enable choice of (super)block for tests

Only 'nix machines for now.

* chore: pin pnpm to version 7

* chore: remove last npms

Except web + curriculum-server. I'll update them when I start work on
them again.

* fix: lockfile check to catch any package-locks

* fix(action): install pnpm for upcoming tests

* chore: add nodemon to new api

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2023-03-02 18:17:44 +00:00
Bryan Moore f5debdffc1 fix(docs): update references to comments.js (#48558) 2022-12-02 09:26:24 +01:00
Chelsgray 7f01f29fda fix(docs): typo in how to work on coding challenges (#47575) 2022-09-21 17:27:02 +09:00
Naomi Carrigan 1a4044a3b9 docs: change rocket chat links to discord (#46514) 2022-06-16 08:23:15 +04:00
Tom 1c5d136add feat(client): add notes tab to project based curriculum (#44247)
* feat: add notes tab to project based curriculum

* feat: add console key to i18n

* feat: add reset to i18n

* fix: use translations in action-row

* fix: use hasEditableBoundaries as check for when to display instructions/editor-tabs

* fix: clean up notes components and use prism formatting

* feat: add notes to docs/how-to-work-on-challenges

* revert: unused code

* fix: lint errors?

* fix: lint errors

* fix: add notes to graphql schema

* fix: add notes to challenge schema

* fix: only display notes on project based

* fix: add env data back to mobile layout

* fix: prettify

* revert: notes

* fix: hide notes on mobile for non project based

* rename: switchDisplayTab -> togglePane

* revert: hasEditableBoundaries check back to projectBasedChallenge check
2021-12-09 18:42:03 +00:00
Oliver Eyton-Williams 0418c59445 docs: explain dynamic hints in more depth (#44290) 2021-11-26 14:06:22 +00:00
Oliver Eyton-Williams 260f945de8 feat: allow for dynamic hints (#44279) 2021-11-25 15:10:01 +00:00
Oliver Eyton-Williams c8d7f0a782 feat(tools): remove eslint-plugin-prettier for prettier (#42438)
* feat: remove eslint-plugin-prettier for prettier

This removes the annoying lint warnings when all that needs to change is
formatting

* fix: use .js lint-staged config to ignore properly

* fix: lint everything if a lot of files are changed

It's faster than making lots of individual linter calls

* chore: apply prettier

* fix: ignore code in curriculum-file-structure
2021-10-06 21:02:21 +05:30
Ilenia 1d0a6a5673 Changing documentation links for i18n ease (#43274)
* fixing links for i18n ease

* fixing links for i18n ease

* revert brain fart

* hopefully now the link works

* changing links for ease of translation
2021-08-26 10:59:44 +02:00
awu43 dd5d2919be feat(client): ts-migrate client/utils/** (#42823)
* rename js files

* update imports and references

* migrate build-challenges

* migrate challenge-types

* migrate utils/index

* migrate state-management

* install @types/psl for tags

* migrate tags

* migrate tags.test

* migrate challenge-page-creator

* migrate utils/gatsby/index

* migrate layout-selector

* migrate layout-selector.test

* revert challenge-types

Curriculum can't handle TS or modules

* convert arrow functions

* revert build-challenges

* revert utils/gatsby/index

* revert challenge-page-creator

* revert challenge-types reference

* Delete state-management

Deleted in #42960

* Disable render-result-naming-convention (for now)

* update layout-selector.test comment

* reorder imports in build-challenges

* change ts-ignore to ts-expect-error
2021-08-09 10:30:31 +02:00
Oliver Eyton-Williams b61d185209 docs: mention curriculum helper functions (#42889) 2021-07-16 09:01:05 +01:00
Shaun Hamilton b96ebf7663 fix(docs): update terminology for challenges (#42595) 2021-06-22 16:59:30 -07:00
87830f3a9c docs: add helpers to contribute docs (#42417)
* docs: add helpers to contribute docs

* chore: remove helper script readme

* Update docs/how-to-work-on-practice-projects.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update docs/how-to-work-on-practice-projects.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update docs/how-to-work-on-practice-projects.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-10 14:11:11 +05:30
ff181c3258 docs: tweaks for translations (#40806)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-07 22:17:40 +05:30
c1f9cd93f5 general educational fixes in some files (#40800)
Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-02-03 15:17:56 +05:30
Nicholas Carrigan (he/him) e5b43edf84 docs: master -> main (#40857)
Updates the docs to reflect the change from `master` to `main` as our
primary branch.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-02-01 19:55:24 +05:30
Shaun HamiltonandOliver Eyton-Williams 5bfc6de78b feat(docs): add newline formatting for notes tip (#40712)
* feat(docs): add newline formatting for notes tip

* clarify formatting

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-21 11:42:29 -06:00
26c9b3c16b feat(docs): Update Contributing Instructions for New Template (#40329)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-12-29 13:53:23 +05:30
Nicholas Carrigan (he/him) 2d0bba3097 docs: Replace Gitter/Discord links (#40514) 2020-12-22 12:00:00 +05:30
Oliver Eyton-Williams 0bd52f8bd1 Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
Randell Dawson 797722a099 fix: add seed code comment rules 2020-10-22 02:51:45 +05:30
Nicholas Carrigan (he/him) fa2d5c687c Fix broken Discord link (#40035)
* Fix broken Discord link

* Change links across translations
2020-10-20 00:11:08 +05:30
e21e6c1ce6 Streamline copy and remove gitter references (#40015)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: freeCodeCamp <freecodecamp@MacBook-Pro.local>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2020-10-19 18:27:37 +05:30
Shaun HamiltonandOliver Eyton-Williams 6de5144c8c fix(docs): add formatting instructions for coding challenge text (#39660)
* fix(docs): add formatting instructions

* add note about markdown

* fix: mention preference to use single-quotes

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-10-15 10:25:05 +02:00
Oliver Eyton-WilliamsandAhmad Abdolsaheb bd68b70f3d Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
Oliver Eyton-Williams 5e5842871c docs: add description of new template (#39473) 2020-08-26 17:55:51 +05:30
Oliver Eyton-Williams 7055211959 fix: simplify language specific testing
Prevents multiple languages' challenges from being tested at once.
2020-08-16 04:45:19 +05:30
Kartik Soneji 76879f9e7e docs: update link to challengeTypes.js (#39283) 2020-07-18 13:29:34 +05:30
Nicholas Carrigan 1e0e54446f chore: replace forum links (#39139) 2020-06-30 14:21:26 +05:30
Mrugesh Mohapatra be2893e323 docs: update information about language 2020-04-29 22:31:52 +05:30
Mrugesh Mohapatra fe4ca9143c docs: update instructions on testing (#38687) 2020-04-29 22:29:07 +05:30
Olubisi Idris Ayinde b009af1810 docs: added punctuation to listed points (#38666) 2020-04-29 16:46:35 +05:30
Mrugesh Mohapatra d6b8c811ea docs: add note on academic credits (#38604) 2020-04-22 16:25:59 +05:30
Mrugesh Mohapatra e7857af960 docs: update coding challenges guide and links (#38597) 2020-04-21 19:01:48 +05:30
Mrugesh Mohapatra 09cd14fd22 feat(docs): host docs with docsify 2020-04-06 20:50:40 +05:30
mrugesh 696bfe8b7b docs: update links in curriculum guide 2020-03-21 11:18:17 +05:30
f736e67537 docs: grammatical changes to how-to-work-on-coding-challenges (#37266)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-03-06 12:45:59 +05:30
Tristan Michael Lawrence 5296d5c731 fix: removed trailing spaces, fixed a typo (#37572)
* removed trailing spaces, fixed a typo

* removed trailing spaces from basic-css challenges
2019-11-10 04:33:10 -08:00
Randell DawsonandOliver Eyton-Williams 228e73532d [docs] Updated How to Work on Challenge Files to explain how t… (#37188)
* docs: added how to test individual challenges

* fix: shortened sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: made sentence more concise

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added file extension

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added testStrings in the requirements

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: improved the instructions wording

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-10-14 23:55:03 +07:00
mrugesh a2c5e2379e docs: update instructions for modifying hint topics (#36842) 2019-09-25 01:25:58 +05:30
mrugesh a5b176be88 docs: update contributing guides (#36816) 2019-09-20 23:56:56 +05:30
Randell Dawson 5aab82cc89 fix(docs) Corrected challenge template example (#35307) 2019-02-26 22:21:00 +03:00
Jarrel Thomas 2acfacf4b0 Closed Spacing of identifier (#29887) 2019-02-11 07:25:59 -08:00
Dorothy df633bbd9b Update how-to-work-on-coding-challenges.md (#22118)
Line 5 - Corrected typo "it's" (contraction) to "its" possessive
Line 11 - Corrected typo "you" to "your"
Line 23 - Corrected typo "explaination" to "explanation"
Line 48 - Corrected typo "desplayed" to "displayed"
2018-11-06 19:56:36 -05:00
llamousse 0046c7601e Fixed grammar and typo in "Changing on GitHub" (#20905) 2018-11-03 21:55:45 -04:00
Ana Carolina 2e5c2e1645 fix typo in one of the links (#18336)
In the us
2018-10-11 20:58:24 -06:00
Mrugesh Mohapatra 29af7da92b docs: update intial restructuring for guide articles 2018-10-10 16:33:25 +05:30