Commit Graph
1849 Commits
Author SHA1 Message Date
TomandAshraf Nazar e48664af2a fix(learn): font size multiple headings exercise (#39511)
* fix: use regex to capture font-size of h6 element, as minimum font-size of browsers may influence outcome

* fix: add suggested changes

Co-authored-by: Ashraf Nazar <ashraf.caspian@gmail.com>
2020-09-02 18:11:23 +01:00
TomandDaniel Sing 9cd4b93601 fix(learn): getter setter instructions (#39512)
* Update use-getters-and-setters-to-control-access-to-an-object.english.md

* fix: revert changes, keep example

Co-authored-by: Daniel Sing <danielsingsong@gmail.com>
2020-09-02 18:07:17 +01:00
9ed2a554a7 fix(curriculum): changed test to use regex (#38770)
* changed test to use regex

* added width has to be spelt correctly

* added second width assertion

* add case insensitive flag

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: allow compilable CSS to pass

* add allowance of final property without semicolon

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-02 11:59:16 -05:00
Ashlee CruscoandmoT01 3836ce08e3 fix(learn): add for and id attributes to label and input (#39019)
* add value and id attributes

* revert prettier format changes

* fix whitespace changes

* Revert "fix whitespace changes"

This reverts commit 9da78e58ce474b0f4a7cf076574e23961a6d3734.

* fix typo

* fix: conflict I forgot to resolve

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-02 15:19:47 +01:00
Joshua PelealuandRandell Dawson a050de56bb Fix: Running Test with a comment fails test on Understand The immediately invoked function expression iife (#39347)
* Update Regex to test if it's an IIFE instead of checking for a parenthases at the end.

* Second Test will now pass the test

* Escape One Parenthese

* Update Regex to be more structured

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Missing regex ending literal

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-01 18:48:32 -05:00
Mayank Chauhan e7718e5c3f fix(learn): improved tests for validating incrementer function (#39385)
* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* fix typo in avoid-mutations-and-side-effects-using-functional-programming.english.md
2020-09-01 08:44:24 -07:00
Ashraf NazarandShaun Hamilton 70f1ebd2fc fix(curriculum): regex to target html elements using jQuery to captur… (#38649)
* fix(curriculum): regex to target html elements using jQuery to capture white spaces

* replace whitespace before test

* fix linting issue with single quotes

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-08-31 20:24:43 -05:00
a294021d53 fix: remove whitespace before testing (#39420)
* Proposed change to remove whitespace for issue #39370

Issue #39370: whitespace fails the 3rd test with test comparing to a no whitespace example.
Proposed: remove all whitespace in between tags(or literally all whitespaces) before comparing it with the no whitespace example

* Update render-state-in-the-user-interface.english.md

* Updated proposed change to remove whitespace 

An update to previously proposed change due to failed test of 'unexpected token \'<\'' was thrown'

* Update curriculum/challenges/english/03-front-end-libraries/react/render-state-in-the-user-interface.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: linting issue

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-01 01:15:22 +01:00
b0f85de311 fix (curriculum): Adding regex to disregard any whitespaces in the basic-css challenge (#38330)
* fix (curriculum): Adding regex to account for any whitespace that may be added to the code

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/use-attribute-selectors-to-style-elements.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-08-31 15:16:24 -07:00
Pyi Theim Kyaw faf426bb40 PR ready fix(learn) (#39208) 2020-08-31 15:31:30 -05:00
Beau CarnesandmoT01 f334734e98 feat: split JS challenge into two (#39044)
* feat: split JS challenge into two

* fix/change-to-not-use-untaught-assignments

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-08-31 19:44:56 +01:00
8e3f740127 fix: update take home project links (#39444)
* fix: update take home project links and update mentions of Glitch with Repl.it

* fix: clean up text, fix typos, and remove deploy to Heroku text

* fix: update nightlife coordination app description text

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: update GH link text based on suggestion

* fix: update links to the fCC forum

* fix: update nightlife coordination app url

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: change http to https

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-08-31 10:32:22 -07:00
Yasmin Yazdi cf82a2b33e fix global flag fail in Regex by resetting last Index (#39457)
* fixing global flag fail by resetting last index. Issue #37890

* fixed syntax error

* making requested changes
2020-08-31 16:59:42 +05:30
71051fef50 fix(Curriculum): make sure the nested input element in the form is th… (#38480)
* fix(Curriculum): make sure the nested input element in the form is the existing element given in the editor

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: use backticks to avoid linting error

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-08-30 22:50:46 -07:00
Ty MickandTom 474ae28d72 Fix number of noun (#38833)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-08-30 22:15:58 -07:00
Quinn 29ab6c32ec minor <code> tag fixes (#39046) 2020-08-30 23:12:04 -05:00
Shaun Hamilton fe3f0b2ac4 fix: remove quotation marks from code tag text (#38316) 2020-08-30 22:53:09 -05:00
Carlos Diaz e0a062a3e7 Changes order of padding, border, margin in introductory sentence. (#39414) 2020-08-30 22:28:42 -05:00
tomki1 9c3de2df24 added test to assert h1 is before h2 (#39040) 2020-08-30 22:13:30 -05:00
law27andLawranceMichaelite b88c8ab351 Update use-the-s-tag-to-strikethrough-text.english.md (#38515)
Alphabet word is not wrapped inside double quotes

Co-authored-by: LawranceMichaelite <40236169+LawranceMichaelite@users.noreply.github.com>
2020-08-30 22:08:51 -05:00
Charles Ross 3db5bd7067 Update import-a-google-font.english.md (#38839)
Changed optional plural to possessive.
2020-08-30 22:07:46 -05:00
IeahleenandParth Parth ed6246b91a update description of "Nest an anchor element in a paragraph" as discussed in #38507 (#38524)
* remove parenthesis from description

As discussed in #38507 , I'm removing the phrase in parenthesis

* more succint description

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-08-30 22:01:40 -05:00
Kristofer Koishigawa b73156373f fix: tests for use a retina image challenge (#39133) 2020-08-29 22:09:43 -05:00
Karuppiah NatarajanandParth Parth efa4e09efa fix typo in 'integer' word (#39339)
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-08-26 07:38:43 -07:00
Samuel S. Hernandez e71cf1da10 fixed spelling errors on .spanish.md (#39030)
fixed spelling errors to improve instruction readability
2020-08-25 19:55:38 -07:00
Samuel S. Hernandez 8ae1902c79 Spelling error on 'motores de busqueda' (#39029)
I fixed a spelling error.
2020-08-25 19:53:37 -07:00
Shaun HamiltonandRandell Dawson 83c6de0144 fix: add backslash to path test for windows paths (#39454)
* fix: add backslash to path test for windows paths

* fix: add posix seperator to path tester

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-08-25 13:22:03 -07:00
fb77d48d13 curriculum: add test in React challenge to detect constructor call (#39304)
* fix: resolve #39301

Add a test to check the "MyComponent" constructor's parameters (params) and to check that the super function exists in the constructor.

* docs: describe the test better

* Update curriculum/challenges/english/03-front-end-libraries/react/write-a-react-component-from-scratch.english.md

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-08-25 08:41:35 -07:00
Joseph Mawa fccc436e23 Fixed test description for Rosetta Code: Euler method challenge. (#39452)
* Update greatest-subsequential-sum.english.md

Added missing closing bracket in test description in the tests section.
Removed variable declared twice in the solution section.

* Update euler-method.english.md

* Update euler-method.english.md

* Update euler-method.english.md

Added parameter description  fixing the suggested changes.

* Update euler-method.english.md

Removed some formatting from the added text.

* Update euler-method.english.md

Moved seed function parameter description to instructions section.
2020-08-25 08:37:10 -07:00
Shaun Hamilton cdc1a63ca8 fix(learn): correct personal library replit link (#39442) 2020-08-20 13:08:02 -07:00
Joseph Mawa fc1200ae2c Update greatest-subsequential-sum.english.md (#39422)
Added missing closing bracket in test description in the tests section.
Removed variable declared twice in the solution section.
2020-08-19 08:04:47 -07:00
Ryan-Chu bd02c989df fix(curriculum): rename variable to avoid conflict (#39428) 2020-08-19 16:47:30 +02:00
6b3c61c737 feat: update backend project links (#39314)
* feat: update backend project links

Replace solution and remix Glitch links with equivalent Repl.it links in backend projects/challenges and intro pages.

* fix: link and Repl.it casing

* fix: update mention of glitch in testing challenge

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-08-17 14:38:16 -07:00
ML 9a4976bd57 fix(curriculum) typo in Create Reusable CSS (#39418)
Fixed a typo on the Sass Challenge "Create Reusable CSS with Mixins" where the word "vendor" was spelled incorrectly as "vender" in the test cases.
2020-08-16 18:33:34 -07:00
Nicholas Carrigan 4858c2eb0a Remove extra / from link (#39419) 2020-08-16 18:25:55 -07:00
Oliver Eyton-Williams 109f2d8eab fix: outstanding md linting issues 2020-08-16 04:45:20 +05:30
Oliver Eyton-Williams 61460c8601 fix: insert blank line after ```
search and replace ```\n< with ```\n\n< to ensure there's an empty line
before closing tags
2020-08-16 04:45:20 +05:30
Oliver Eyton-Williams 2a82c068d3 fix: relax schema while auditing translations
Without this change we would have to put in dummy localeTitle values.
This defeats the point of making it required.
2020-08-16 04:45:19 +05:30
Oliver Eyton-Williams 7055211959 fix: simplify language specific testing
Prevents multiple languages' challenges from being tested at once.
2020-08-16 04:45:19 +05:30
Oliver Eyton-Williams b197f73881 feat: restrict translation to audited certs 2020-08-16 04:45:19 +05:30
Oliver Eyton-Williams 1ec6cf1efd fix: handle video challenges 2020-08-16 04:45:19 +05:30
Oliver Eyton-Williams a66455b983 fix: test text mismatched quotes 2020-08-16 04:45:19 +05:30
Oliver Eyton-Williams 3c9ccb524c fix: add missing chinese extensions 2020-08-16 04:45:19 +05:30
Oliver Eyton-Williams 1cfa09adc4 fix: QA/Infosec update and python to chinese 2020-08-16 04:45:18 +05:30
Randell Dawson 5bc0187404 fix: added Chinese comment translations for Responsive Web Design 2020-08-16 04:45:17 +05:30
Oliver Eyton-Williams 0952ca6bfd feat: parse translated challenges
Using the English challenge as a source for the seed, solution and tests
this takes the parts that can be translated from the translated version
of the challenge. It also translates known comments in the seed.
2020-08-16 04:45:17 +05:30
Oliver Eyton-Williams fa931134a4 test: add tests for translated challenge parser 2020-08-16 04:45:17 +05:30
Oliver Eyton-Williams f9ffcf0c61 fix: update chinese certificates 2020-08-16 04:45:17 +05:30
Oliver Eyton-Williams be3171169c fix: remove cn challenges already removed from eng 2020-08-16 04:45:17 +05:30
Oliver Eyton-Williams c40eab94b7 fix(curriculum): add missing .english extensions 2020-08-16 04:45:17 +05:30