Commit Graph
15975 Commits
Author SHA1 Message Date
Nicholas Nadeau, P.Eng., AVS a8efeb50d7 chore: fixed typos via client9/misspell (#17081) 2018-04-25 10:37:27 +05:30
Nicholas Nadeau, P.Eng., AVS e5d52afad8 chore: fixed typos via client9/misspell (#17081) 2018-04-25 10:37:27 +05:30
Abhishek Kulshrestha 9a380f135a chore(server): Deleted outdated explanation file of how-nonprofit (#17067)
changes for issue 17067

Closes #17067
2018-04-23 10:47:11 +05:30
Lovepreet Singh 2f95c9f363 feat(challenges): Highlight current challenge (#16982)
highlight the currently selected challenge

Closes #16902

feat(challenges): Use of params dashed to get current challenge

Closes #16902
2018-04-18 16:23:37 +01:00
Lovepreet Singh 38e9cff9fa fix(editor): Clear codemirror undo on new challenge (#17002)
clear codemirror undo stack on new challenge

Closes #16960

fix(editor): Removed not required code

Closes #16960

feat(editor): Updated code with coding style

Closes #16960
2018-04-18 16:19:31 +01:00
Ahmad Abdolsaheb 49a5fdafc2 fix(seed): Fixes tests (#17051)
tests assert changed

Closes #17019
2018-04-17 15:53:55 -04:00
Ahmad Abdolsaheb b5864279fa fix(seed): Fixes tests (#17051)
tests assert changed

Closes #17019
2018-04-17 15:53:55 -04:00
Shivam Chawla 05f034bfe6 fixed Typo in Basic CSS #17057 (#17061)
Fixed Typo in Basic CSS: Cascading CSS variables description #17057
2018-04-17 15:09:18 -04:00
Shivam Chawla f18c791f3e fixed Typo in Basic CSS #17057 (#17061)
Fixed Typo in Basic CSS: Cascading CSS variables description #17057
2018-04-17 15:09:18 -04:00
Chaitanya 9610c2729f Fix to tests messages (#17059)
In https://beta.freecodecamp.org/en/challenges/react/write-a-simple-counter challenge code is referring to Component Counter but messages are referring to myComponent
2018-04-17 15:02:57 -04:00
Chaitanya ebcfb83486 Fix to tests messages (#17059)
In https://beta.freecodecamp.org/en/challenges/react/write-a-simple-counter challenge code is referring to Component Counter but messages are referring to myComponent
2018-04-17 15:02:57 -04:00
Kirushna Kumar 71ce7cf6b9 fix(challenge): map.add() test case in create map DS challenge (#16995) 2018-04-17 14:27:51 -04:00
Kirushna Kumar 77bde7247f fix(challenge): map.add() test case in create map DS challenge (#16995) 2018-04-17 14:27:51 -04:00
Varun 857c9955d5 fix: SASS challenge and code indentation (#17036) 2018-04-17 14:08:35 -04:00
Varun 00e6d92480 fix: SASS challenge and code indentation (#17036) 2018-04-17 14:08:35 -04:00
Quincy Larson cc0e75e526 Merge branch 'guiKailu-branch/fix/weather-user-story-details' into staging 2018-04-16 23:02:45 -05:00
Quincy Larson c220887e14 fix broken JSON 2018-04-16 23:02:11 -05:00
Quincy Larson f1e552c32d fix broken JSON 2018-04-16 23:02:11 -05:00
guiKailu 42a5832a42 This update clarifies in take-home-interview-projects.json the different possible weather outcomes right in the weather challenge instructions. QuincyLarson approved User Story update, despite its length. 2018-04-16 08:53:44 -07:00
guiKailu baa3012d67 This update clarifies in take-home-interview-projects.json the different possible weather outcomes right in the weather challenge instructions. QuincyLarson approved User Story update, despite its length. 2018-04-16 08:53:44 -07:00
mrugesh mohapatra a2076ce1ec fix(auth): on-boarding, signup and welcome flows (#16882)
* fix(auth): Route should have specific targets

* fix(signup): Redirection should be to signup

Closes #16945

* feat(redirect): All fallback redirects to signin

* fix: send back to originating route

* fix(server,secrets): Specify profile field for LinkedIn provider.

* fix(profile): Add route to react profile page
2018-04-13 15:48:10 +01:00
Kristofer Koishigawa 5e53ebded9 fix(seed): Simplify Unique Titles Test (#17056)
Originally the test would check for the index of a title in an array of
unique challenge titles. However, the index of the title within the
array isn't important for this test, so I simplified the code using
@Bouncey's suggestion in PR #17035.

Also changed grammar for the error that's thrown when a challenge
title isn't a valid string.

BREAKING CHANGE: None
2018-04-13 15:15:40 +01:00
Kristofer Koishigawa d6f217c1b9 fix(seed): Simplify Unique Titles Test (#17056)
Originally the test would check for the index of a title in an array of
unique challenge titles. However, the index of the title within the
array isn't important for this test, so I simplified the code using
@Bouncey's suggestion in PR #17035.

Also changed grammar for the error that's thrown when a challenge
title isn't a valid string.

BREAKING CHANGE: None
2018-04-13 15:15:40 +01:00
Hakeem Davis 9f5eb3b14c fix(seed): Clarify instructions (#17050)
Closes #17044
2018-04-13 09:49:01 +05:30
Hakeem Davis bcd31aa499 fix(seed): Clarify instructions (#17050)
Closes #17044
2018-04-13 09:49:01 +05:30
Kristofer Koishigawa 5fa098ea0d test(seed): Add Test for Unique Challenge Titles (#17035)
Due to the recent problem with two challenges having the same title, I
added a check for unique titles to the test suite so that hopefully
won't happen again.

Addresses a comment in issue #16906, which was recently closed.

BREAKING CHANGE: None

Closes #16906
2018-04-10 21:23:36 +01:00
Kristofer Koishigawa be693638de test(seed): Add Test for Unique Challenge Titles (#17035)
Due to the recent problem with two challenges having the same title, I
added a check for unique titles to the test suite so that hopefully
won't happen again.

Addresses a comment in issue #16906, which was recently closed.

BREAKING CHANGE: None

Closes #16906
2018-04-10 21:23:36 +01:00
Kristofer Koishigawa e6e6df3c6d feat(app): Add Motivational Quote Easter Egg (#16932)
Added a feature where a motivational quote is randomly selected from a
static list and displayed whenever the user closes all the panes on the
page. Also added a quotes.js file with an array of quote objects and a
function that returns a random quote object when called.

Edit: Forgot to add double quotes to the quote blocks after moving from
test strings to random quote objects from the quotes.js file. Added
them here as HTML encoded left and right double quotes.

Made changes @Bouncey requested.

Made further changes @Bouncey requested. Also added a componentDidUpdate
method to both ensure the quote is only changed when panes open and close,
and also to make sure the new quote is not the same as the one that
was last displayed.

Removed the fCC logo as it was redundant and clashed with the night mode.
Simplified the layout so the quote block is in the middle of the page and
changed the width so that it's more readable. Also added styling to change
the quote text color in night mode.

BREAKING CHANGE: None

Closes #16382
2018-04-10 16:13:46 +01:00
Edit Bazso b208c477fc fix(seed): Fixed broken link in React Introducing Inline Styl (#17040)
* fix(seed): Fixed broken link in React Introducing Inline Styl

* fix(seed): Fixed broken link in React Introducing Inline Style
2018-04-07 22:06:11 -04:00
Edit Bazso 1dc5501b8f fix(seed): Fixed broken link in React Introducing Inline Styl (#17040)
* fix(seed): Fixed broken link in React Introducing Inline Styl

* fix(seed): Fixed broken link in React Introducing Inline Style
2018-04-07 22:06:11 -04:00
Varun ad2d782c4d fix: typo in challenges/react.json (#17037) 2018-04-07 21:43:22 -04:00
Varun e747dbf9c4 fix: typo in challenges/react.json (#17037) 2018-04-07 21:43:22 -04:00
Ákos 8a7198d335 fix(seed): Sass Challenge:Use @each to Map Over Items in a Li (#17032)
Closes #16896
Closes #16894
2018-04-07 11:45:50 -04:00
Ákos 754bdccb6b fix(seed): Sass Challenge:Use @each to Map Over Items in a Li (#17032)
Closes #16896
Closes #16894
2018-04-07 11:45:50 -04:00
Bryan Williams c6296280a0 Clarified instructions for Pairwise algorithm (#17013)
* Clarified instructions for Pairwise algorithm

Added an example to further clarify the directions in the "Pairwise" algorithm, per issue #16800 https://github.com/freeCodeCamp/freeCodeCamp/issues/16800

* Change "for example" to "for instance"
2018-04-06 22:12:14 -04:00
Bryan Williams f1d219f1bc Clarified instructions for Pairwise algorithm (#17013)
* Clarified instructions for Pairwise algorithm

Added an example to further clarify the directions in the "Pairwise" algorithm, per issue #16800 https://github.com/freeCodeCamp/freeCodeCamp/issues/16800

* Change "for example" to "for instance"
2018-04-06 22:12:14 -04:00
Varun 863042312e fix(pm2): update scripts and add dev deps (#17030) 2018-04-06 13:27:15 +05:30
Varun 2d01080eb6 fix: MailHog installation guide (#17025) 2018-04-06 13:26:10 +05:30
John B 0f5e594848 fix(challenges): Fix typo issue on CSS Grid:Minmax (#17027)
the example explains that grid-template-columns: 100px minmax(50px,
200px) is set to create three columns when in fact it is only set to
create two columns.
2018-04-06 13:24:57 +05:30
John B 5118a60491 fix(challenges): Fix typo issue on CSS Grid:Minmax (#17027)
the example explains that grid-template-columns: 100px minmax(50px,
200px) is set to create three columns when in fact it is only set to
create two columns.
2018-04-06 13:24:57 +05:30
Steven D Anderson ee103923ad fix(contribute): Creating a new user (#16974)
* fix(contribute): Creating a new user
* fix: moving create user guide below shared header
2018-04-05 16:16:14 +12:00
rcohane d612f48d5e fix(challenges): Change offset values (#17006)
Made offset values 50px so change is visible

BREAKING CHANGE: N/A

Closes #14681
2018-04-04 21:24:39 -04:00
rcohane 1c4598b3fc fix(challenges): Change offset values (#17006)
Made offset values 50px so change is visible

BREAKING CHANGE: N/A

Closes #14681
2018-04-04 21:24:39 -04:00
Akkshay Lawrence f9a63ee581 fix(challenges): Fixed typo in the challenge (#16991)
changed vowels to letters.

BREAKING CHANGE: none.

Closes #16979
2018-04-03 15:25:41 -04:00
Akkshay Lawrence 89a4b10c30 fix(challenges): Fixed typo in the challenge (#16991)
changed vowels to letters.

BREAKING CHANGE: none.

Closes #16979
2018-04-03 15:25:41 -04:00
Michael Siadak ff35f2c9c3 fix(challenges): Remove self-closing slashes from <img> and <input> (#16985) 2018-04-03 14:48:41 -04:00
Michael Siadak e3f1330aa5 fix(challenges): Remove self-closing slashes from <img> and <input> (#16985) 2018-04-03 14:48:41 -04:00
Lovepreet Singh fc87d71af3 fix(seed): Added missing text 'new tab' (#16978)
'new tab' was missing from description

Closes #16970
2018-04-03 11:42:04 -04:00
Lovepreet Singh 4300f82faf fix(seed): Added missing text 'new tab' (#16978)
'new tab' was missing from description

Closes #16970
2018-04-03 11:42:04 -04:00
Alex Chaffee 4a77ba7af3 feat(seed): add dasherized titles to unpacked filenames 2018-04-03 19:53:44 +05:30