From cfe2025d18d76765c6840e69277d43a4c9bf9e24 Mon Sep 17 00:00:00 2001 From: Clarence Date: Wed, 23 Apr 2025 07:38:42 +0100 Subject: [PATCH] fix(curriculum): update specific assert methods in reusable mega navbar workshop (#59880) --- .../67457ff2dc531fbed928a0f0.md | 2 +- .../6745c732dbeb7c04f346e6f7.md | 2 +- .../6745c7b06a0b530602cb63fa.md | 6 +++--- .../6745c89fba004707ded84453.md | 2 +- .../6745cebbf97ef2129f3b9bab.md | 2 +- .../6745d799beeb822076a4da9d.md | 2 +- .../6745d9df333efe2543a1f457.md | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/67457ff2dc531fbed928a0f0.md b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/67457ff2dc531fbed928a0f0.md index f4d9f2b2203..dcac02a6d29 100644 --- a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/67457ff2dc531fbed928a0f0.md +++ b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/67457ff2dc531fbed928a0f0.md @@ -34,7 +34,7 @@ The reason why `className` is used here instead of `class` is because `class` is You should return a `nav` element. ```js -assert(document.querySelector('nav')); +assert.exists(document.querySelector('nav')); ``` Your `nav` element should have a `className` attribute with the value `navbar`. diff --git a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c732dbeb7c04f346e6f7.md b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c732dbeb7c04f346e6f7.md index 65afb99531f..43f7c89cf8e 100644 --- a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c732dbeb7c04f346e6f7.md +++ b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c732dbeb7c04f346e6f7.md @@ -14,7 +14,7 @@ Create a `ul` element inside the `nav` element. Inside that `ul` element, create You should create a `ul` element inside your `nav` element. ```js -assert(document.querySelector('nav ul')); +assert.exists(document.querySelector('nav ul')); ``` You should create three `li` elements inside your `ul` element. diff --git a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c7b06a0b530602cb63fa.md b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c7b06a0b530602cb63fa.md index afba1620295..ac22e2260ea 100644 --- a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c7b06a0b530602cb63fa.md +++ b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c7b06a0b530602cb63fa.md @@ -14,9 +14,9 @@ Give all three `li` elements the `className` `nav-item`. Your three `li` elements should have the `className` `nav-item`. ```js -assert(document.querySelectorAll('ul li')[0]?.classList.contains('nav-item')); -assert(document.querySelectorAll('ul li')[1]?.classList.contains('nav-item')); -assert(document.querySelectorAll('ul li')[2]?.classList.contains('nav-item')); +assert.isTrue(document.querySelectorAll('ul li')[0]?.classList.contains('nav-item')); +assert.isTrue(document.querySelectorAll('ul li')[1]?.classList.contains('nav-item')); +assert.isTrue(document.querySelectorAll('ul li')[2]?.classList.contains('nav-item')); ``` # --seed-- diff --git a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c89fba004707ded84453.md b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c89fba004707ded84453.md index e02f3b77a2d..4e34e193840 100644 --- a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c89fba004707ded84453.md +++ b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745c89fba004707ded84453.md @@ -14,7 +14,7 @@ Create an anchor element inside the first `li` element. Give the `a` element an You should create an `a` element inside the first list item. ```js -assert(document.querySelector('li a')); +assert.exists(document.querySelector('li a')); ``` Your `a` element should have its `href` attribute set to `#`. diff --git a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745cebbf97ef2129f3b9bab.md b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745cebbf97ef2129f3b9bab.md index a37bd5f67b8..72e2f449e99 100644 --- a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745cebbf97ef2129f3b9bab.md +++ b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745cebbf97ef2129f3b9bab.md @@ -14,7 +14,7 @@ Create another `a` element inside the second `li` element. Give it an `href` att You should create an `a` element inside the second list item. ```js -assert.equal(document.querySelectorAll('li a').length, 2); +assert.lengthOf(document.querySelectorAll('li a'), 2); ``` Your `a` element should have its `href` attribute set to `#`. diff --git a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745d799beeb822076a4da9d.md b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745d799beeb822076a4da9d.md index 46a4b2381ac..dfc8a71d834 100644 --- a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745d799beeb822076a4da9d.md +++ b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745d799beeb822076a4da9d.md @@ -16,7 +16,7 @@ The `aria-expanded` attribute will communicate to screen reader users that the b You should create a `button` tag inside the second list item. ```js -assert(document.querySelector('li button')); +assert.exists(document.querySelector('li button')); ``` Your button should have an `aria-expanded` attribute set to `false`. diff --git a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745d9df333efe2543a1f457.md b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745d9df333efe2543a1f457.md index c7a1a8eb448..b30eb362c0f 100644 --- a/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745d9df333efe2543a1f457.md +++ b/curriculum/challenges/english/25-front-end-development/workshop-reusable-mega-navbar/6745d9df333efe2543a1f457.md @@ -14,7 +14,7 @@ Still inside the third `li` element, create a `ul` element for the popup. Give i You should create a `ul` element inside your third `li` element. ```js -assert(document.querySelector('li ul')); +assert.exists(document.querySelector('li ul')); ``` You should set the `className` attribute of your `ul` element to `sub-menu`.