From 7c2053f139d5b71e2d7ab62d13b1a0e0f27987ee Mon Sep 17 00:00:00 2001 From: Berkeley Martinez Date: Sat, 4 Jun 2016 21:37:11 -0700 Subject: [PATCH] Move event method calls out of action creator --- common/app/components/Nav/Nav.jsx | 14 ++++++++++++-- common/app/redux/actions.js | 14 ++------------ 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/common/app/components/Nav/Nav.jsx b/common/app/components/Nav/Nav.jsx index 514090b9425..1989a7a1f3d 100644 --- a/common/app/components/Nav/Nav.jsx +++ b/common/app/components/Nav/Nav.jsx @@ -67,7 +67,12 @@ export default class extends React.Component { eventKey={ 1 } to='/map'> { + if (!(e.ctrlKey || e.metaKey)) { + e.preventDefault(); + toggleMapDrawer(); + } + }} target='/map' > Map @@ -81,7 +86,12 @@ export default class extends React.Component { { + if (!(e.ctrlKey || e.metaKey)) { + e.preventDefault(); + toggleMainChat(); + } + }} target='_blank' > Chat diff --git a/common/app/redux/actions.js b/common/app/redux/actions.js index f1cd0a43b13..abd323f8ebc 100644 --- a/common/app/redux/actions.js +++ b/common/app/redux/actions.js @@ -49,18 +49,8 @@ export const createErrorObservable = error => Observable.just({ // drawers -export const toggleMapDrawer = createAction( - types.toggleMapDrawer, - e => e.preventDefault() -); +export const toggleMapDrawer = createAction(types.toggleMapDrawer); export const toggleWikiDrawer = createAction(types.toggleWikiDrawer); // chat -export const toggleMainChat = createAction( - types.toggleMainChat, - e => { - if (!(e.ctrlKey || e.metaKey)) { - e.preventDefault(); - } - } -); +export const toggleMainChat = createAction(types.toggleMainChat);