From f3778982ea503fbff3c54076d34fcfa3405a6822 Mon Sep 17 00:00:00 2001 From: Mark Chaney Date: Wed, 15 Oct 2025 03:20:18 -0400 Subject: [PATCH] Fix menu item sorting by using sortBy() instead of sort() (#18220) Changed Collection::sort() to Collection::sortBy() in getUserMenuItems() and getTenantMenuItems() methods. The sort() method expects a comparison callback but was being called with a single-parameter callback that returns a value, resulting in unpredictable sorting order. sortBy() correctly sorts by the returned value. This ensures menu items are consistently ordered by their sort value. --- packages/panels/src/Panel/Concerns/HasTenancy.php | 2 +- packages/panels/src/Panel/Concerns/HasUserMenu.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/panels/src/Panel/Concerns/HasTenancy.php b/packages/panels/src/Panel/Concerns/HasTenancy.php index 3f4707c506..e12eaa2b23 100644 --- a/packages/panels/src/Panel/Concerns/HasTenancy.php +++ b/packages/panels/src/Panel/Concerns/HasTenancy.php @@ -383,7 +383,7 @@ trait HasTenancy fn (Collection $items): Collection => $items->put('register', $this->getTenantRegistrationMenuItem()), ) ->filter(fn (Action $item): bool => $item->isVisible()) - ->sort(fn (Action $item): int => $item->getSort()) + ->sortBy(fn (Action $item): int => $item->getSort()) ->all(); } diff --git a/packages/panels/src/Panel/Concerns/HasUserMenu.php b/packages/panels/src/Panel/Concerns/HasUserMenu.php index cb6c6618bf..70709514c4 100644 --- a/packages/panels/src/Panel/Concerns/HasUserMenu.php +++ b/packages/panels/src/Panel/Concerns/HasUserMenu.php @@ -127,7 +127,7 @@ trait HasUserMenu fn (Collection $items): Collection => $items->put('logout', $this->getUserLogoutMenuItem()), ) ->filter(fn (Action $item): bool => $item->isVisible()) - ->sort(fn (Action $item): int => $item->getSort()) + ->sortBy(fn (Action $item): int => $item->getSort()) ->all(); } }