diff --git a/packages/tables/resources/views/components/groups.blade.php b/packages/tables/resources/views/components/groups.blade.php index d6e287893b..4320780aaa 100644 --- a/packages/tables/resources/views/components/groups.blade.php +++ b/packages/tables/resources/views/components/groups.blade.php @@ -2,7 +2,7 @@ 'dropdownOnDesktop' => false, 'groups', 'triggerAction', - 'groupingDirectionVisible' => true, + 'groupingDirectionHidden' => false, ]) @php @@ -72,23 +72,24 @@ - + @endif @@ -117,25 +118,24 @@ - + @endif @endif diff --git a/packages/tables/resources/views/index.blade.php b/packages/tables/resources/views/index.blade.php index 4580f0db70..3ed0bb33a0 100644 --- a/packages/tables/resources/views/index.blade.php +++ b/packages/tables/resources/views/index.blade.php @@ -42,7 +42,7 @@ $isReorderable = $isReorderable(); $isReordering = $isReordering(); $areGroupingSettingsVisible = (! $isReordering) && count($groups) && (! $areGroupingSettingsHidden()); - $isGroupingDirectionVisible = (! $isGroupingDirectionHidden()); + $isGroupingDirectionHidden = (! $isGroupingDirectionHidden()); $isColumnSearchVisible = $isSearchableByColumn(); $isGlobalSearchVisible = $isSearchable(); $isSearchOnBlur = $isSearchOnBlur(); @@ -199,7 +199,7 @@ :dropdown-on-desktop="$areGroupingSettingsInDropdownOnDesktop()" :groups="$groups" :trigger-action="$getGroupRecordsTriggerAction()" - :grouping-direction-visible="$isGroupingDirectionVisible" + :grouping-direction-hidden="$isGroupingDirectionHidden" /> @endif diff --git a/packages/tables/src/Table/Concerns/CanGroupRecords.php b/packages/tables/src/Table/Concerns/CanGroupRecords.php index 0719e655cc..87eff19b35 100644 --- a/packages/tables/src/Table/Concerns/CanGroupRecords.php +++ b/packages/tables/src/Table/Concerns/CanGroupRecords.php @@ -58,7 +58,7 @@ trait CanGroupRecords return $this; } - public function groupingSortDirectionHidden(bool | Closure $condition = true): static + public function groupingDirectionHidden(bool | Closure $condition = true): static { $this->isGroupingDirectionHidden = $condition; diff --git a/tests/src/Tables/Concerns/CanGroupRecordsTest.php b/tests/src/Tables/Concerns/CanGroupRecordsTest.php new file mode 100644 index 0000000000..daf2e83ff1 --- /dev/null +++ b/tests/src/Tables/Concerns/CanGroupRecordsTest.php @@ -0,0 +1,14 @@ +assertHasNoErrors() + ->assertDontSee('') + ->assertDontSee(__('filament-tables::table.grouping.fields.direction.options.asc')) + ->assertDontSee(__('filament-tables::table.grouping.fields.direction.options.desc')); +});