From 25e52c4db63a1d906059021b0d652000e166192b Mon Sep 17 00:00:00 2001 From: Remi Ebeling Date: Tue, 18 Mar 2025 14:43:51 +0100 Subject: [PATCH 1/7] add missing focus state highlighting in toggle component --- packages/forms/resources/views/components/toggle.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/forms/resources/views/components/toggle.blade.php b/packages/forms/resources/views/components/toggle.blade.php index 7cbaafea6a..62a08de36a 100644 --- a/packages/forms/resources/views/components/toggle.blade.php +++ b/packages/forms/resources/views/components/toggle.blade.php @@ -68,7 +68,7 @@ ], escape: false) ->merge($getExtraAttributes(), escape: false) ->merge($getExtraAlpineAttributes(), escape: false) - ->class(['fi-fo-toggle relative inline-flex h-6 w-11 shrink-0 cursor-pointer rounded-full border-2 border-transparent outline-none transition-colors duration-200 ease-in-out disabled:pointer-events-none disabled:opacity-70']) + ->class(['fi-fo-toggle relative inline-flex h-6 w-11 shrink-0 cursor-pointer rounded-full border-2 border-transparent outline-none transition-colors duration-200 ease-in-out disabled:pointer-events-none disabled:opacity-70 focus-visible:outline-primary-600']) }} > Date: Thu, 20 Mar 2025 14:04:08 +0100 Subject: [PATCH 2/7] switch focus-highlighting from outline to ring in toggle --- packages/forms/resources/views/components/toggle.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/forms/resources/views/components/toggle.blade.php b/packages/forms/resources/views/components/toggle.blade.php index 62a08de36a..ce9580dd69 100644 --- a/packages/forms/resources/views/components/toggle.blade.php +++ b/packages/forms/resources/views/components/toggle.blade.php @@ -68,7 +68,7 @@ ], escape: false) ->merge($getExtraAttributes(), escape: false) ->merge($getExtraAlpineAttributes(), escape: false) - ->class(['fi-fo-toggle relative inline-flex h-6 w-11 shrink-0 cursor-pointer rounded-full border-2 border-transparent outline-none transition-colors duration-200 ease-in-out disabled:pointer-events-none disabled:opacity-70 focus-visible:outline-primary-600']) + ->class(['fi-fo-toggle relative inline-flex h-6 w-11 shrink-0 cursor-pointer rounded-full border-2 border-transparent outline-none transition-colors duration-200 ease-in-out disabled:pointer-events-none disabled:opacity-70 focus-visible:ring-primary-500 focus-visible:ring-2']) }} > Date: Thu, 20 Mar 2025 15:07:05 +0100 Subject: [PATCH 3/7] add ring offset to improve focus indication for active toggles --- packages/forms/resources/views/components/toggle.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/forms/resources/views/components/toggle.blade.php b/packages/forms/resources/views/components/toggle.blade.php index ce9580dd69..3f675c7d4a 100644 --- a/packages/forms/resources/views/components/toggle.blade.php +++ b/packages/forms/resources/views/components/toggle.blade.php @@ -68,7 +68,7 @@ ], escape: false) ->merge($getExtraAttributes(), escape: false) ->merge($getExtraAlpineAttributes(), escape: false) - ->class(['fi-fo-toggle relative inline-flex h-6 w-11 shrink-0 cursor-pointer rounded-full border-2 border-transparent outline-none transition-colors duration-200 ease-in-out disabled:pointer-events-none disabled:opacity-70 focus-visible:ring-primary-500 focus-visible:ring-2']) + ->class(['fi-fo-toggle relative inline-flex h-6 w-11 shrink-0 cursor-pointer rounded-full border-2 border-transparent outline-none transition-colors duration-200 ease-in-out disabled:pointer-events-none disabled:opacity-70 focus-visible:ring-primary-500 focus-visible:ring-offset-1 focus-visible:ring-2']) }} > Date: Fri, 21 Mar 2025 08:03:56 +0100 Subject: [PATCH 4/7] Fix toggle focus indication offset color in dark mode --- packages/forms/resources/views/components/toggle.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/forms/resources/views/components/toggle.blade.php b/packages/forms/resources/views/components/toggle.blade.php index 3f675c7d4a..89e409b418 100644 --- a/packages/forms/resources/views/components/toggle.blade.php +++ b/packages/forms/resources/views/components/toggle.blade.php @@ -68,7 +68,7 @@ ], escape: false) ->merge($getExtraAttributes(), escape: false) ->merge($getExtraAlpineAttributes(), escape: false) - ->class(['fi-fo-toggle relative inline-flex h-6 w-11 shrink-0 cursor-pointer rounded-full border-2 border-transparent outline-none transition-colors duration-200 ease-in-out disabled:pointer-events-none disabled:opacity-70 focus-visible:ring-primary-500 focus-visible:ring-offset-1 focus-visible:ring-2']) + ->class(['fi-fo-toggle relative inline-flex h-6 w-11 shrink-0 cursor-pointer rounded-full border-2 border-transparent outline-none transition-colors duration-200 ease-in-out disabled:pointer-events-none disabled:opacity-70 focus-visible:ring-primary-600 focus-visible:ring-offset-1 focus-visible:ring-2 dark:focus-visible:ring-primary-500 dark:focus-visible:ring-offset-gray-900']) }} > Date: Fri, 21 Mar 2025 08:18:54 +0100 Subject: [PATCH 5/7] make toggle-column keyboard-accessible --- .../views/columns/toggle-column.blade.php | 37 +++++++++++-------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/packages/tables/resources/views/columns/toggle-column.blade.php b/packages/tables/resources/views/columns/toggle-column.blade.php index 70c220ecd6..57985e830c 100644 --- a/packages/tables/resources/views/columns/toggle-column.blade.php +++ b/packages/tables/resources/views/columns/toggle-column.blade.php @@ -28,26 +28,22 @@ @endphp
$isDisabled, ]) > From e0f5bd6b0d979cc77ad86c749469f9fe65f89061 Mon Sep 17 00:00:00 2001 From: Remi Ebeling Date: Fri, 21 Mar 2025 08:54:20 +0100 Subject: [PATCH 6/7] restore disabled check in callback --- packages/tables/resources/views/columns/toggle-column.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tables/resources/views/columns/toggle-column.blade.php b/packages/tables/resources/views/columns/toggle-column.blade.php index 57985e830c..c37f5162a8 100644 --- a/packages/tables/resources/views/columns/toggle-column.blade.php +++ b/packages/tables/resources/views/columns/toggle-column.blade.php @@ -30,7 +30,7 @@
$isDisabled, ]) > @@ -177,4 +172,4 @@
- + \ No newline at end of file