diff --git a/packages/panels/resources/views/components/sidebar/group.blade.php b/packages/panels/resources/views/components/sidebar/group.blade.php index a0999c544b..9f580f33b0 100644 --- a/packages/panels/resources/views/components/sidebar/group.blade.php +++ b/packages/panels/resources/views/components/sidebar/group.blade.php @@ -72,8 +72,8 @@ :grouped="filled($label)" :icon="$item->getIcon()" :last="$loop->last" - :should-open-url-in-new-tab="$item->shouldOpenUrlInNewTab()" :url="$item->getUrl()" + :should-open-url-in-new-tab="$item->shouldOpenUrlInNewTab()" > {{ $item->getLabel() }} diff --git a/packages/panels/src/Navigation/MenuItem.php b/packages/panels/src/Navigation/MenuItem.php index c7cdb97b7f..bb16def4b6 100644 --- a/packages/panels/src/Navigation/MenuItem.php +++ b/packages/panels/src/Navigation/MenuItem.php @@ -78,7 +78,6 @@ class MenuItem extends Component return $this; } - public function openUrlInNewTab(bool | Closure $condition = true): static { $this->shouldOpenUrlInNewTab = $condition; @@ -86,7 +85,6 @@ class MenuItem extends Component return $this; } - public function hidden(bool | Closure $condition = true): static { $this->isHidden = $condition; @@ -143,7 +141,6 @@ class MenuItem extends Component return $this->evaluate($this->url); } - public function shouldOpenUrlInNewTab(): bool { return (bool) $this->evaluate($this->shouldOpenUrlInNewTab); diff --git a/packages/panels/src/Navigation/NavigationItem.php b/packages/panels/src/Navigation/NavigationItem.php index e926ad0aca..5d9d056635 100644 --- a/packages/panels/src/Navigation/NavigationItem.php +++ b/packages/panels/src/Navigation/NavigationItem.php @@ -125,7 +125,7 @@ class NavigationItem extends Component public function url(string | Closure | null $url, bool | Closure $shouldOpenInNewTab = false): static { - $this->shouldOpenUrlInNewTab = $shouldOpenInNewTab; + $this->openUrlInNewTab($shouldOpenInNewTab); $this->url = $url; return $this; diff --git a/packages/widgets/src/StatsOverviewWidget/Stat.php b/packages/widgets/src/StatsOverviewWidget/Stat.php index 8dd3222756..86e08d4ccc 100644 --- a/packages/widgets/src/StatsOverviewWidget/Stat.php +++ b/packages/widgets/src/StatsOverviewWidget/Stat.php @@ -146,7 +146,7 @@ class Stat extends Component implements Htmlable public function url(?string $url, bool $shouldOpenInNewTab = false): static { - $this->shouldOpenUrlInNewTab = $shouldOpenInNewTab; + $this->openUrlInNewTab($shouldOpenInNewTab); $this->url = $url; return $this;