From 0f12799b42a3517918562a4617f8ec7179a7377f Mon Sep 17 00:00:00 2001 From: Vitali K Date: Tue, 8 Jul 2025 20:47:01 +0400 Subject: [PATCH] feat: require confirmation for delete, force delete, restore, detach, and dissociate actions in tables and actions packages --- packages/actions/src/DeleteAction.php | 4 ++-- packages/actions/src/ForceDeleteAction.php | 4 ++-- packages/actions/src/RestoreAction.php | 4 ++-- packages/tables/src/Actions/DeleteAction.php | 4 ++-- packages/tables/src/Actions/DeleteBulkAction.php | 4 ++-- packages/tables/src/Actions/DetachAction.php | 4 ++-- packages/tables/src/Actions/DetachBulkAction.php | 4 ++-- packages/tables/src/Actions/DissociateAction.php | 4 ++-- packages/tables/src/Actions/DissociateBulkAction.php | 4 ++-- packages/tables/src/Actions/ForceDeleteAction.php | 4 ++-- packages/tables/src/Actions/ForceDeleteBulkAction.php | 4 ++-- packages/tables/src/Actions/RestoreAction.php | 4 ++-- packages/tables/src/Actions/RestoreBulkAction.php | 4 ++-- 13 files changed, 26 insertions(+), 26 deletions(-) diff --git a/packages/actions/src/DeleteAction.php b/packages/actions/src/DeleteAction.php index c61a01dc75..72388de99c 100644 --- a/packages/actions/src/DeleteAction.php +++ b/packages/actions/src/DeleteAction.php @@ -19,6 +19,8 @@ class DeleteAction extends Action { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::delete.single.label')); $this->modalHeading(fn (): string => __('filament-actions::delete.single.modal.heading', ['label' => $this->getRecordTitle()])); @@ -31,8 +33,6 @@ class DeleteAction extends Action $this->groupedIcon(FilamentIcon::resolve('actions::delete-action.grouped') ?? 'heroicon-m-trash'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::delete-action.modal') ?? 'heroicon-o-trash'); $this->keyBindings(['mod+d']); diff --git a/packages/actions/src/ForceDeleteAction.php b/packages/actions/src/ForceDeleteAction.php index 9593766bc0..f7dbe82cfd 100644 --- a/packages/actions/src/ForceDeleteAction.php +++ b/packages/actions/src/ForceDeleteAction.php @@ -19,6 +19,8 @@ class ForceDeleteAction extends Action { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::force-delete.single.label')); $this->modalHeading(fn (): string => __('filament-actions::force-delete.single.modal.heading', ['label' => $this->getRecordTitle()])); @@ -29,8 +31,6 @@ class ForceDeleteAction extends Action $this->groupedIcon(FilamentIcon::resolve('actions::force-delete-action.grouped') ?? 'heroicon-m-trash'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::force-delete-action.modal') ?? 'heroicon-o-trash'); $this->action(function (): void { diff --git a/packages/actions/src/RestoreAction.php b/packages/actions/src/RestoreAction.php index 567e31be52..9a036cc7f7 100644 --- a/packages/actions/src/RestoreAction.php +++ b/packages/actions/src/RestoreAction.php @@ -19,6 +19,8 @@ class RestoreAction extends Action { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::restore.single.label')); $this->modalHeading(fn (): string => __('filament-actions::restore.single.modal.heading', ['label' => $this->getRecordTitle()])); @@ -31,8 +33,6 @@ class RestoreAction extends Action $this->groupedIcon(FilamentIcon::resolve('actions::restore-action.grouped') ?? 'heroicon-m-arrow-uturn-left'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::restore-action.modal') ?? 'heroicon-o-arrow-uturn-left'); $this->action(function (Model $record): void { diff --git a/packages/tables/src/Actions/DeleteAction.php b/packages/tables/src/Actions/DeleteAction.php index 4e2c2740ed..da1e02955f 100644 --- a/packages/tables/src/Actions/DeleteAction.php +++ b/packages/tables/src/Actions/DeleteAction.php @@ -19,6 +19,8 @@ class DeleteAction extends Action { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::delete.single.label')); $this->modalHeading(fn (): string => __('filament-actions::delete.single.modal.heading', ['label' => $this->getRecordTitle()])); @@ -31,8 +33,6 @@ class DeleteAction extends Action $this->icon(FilamentIcon::resolve('actions::delete-action') ?? 'heroicon-m-trash'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::delete-action.modal') ?? 'heroicon-o-trash'); $this->hidden(static function (Model $record): bool { diff --git a/packages/tables/src/Actions/DeleteBulkAction.php b/packages/tables/src/Actions/DeleteBulkAction.php index 74b1327cfe..0dccd0f9ad 100644 --- a/packages/tables/src/Actions/DeleteBulkAction.php +++ b/packages/tables/src/Actions/DeleteBulkAction.php @@ -22,6 +22,8 @@ class DeleteBulkAction extends BulkAction { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::delete.multiple.label')); $this->modalHeading(fn (): string => __('filament-actions::delete.multiple.modal.heading', ['label' => $this->getPluralModelLabel()])); @@ -34,8 +36,6 @@ class DeleteBulkAction extends BulkAction $this->icon(FilamentIcon::resolve('actions::delete-action') ?? 'heroicon-m-trash'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::delete-action.modal') ?? 'heroicon-o-trash'); $this->action(function (): void { diff --git a/packages/tables/src/Actions/DetachAction.php b/packages/tables/src/Actions/DetachAction.php index c92a5523e0..3148797937 100644 --- a/packages/tables/src/Actions/DetachAction.php +++ b/packages/tables/src/Actions/DetachAction.php @@ -21,6 +21,8 @@ class DetachAction extends Action { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::detach.single.label')); $this->modalHeading(fn (): string => __('filament-actions::detach.single.modal.heading', ['label' => $this->getRecordTitle()])); @@ -33,8 +35,6 @@ class DetachAction extends Action $this->icon(FilamentIcon::resolve('actions::detach-action') ?? 'heroicon-m-x-mark'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::detach-action.modal') ?? 'heroicon-o-x-mark'); $this->action(function (): void { diff --git a/packages/tables/src/Actions/DetachBulkAction.php b/packages/tables/src/Actions/DetachBulkAction.php index 3dd4da670d..842fa3b1e1 100644 --- a/packages/tables/src/Actions/DetachBulkAction.php +++ b/packages/tables/src/Actions/DetachBulkAction.php @@ -22,6 +22,8 @@ class DetachBulkAction extends BulkAction { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::detach.multiple.label')); $this->modalHeading(fn (): string => __('filament-actions::detach.multiple.modal.heading', ['label' => $this->getPluralModelLabel()])); @@ -34,8 +36,6 @@ class DetachBulkAction extends BulkAction $this->icon(FilamentIcon::resolve('actions::detach-action') ?? 'heroicon-m-x-mark'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::detach-action.modal') ?? 'heroicon-o-x-mark'); $this->action(function (): void { diff --git a/packages/tables/src/Actions/DissociateAction.php b/packages/tables/src/Actions/DissociateAction.php index 6a5bb5484a..d5db5f07f1 100644 --- a/packages/tables/src/Actions/DissociateAction.php +++ b/packages/tables/src/Actions/DissociateAction.php @@ -21,6 +21,8 @@ class DissociateAction extends Action { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::dissociate.single.label')); $this->modalHeading(fn (): string => __('filament-actions::dissociate.single.modal.heading', ['label' => $this->getRecordTitle()])); @@ -33,8 +35,6 @@ class DissociateAction extends Action $this->icon(FilamentIcon::resolve('actions::dissociate-action') ?? 'heroicon-m-x-mark'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::dissociate-action.modal') ?? 'heroicon-o-x-mark'); $this->action(function (): void { diff --git a/packages/tables/src/Actions/DissociateBulkAction.php b/packages/tables/src/Actions/DissociateBulkAction.php index 0c0889df64..06806b9c9b 100644 --- a/packages/tables/src/Actions/DissociateBulkAction.php +++ b/packages/tables/src/Actions/DissociateBulkAction.php @@ -22,6 +22,8 @@ class DissociateBulkAction extends BulkAction { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::dissociate.multiple.label')); $this->modalHeading(fn (): string => __('filament-actions::dissociate.multiple.modal.heading', ['label' => $this->getPluralModelLabel()])); @@ -34,8 +36,6 @@ class DissociateBulkAction extends BulkAction $this->icon(FilamentIcon::resolve('actions::dissociate-action') ?? 'heroicon-m-x-mark'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::dissociate-action.modal') ?? 'heroicon-o-x-mark'); $this->action(function (): void { diff --git a/packages/tables/src/Actions/ForceDeleteAction.php b/packages/tables/src/Actions/ForceDeleteAction.php index 1a452abb1e..0cb1efc824 100644 --- a/packages/tables/src/Actions/ForceDeleteAction.php +++ b/packages/tables/src/Actions/ForceDeleteAction.php @@ -19,6 +19,8 @@ class ForceDeleteAction extends Action { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::force-delete.single.label')); $this->modalHeading(fn (): string => __('filament-actions::force-delete.single.modal.heading', ['label' => $this->getRecordTitle()])); @@ -31,8 +33,6 @@ class ForceDeleteAction extends Action $this->icon(FilamentIcon::resolve('actions::force-delete-action') ?? 'heroicon-m-trash'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::force-delete-action.modal') ?? 'heroicon-o-trash'); $this->action(function (): void { diff --git a/packages/tables/src/Actions/ForceDeleteBulkAction.php b/packages/tables/src/Actions/ForceDeleteBulkAction.php index 7fc0519d6e..30ddf9e57f 100644 --- a/packages/tables/src/Actions/ForceDeleteBulkAction.php +++ b/packages/tables/src/Actions/ForceDeleteBulkAction.php @@ -22,6 +22,8 @@ class ForceDeleteBulkAction extends BulkAction { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::force-delete.multiple.label')); $this->modalHeading(fn (): string => __('filament-actions::force-delete.multiple.modal.heading', ['label' => $this->getPluralModelLabel()])); @@ -34,8 +36,6 @@ class ForceDeleteBulkAction extends BulkAction $this->icon(FilamentIcon::resolve('actions::force-delete-action') ?? 'heroicon-m-trash'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::force-delete-action.modal') ?? 'heroicon-o-trash'); $this->action(function (): void { diff --git a/packages/tables/src/Actions/RestoreAction.php b/packages/tables/src/Actions/RestoreAction.php index 3ca9475655..0092150858 100644 --- a/packages/tables/src/Actions/RestoreAction.php +++ b/packages/tables/src/Actions/RestoreAction.php @@ -19,6 +19,8 @@ class RestoreAction extends Action { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::restore.single.label')); $this->modalHeading(fn (): string => __('filament-actions::restore.single.modal.heading', ['label' => $this->getRecordTitle()])); @@ -31,8 +33,6 @@ class RestoreAction extends Action $this->icon(FilamentIcon::resolve('actions::restore-action') ?? 'heroicon-m-arrow-uturn-left'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::restore-action.modal') ?? 'heroicon-o-arrow-uturn-left'); $this->action(function (Model $record): void { diff --git a/packages/tables/src/Actions/RestoreBulkAction.php b/packages/tables/src/Actions/RestoreBulkAction.php index 5eead71e9b..adae1d0f01 100644 --- a/packages/tables/src/Actions/RestoreBulkAction.php +++ b/packages/tables/src/Actions/RestoreBulkAction.php @@ -22,6 +22,8 @@ class RestoreBulkAction extends BulkAction { parent::setUp(); + $this->requiresConfirmation(); + $this->label(__('filament-actions::restore.multiple.label')); $this->modalHeading(fn (): string => __('filament-actions::restore.multiple.modal.heading', ['label' => $this->getPluralModelLabel()])); @@ -34,8 +36,6 @@ class RestoreBulkAction extends BulkAction $this->icon(FilamentIcon::resolve('actions::restore-action') ?? 'heroicon-m-arrow-uturn-left'); - $this->requiresConfirmation(); - $this->modalIcon(FilamentIcon::resolve('actions::restore-action.modal') ?? 'heroicon-o-arrow-uturn-left'); $this->action(function (): void {