From 855f78f645993bad54f67b4308a916259cd72ce7 Mon Sep 17 00:00:00 2001 From: Dan Harrin Date: Tue, 1 Jul 2025 10:17:46 +0100 Subject: [PATCH] Apply suggestions from code review --- packages/actions/src/Exports/Jobs/PrepareCsvExport.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/actions/src/Exports/Jobs/PrepareCsvExport.php b/packages/actions/src/Exports/Jobs/PrepareCsvExport.php index ad5c17576e..7183f1bdfe 100644 --- a/packages/actions/src/Exports/Jobs/PrepareCsvExport.php +++ b/packages/actions/src/Exports/Jobs/PrepareCsvExport.php @@ -76,7 +76,7 @@ class PrepareCsvExport implements ShouldQueue return ($order['column'] ?? null) === $qualifiedKeyName; }) - ->unique(function (array $order) { + ->unique(function (array $order): string { if (($order['type'] ?? null) === 'Raw') { return 'raw:' . ($order['sql'] ?? ''); } @@ -105,7 +105,7 @@ class PrepareCsvExport implements ShouldQueue foreach ($originalOrders as $order) { if (($order['type'] ?? null) === 'Raw') { $query->orderByRaw($order['sql']); - } elseif (! blank($order['column'] ?? null) && ! blank($order['direction'] ?? null)) { + } elseif (filled($order['column'] ?? null) && filled($order['direction'] ?? null)) { $query->orderBy($order['column'], $order['direction']); } }