From 198b2696271d0bdb7bbb5d67793329b6550ca719 Mon Sep 17 00:00:00 2001 From: Sumon Ahmed Date: Tue, 12 Aug 2025 17:10:16 +0600 Subject: [PATCH 1/2] fix: Remove redundant column prefixing in table summaries - Reverts PR #10420 changes in CanSummarizeRecords.php - In Filament v4, columns are now prefixed inside the getSelectStatements() method - Eliminates duplicate prefixing that caused SQL query issues --- packages/tables/src/Concerns/CanSummarizeRecords.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/tables/src/Concerns/CanSummarizeRecords.php b/packages/tables/src/Concerns/CanSummarizeRecords.php index 12f8e61b84..412eb4b205 100644 --- a/packages/tables/src/Concerns/CanSummarizeRecords.php +++ b/packages/tables/src/Concerns/CanSummarizeRecords.php @@ -43,10 +43,7 @@ trait CanSummarizeRecords continue; } - /** @var Connection $queryConnection */ - $queryConnection = $query->getConnection(); - - $qualifiedAttribute = $queryConnection->getTablePrefix() . $query->getModel()->qualifyColumn($column->getName()); + $qualifiedAttribute = $query->getModel()->qualifyColumn($column->getName()); foreach ($summarizers as $summarizer) { if ($summarizer->hasQueryModification()) { From 24906a17e36f541967c24ca0224b35c7458b6a00 Mon Sep 17 00:00:00 2001 From: bdsumon4u Date: Tue, 12 Aug 2025 11:21:10 +0000 Subject: [PATCH 2/2] chore: fix code style --- packages/tables/resources/views/index.blade.php | 2 +- packages/tables/src/Concerns/CanSummarizeRecords.php | 1 - .../src/Commands/UpgradeDirectoryStructureToV4Command.php | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/tables/resources/views/index.blade.php b/packages/tables/resources/views/index.blade.php index a7c3f406fc..4ba0dff051 100644 --- a/packages/tables/resources/views/index.blade.php +++ b/packages/tables/resources/views/index.blade.php @@ -277,7 +277,7 @@ if (! grouping) { group = null direction = null - + return } diff --git a/packages/tables/src/Concerns/CanSummarizeRecords.php b/packages/tables/src/Concerns/CanSummarizeRecords.php index 412eb4b205..07ba7dc6fe 100644 --- a/packages/tables/src/Concerns/CanSummarizeRecords.php +++ b/packages/tables/src/Concerns/CanSummarizeRecords.php @@ -4,7 +4,6 @@ namespace Filament\Tables\Concerns; use Closure; use Filament\Support\Services\RelationshipJoiner; -use Illuminate\Database\Connection; use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Query\Expression; use Illuminate\Support\Str; diff --git a/packages/upgrade/src/Commands/UpgradeDirectoryStructureToV4Command.php b/packages/upgrade/src/Commands/UpgradeDirectoryStructureToV4Command.php index 420519fcb0..59a2b29313 100644 --- a/packages/upgrade/src/Commands/UpgradeDirectoryStructureToV4Command.php +++ b/packages/upgrade/src/Commands/UpgradeDirectoryStructureToV4Command.php @@ -262,7 +262,6 @@ class UpgradeDirectoryStructureToV4Command extends Command } /** - * @param string $directory * @return array */ protected function findPhpFiles(string $directory): array