From 4d0c87af2336b630bb7e596365d29318bf312b65 Mon Sep 17 00:00:00 2001 From: Dan Harrin Date: Tue, 1 Jul 2025 10:27:19 +0100 Subject: [PATCH] Allow nullable asset packages --- packages/support/src/Assets/Asset.php | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/packages/support/src/Assets/Asset.php b/packages/support/src/Assets/Asset.php index 9aa03c8e83..7478ea209c 100644 --- a/packages/support/src/Assets/Asset.php +++ b/packages/support/src/Assets/Asset.php @@ -14,7 +14,7 @@ abstract class Asset protected bool $isLoadedOnRequest = false; - protected string $package; + protected ?string $package = null; final public function __construct(string $id, ?string $path = null) { @@ -39,14 +39,14 @@ abstract class Asset return $this->id; } - public function package(string $package): static + public function package(?string $package): static { $this->package = $package; return $this; } - public function getPackage(): string + public function getPackage(): ?string { return $this->package; } @@ -63,15 +63,21 @@ abstract class Asset public function getVersion(): string { + $package = $this->getPackage(); + + if (blank($package)) { + return InstalledVersions::getVersion('filament/support'); + } + if ( - ($this->getPackage() === 'app') && + ($package === 'app') && filled($appVersion = FilamentAsset::getAppVersion()) ) { return $appVersion; } try { - return InstalledVersions::getVersion($this->getPackage()); + return InstalledVersions::getVersion($package); } catch (Throwable $exception) { return InstalledVersions::getVersion('filament/support'); }