From ddcd88bc82a4cfbe8fbdeb1dff8df239e49d0e5d Mon Sep 17 00:00:00 2001 From: Dan Pock Date: Fri, 7 May 2021 16:36:28 -0400 Subject: [PATCH 1/3] initial placeholder component --- .../views/components/placeholder.blade.php | 14 +++++++++ packages/forms/src/Components/Placeholder.php | 31 +++++++++++++++++++ .../Forms/Components/Placeholder.php | 8 +++++ 3 files changed, 53 insertions(+) create mode 100644 packages/forms/resources/views/components/placeholder.blade.php create mode 100644 packages/forms/src/Components/Placeholder.php create mode 100644 src/Resources/Forms/Components/Placeholder.php diff --git a/packages/forms/resources/views/components/placeholder.blade.php b/packages/forms/resources/views/components/placeholder.blade.php new file mode 100644 index 0000000000..af4daee53b --- /dev/null +++ b/packages/forms/resources/views/components/placeholder.blade.php @@ -0,0 +1,14 @@ + +
+ + {{ $formComponent->getName() }} + +
+
diff --git a/packages/forms/src/Components/Placeholder.php b/packages/forms/src/Components/Placeholder.php new file mode 100644 index 0000000000..4c037cb3bb --- /dev/null +++ b/packages/forms/src/Components/Placeholder.php @@ -0,0 +1,31 @@ +name($placeholderValue); + $this->setUp(); + } + + protected function name($name) + { + $this->name = $name; + + return $this; + } + + public function getName() + { + return $this->name; + } + + public static function make(string $placeholderValue) + { + return new static($placeholderValue); + } +} diff --git a/src/Resources/Forms/Components/Placeholder.php b/src/Resources/Forms/Components/Placeholder.php new file mode 100644 index 0000000000..46e6c2cbee --- /dev/null +++ b/src/Resources/Forms/Components/Placeholder.php @@ -0,0 +1,8 @@ + Date: Fri, 7 May 2021 17:14:36 -0400 Subject: [PATCH 2/3] adjust API to match other fields --- .../views/components/placeholder.blade.php | 2 +- packages/forms/src/Components/Placeholder.php | 37 +++++++++++++++++-- 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/packages/forms/resources/views/components/placeholder.blade.php b/packages/forms/resources/views/components/placeholder.blade.php index af4daee53b..1f95949712 100644 --- a/packages/forms/resources/views/components/placeholder.blade.php +++ b/packages/forms/resources/views/components/placeholder.blade.php @@ -8,7 +8,7 @@ - {{ $formComponent->getName() }} + {{ $formComponent->getValue() }} diff --git a/packages/forms/src/Components/Placeholder.php b/packages/forms/src/Components/Placeholder.php index 4c037cb3bb..268e31cf4b 100644 --- a/packages/forms/src/Components/Placeholder.php +++ b/packages/forms/src/Components/Placeholder.php @@ -2,13 +2,17 @@ namespace Filament\Forms\Components; +use Illuminate\Support\Str; + class Placeholder extends Component { protected $name; + protected $value; - public function __construct($placeholderValue) + public function __construct(string $name, string $value) { - $this->name($placeholderValue); + $this->name($name); + $this->value($value); $this->setUp(); } @@ -24,8 +28,33 @@ class Placeholder extends Component return $this->name; } - public static function make(string $placeholderValue) + protected function value($value) { - return new static($placeholderValue); + $this->value = $value; + + return $this; + } + + public function getValue() + { + return $this->value; + } + + public function getLabel() + { + if ($this->label === null) { + return (string) Str::of($this->getName()) + ->afterLast('.') + ->kebab() + ->replace(['-', '_'], ' ') + ->ucfirst(); + } + + return parent::getLabel(); + } + + public static function make(string $name, string $value) + { + return new static($name, $value); } } From 1134a770029d8052d012766a3607f5bc3abbaa03 Mon Sep 17 00:00:00 2001 From: Dan Harrin Date: Thu, 3 Jun 2021 20:52:32 +0100 Subject: [PATCH 3/3] Update Placeholder.php --- packages/forms/src/Components/Placeholder.php | 54 ++++++++++--------- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/packages/forms/src/Components/Placeholder.php b/packages/forms/src/Components/Placeholder.php index 268e31cf4b..1d650fe866 100644 --- a/packages/forms/src/Components/Placeholder.php +++ b/packages/forms/src/Components/Placeholder.php @@ -7,39 +7,17 @@ use Illuminate\Support\Str; class Placeholder extends Component { protected $name; + protected $value; - public function __construct(string $name, string $value) + public function __construct($name, $value) { $this->name($name); $this->value($value); + $this->setUp(); } - protected function name($name) - { - $this->name = $name; - - return $this; - } - - public function getName() - { - return $this->name; - } - - protected function value($value) - { - $this->value = $value; - - return $this; - } - - public function getValue() - { - return $this->value; - } - public function getLabel() { if ($this->label === null) { @@ -53,7 +31,31 @@ class Placeholder extends Component return parent::getLabel(); } - public static function make(string $name, string $value) + public function getName() + { + return $this->name; + } + + public function getValue() + { + return $this->value; + } + + protected function name($name) + { + $this->name = $name; + + return $this; + } + + protected function value($value) + { + $this->value = $value; + + return $this; + } + + public static function make($name, $value) { return new static($name, $value); }