From 9c7753715bd277a6a64008dc89fff06ee752dfb6 Mon Sep 17 00:00:00 2001 From: Kamran Ahmed Date: Mon, 4 Mar 2019 10:17:44 +0400 Subject: [PATCH] Fix - Error on hide when popover is not shown --- package.json | 2 +- src/core/popover.js | 5 +++++ src/index.js | 1 - 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 74f8143..b5bf8fd 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "driver.js", - "version": "0.9.3", + "version": "0.9.4", "description": "A light-weight, no-dependency, vanilla JavaScript library to drive the user's focus across the page", "main": "dist/driver.min.js", "types": "types/index.d.ts", diff --git a/src/core/popover.js b/src/core/popover.js index eeb9e93..c2da545 100644 --- a/src/core/popover.js +++ b/src/core/popover.js @@ -91,6 +91,11 @@ export default class Popover extends Element { * @public */ hide() { + // If hide is called when the node isn't created yet + if (!this.node) { + return; + } + this.node.style.display = 'none'; } diff --git a/src/index.js b/src/index.js index 718a729..1dc1c37 100644 --- a/src/index.js +++ b/src/index.js @@ -145,7 +145,6 @@ export default class Driver { } } - /** * Handler for the onResize DOM event * Makes sure highlighted element stays at valid position