feat(dataset): add New Knowledge list and empty state (#39300)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

api/tests/unit_tests/controllers/console/test_knowledge_fs_proxy.py

@@ -22,6 +22,7 @@ from controllers.console.knowledge_fs_proxy import (
     _proxy_request,
     _proxy_response,
     proxy_knowledge_fs_get,
+    proxy_knowledge_fs_options,
     proxy_knowledge_fs_write,
 )
 from controllers.console.wraps import RBACPermission
@@ -118,10 +119,61 @@ def test_console_blueprint_registers_generic_knowledge_fs_routes() -> None:
         "/console/api/knowledge-fs/knowledge-spaces",
         method="OPTIONS",
     )
-    assert options_endpoint.endswith("proxy_knowledge_fs_get")
+    assert options_endpoint.endswith("proxy_knowledge_fs_options")
     assert options_values == {"upstream_path": "knowledge-spaces"}
 
 
+def test_proxy_options_does_not_require_an_authenticated_account(app: Flask) -> None:
+    with app.test_request_context(
+        "/console/api/knowledge-fs/knowledge-spaces",
+        method="OPTIONS",
+        headers={"Access-Control-Request-Method": "GET"},
+    ):
+        response = app.make_response(proxy_knowledge_fs_options("knowledge-spaces"))
+
+    assert response.status_code == 204
+
+
+def test_proxy_options_is_hidden_when_knowledge_fs_is_disabled(
+    app: Flask,
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    monkeypatch.setattr("controllers.console.knowledge_fs_proxy.dify_config.KNOWLEDGE_FS_ENABLED", False)
+
+    with app.test_request_context(
+        "/console/api/knowledge-fs/knowledge-spaces",
+        method="OPTIONS",
+        headers={"Access-Control-Request-Method": "GET"},
+    ):
+        response = app.make_response(proxy_knowledge_fs_options("knowledge-spaces"))
+
+    assert response.status_code == 404
+
+
+@pytest.mark.parametrize(
+    ("upstream_path", "requested_method"),
+    [
+        ("unregistered", "GET"),
+        ("knowledge-spaces", "DELETE"),
+        ("knowledge-spaces", ""),
+    ],
+)
+def test_proxy_options_hides_unregistered_operations(
+    app: Flask,
+    upstream_path: str,
+    requested_method: str,
+) -> None:
+    headers = {"Access-Control-Request-Method": requested_method} if requested_method else None
+    with app.test_request_context(
+        f"/console/api/knowledge-fs/{upstream_path}",
+        method="OPTIONS",
+        headers=headers,
+    ):
+        response = app.make_response(proxy_knowledge_fs_options(upstream_path))
+
+    assert response.status_code == 404
+
+
 def test_proxy_is_hidden_when_knowledge_fs_is_disabled(app: Flask, monkeypatch: pytest.MonkeyPatch) -> None:
     monkeypatch.setattr("controllers.console.knowledge_fs_proxy.dify_config.KNOWLEDGE_FS_ENABLED", False)
 

api/tests/unit_tests/dev/test_generate_knowledge_fs_contract.py

@@ -10,7 +10,11 @@ from typing import cast
 import pytest
 
 from dev import generate_knowledge_fs_contract as contract_validator
-from dev.generate_knowledge_fs_contract import ContractDeclaration, validate_declarations
+from dev.generate_knowledge_fs_contract import (
+    ContractDeclaration,
+    filter_openapi_document,
+    validate_declarations,
+)
 from services.knowledge_fs_proxy import KNOWLEDGE_FS_CONSOLE_OPERATIONS, KnowledgeFSOperation
 
 
@@ -55,7 +59,8 @@ def test_contract_cli_updates_checks_and_detects_openapi_drift(tmp_path: Path, m
         )
     )
     monkeypatch.setattr(contract_validator, "LOCK_PATH", lock_path)
-    monkeypatch.setenv("PATH", f"{executable_directory}{os.pathsep}{os.environ['PATH']}")
+    current_path = os.environ.get("PATH", os.defpath)
+    monkeypatch.setenv("PATH", f"{executable_directory}{os.pathsep}{current_path}")
 
     monkeypatch.setattr(
         sys,
@@ -131,6 +136,52 @@ def test_validate_declarations_accepts_matching_contract() -> None:
     )
 
 
+def test_filter_openapi_document_keeps_only_declared_operations_and_referenced_schemas() -> None:
+    list_route = operation("knowledge-spaces:read", "listKnowledgeSpaces")
+    list_route["responses"] = {
+        "200": {
+            "content": {
+                "application/json": {
+                    "schema": {"$ref": "#/components/schemas/KnowledgeSpaceList"},
+                }
+            }
+        }
+    }
+    document = {
+        "openapi": "3.1.0",
+        "paths": {
+            "/knowledge-spaces": {
+                "get": list_route,
+                "post": operation("knowledge-spaces:write", "createKnowledgeSpace"),
+            },
+            "/health": {"get": operation(None, "getHealth", security=[])},
+        },
+        "components": {
+            "schemas": {
+                "KnowledgeSpaceList": {
+                    "type": "object",
+                    "properties": {
+                        "items": {
+                            "type": "array",
+                            "items": {"$ref": "#/components/schemas/KnowledgeSpace"},
+                        }
+                    },
+                },
+                "KnowledgeSpace": {"type": "object"},
+                "Unused": {"type": "object"},
+            },
+            "securitySchemes": {"bearerAuth": {"type": "http", "scheme": "bearer"}},
+        },
+    }
+
+    filtered = filter_openapi_document(document, (declaration(),))
+
+    assert set(filtered["paths"]) == {"/knowledge-spaces"}
+    assert set(filtered["paths"]["/knowledge-spaces"]) == {"get"}
+    assert set(filtered["components"]["schemas"]) == {"KnowledgeSpaceList", "KnowledgeSpace"}
+    assert filtered["components"]["securitySchemes"] == document["components"]["securitySchemes"]
+
+
 def test_console_operation_registry_matches_contract() -> None:
     list_route = operation("knowledge-spaces:read", "listKnowledgeSpaces")
     create_route = operation("knowledge-spaces:write", "createKnowledgeSpace")

api/tests/unit_tests/services/test_feature_service_knowledge_fs.py

@@ -0,0 +1,19 @@
+import pytest
+
+from services.feature_service import FeatureService, SystemFeatureModel
+
+
+def test_system_feature_model_disables_knowledge_fs_by_default() -> None:
+    assert SystemFeatureModel().knowledge_fs_enabled is False
+
+
+@pytest.mark.parametrize("enabled", [False, True])
+def test_get_system_features_reads_knowledge_fs_flag(
+    monkeypatch: pytest.MonkeyPatch,
+    enabled: bool,
+) -> None:
+    monkeypatch.setattr("services.feature_service.dify_config.KNOWLEDGE_FS_ENABLED", enabled)
+
+    result = FeatureService.get_system_features()
+
+    assert result.knowledge_fs_enabled is enabled