opensource/dify
3
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-09-24 23:22:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(agent-v2): accept composer UI ids on manual metadata filter conditions (#40171)

Browse Source 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This commit is contained in:
chelsealong
2026-08-08 06:55:27 +00:00
committed by GitHub
co-authored by autofix-ci[bot]
parent d362bdbb4e
commit 2a742486c5
11 changed files with 115 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/tests/unit_tests/core/workflow/nodes/agent_v2/test_runtime_request_builder.py
+7 -1
View File
@@ -744,7 +744,13 @@ def test_build_maps_agent_soul_knowledge_to_knowledge_layer_config():
"conditions": {
"logical_operator": "and",
"conditions": [
{"name": "category", "comparison_operator": "contains", "value": "auth"}
{
"id": "cond-1",
"metadata_id": "meta-1",
"name": "category",
"comparison_operator": "contains",
"value": "auth",
}
],
},
},
api/tests/unit_tests/services/agent/test_agent_composer_entities.py
+45
View File
@@ -365,6 +365,51 @@ def test_knowledge_runtime_requirements_block_publish_but_not_draft_save(knowled
ComposerConfigValidator.validate_publish_payload(publish_payload)
def test_manual_metadata_filtering_condition_accepts_composer_ui_identifiers():
"""The composer's condition editor always sends ``id`` (list row key) and
``metadata_id`` (selected metadata field reference) alongside every
condition. Rejecting them as unknown fields broke every save of a manual
metadata filter (see GH issue #40169)."""
payload = ComposerSavePayload.model_validate(
{
"variant": ComposerVariant.AGENT_APP,
"save_strategy": ComposerSaveStrategy.SAVE_TO_CURRENT_VERSION,
"agent_soul": {
"knowledge": {
"sets": [
{
"id": "support",
"name": "Support KB",
"datasets": [{"id": "dataset-1"}],
"query": {"mode": "generated_query"},
"retrieval": {"mode": "multiple", "top_k": 4},
"metadata_filtering": {
"mode": "manual",
"conditions": {
"logical_operator": "and",
"conditions": [
{
"id": "b149eceb-191a-40a2-9f11-61cf21ebd147",
"metadata_id": "ad6cf326-eadf-46e8-a2d5-9cb892d2cc84",
"name": "category",
"comparison_operator": "is",
"value": "auth",
}
],
},
},
},
]
}
},
}
)
condition = payload.agent_soul.knowledge.sets[0].metadata_filtering.conditions.conditions[0]
assert condition.id == "b149eceb-191a-40a2-9f11-61cf21ebd147"
assert condition.metadata_id == "ad6cf326-eadf-46e8-a2d5-9cb892d2cc84"
def test_agent_soul_model_config_is_first_class_without_credentials():
config = AgentSoulConfig(
model=AgentSoulModelConfig(