diff --git a/web/app/components/app/configuration/__tests__/configuration-view.spec.tsx b/web/app/components/app/configuration/__tests__/configuration-view.spec.tsx index 0a8e09172d8..32dd02f928b 100644 --- a/web/app/components/app/configuration/__tests__/configuration-view.spec.tsx +++ b/web/app/components/app/configuration/__tests__/configuration-view.spec.tsx @@ -352,8 +352,9 @@ describe('ConfigurationView', () => { render() - const badge = screen.getByRole('button', { name: 'appDebug.legacyAgentBadge.description' }) + const badge = screen.getByRole('button', { name: 'appDebug.legacyAgentBadge.label' }) expect(badge).toHaveTextContent('appDebug.legacyAgentBadge.label') + expect(badge).not.toHaveAttribute('aria-label') fireEvent.click(badge) diff --git a/web/app/components/app/configuration/configuration-view.tsx b/web/app/components/app/configuration/configuration-view.tsx index 7eee83fda08..317f2a5e011 100644 --- a/web/app/components/app/configuration/configuration-view.tsx +++ b/web/app/components/app/configuration/configuration-view.tsx @@ -54,7 +54,6 @@ function LegacyAgentBadge() { delay={300} closeDelay={200} type="button" - aria-label={description} className="inline-flex h-5 shrink-0 cursor-pointer items-center gap-0.5 rounded-[5px] border border-text-warning bg-components-badge-bg-dimm px-1.25 system-2xs-medium-uppercase whitespace-nowrap text-text-warning outline-hidden hover:bg-state-warning-hover focus-visible:ring-2 focus-visible:ring-state-accent-solid" > diff --git a/web/app/components/apps/__tests__/app-card.spec.tsx b/web/app/components/apps/__tests__/app-card.spec.tsx index 4f4a9dcca9c..94d7548960d 100644 --- a/web/app/components/apps/__tests__/app-card.spec.tsx +++ b/web/app/components/apps/__tests__/app-card.spec.tsx @@ -456,7 +456,7 @@ describe('AppCard', () => { const card = screen.getByRole('button', { name: 'Preview Only App' }) expect(card).toHaveClass('opacity-60') - expect(card).toHaveAttribute('aria-disabled', 'true') + expect(card).not.toHaveAttribute('aria-disabled') expect(screen.getByText('Only visible metadata')).toBeInTheDocument() expect(screen.getByText('Readonly Author')).toBeInTheDocument() const tagSelector = screen.getByLabelText('tag-selector') @@ -495,7 +495,7 @@ describe('AppCard', () => { const card = screen.getByRole('button', { name: 'Preview Only Starred App' }) expect(card).toHaveClass('opacity-60') - expect(card).toHaveAttribute('aria-disabled', 'true') + expect(card).not.toHaveAttribute('aria-disabled') expect(screen.getByText('Readonly Author')).toBeInTheDocument() expect( screen.queryByRole('link', { name: 'Preview Only Starred App' }), diff --git a/web/app/components/apps/app-card.tsx b/web/app/components/apps/app-card.tsx index 44d74c6d966..bd41defa080 100644 --- a/web/app/components/apps/app-card.tsx +++ b/web/app/components/apps/app-card.tsx @@ -1204,7 +1204,6 @@ export function AppCard({
{ const audio = document.querySelector('audio') expect(audio).toBeInTheDocument() expect(audio).toHaveAttribute('title', 'Test Audio') + expect(audio?.parentElement).not.toHaveAttribute('aria-label') }) it('should render source element with correct src and type', () => { diff --git a/web/app/components/base/file-uploader/__tests__/pdf-preview.spec.tsx b/web/app/components/base/file-uploader/__tests__/pdf-preview.spec.tsx index 4e3ea68db2a..a8ca6438749 100644 --- a/web/app/components/base/file-uploader/__tests__/pdf-preview.spec.tsx +++ b/web/app/components/base/file-uploader/__tests__/pdf-preview.spec.tsx @@ -64,6 +64,7 @@ describe('PdfPreview', () => { render() expect(document.querySelector('[tabindex="-1"]')).toBeInTheDocument() + expect(getScaleContainer()).not.toHaveAttribute('aria-label') expect(screen.getByTestId('pdf-loader')).toBeInTheDocument() expect(screen.getByTestId('pdf-highlighter')).toBeInTheDocument() expect(screen.getByRole('status')).toBeInTheDocument() diff --git a/web/app/components/base/file-uploader/__tests__/video-preview.spec.tsx b/web/app/components/base/file-uploader/__tests__/video-preview.spec.tsx index 2fbf8c2f783..5e951886816 100644 --- a/web/app/components/base/file-uploader/__tests__/video-preview.spec.tsx +++ b/web/app/components/base/file-uploader/__tests__/video-preview.spec.tsx @@ -14,6 +14,7 @@ describe('VideoPreview', () => { const video = document.querySelector('video') expect(video).toBeInTheDocument() expect(video).toHaveAttribute('title', 'Test Video') + expect(video?.parentElement).not.toHaveAttribute('aria-label') }) it('should render source element with correct src and type', () => { diff --git a/web/app/components/base/file-uploader/audio-preview.tsx b/web/app/components/base/file-uploader/audio-preview.tsx index 2f731f85344..6c2741d5fa3 100644 --- a/web/app/components/base/file-uploader/audio-preview.tsx +++ b/web/app/components/base/file-uploader/audio-preview.tsx @@ -22,7 +22,7 @@ const AudioPreview: FC = ({ url, title, onCancel }) => { className="inset-0! top-0! left-0! flex h-dvh! max-h-none! w-screen! max-w-none! translate-0! items-center justify-center overflow-hidden! rounded-none! border-none! bg-black/80 p-8! shadow-none!" backdropClassName="bg-transparent!" > -
e.stopPropagation()}> +
e.stopPropagation()}> diff --git a/web/app/components/base/file-uploader/pdf-preview.tsx b/web/app/components/base/file-uploader/pdf-preview.tsx index fe4f77c2346..54cc9264a57 100644 --- a/web/app/components/base/file-uploader/pdf-preview.tsx +++ b/web/app/components/base/file-uploader/pdf-preview.tsx @@ -57,7 +57,6 @@ const PdfPreview: FC = ({ url, onCancel }) => { backdropClassName="bg-transparent!" >
e.stopPropagation()} className="h-[95vh] max-h-full w-screen max-w-full overflow-hidden" diff --git a/web/app/components/base/file-uploader/video-preview.tsx b/web/app/components/base/file-uploader/video-preview.tsx index 31696d085ce..37f833bbd26 100644 --- a/web/app/components/base/file-uploader/video-preview.tsx +++ b/web/app/components/base/file-uploader/video-preview.tsx @@ -22,7 +22,7 @@ const VideoPreview: FC = ({ url, title, onCancel }) => { className="inset-0! top-0! left-0! flex h-dvh! max-h-none! w-screen! max-w-none! translate-0! items-center justify-center overflow-hidden! rounded-none! border-none! bg-black/80 p-8! shadow-none!" backdropClassName="bg-transparent!" > -
e.stopPropagation()}> +
e.stopPropagation()}> diff --git a/web/app/components/base/image-uploader/__tests__/image-preview.spec.tsx b/web/app/components/base/image-uploader/__tests__/image-preview.spec.tsx index ae1018bb19f..8f00b5ee456 100644 --- a/web/app/components/base/image-uploader/__tests__/image-preview.spec.tsx +++ b/web/app/components/base/image-uploader/__tests__/image-preview.spec.tsx @@ -99,6 +99,7 @@ describe('ImagePreview', () => { const overlay = getOverlay() expect(overlay).toBeInTheDocument() + expect(screen.getByTestId('image-preview-container')).not.toHaveAttribute('aria-label') expect(overlay.closest('[data-base-ui-portal]')?.parentElement).toBe(document.body) expect(screen.getByRole('img', { name: 'Preview Image' })).toHaveAttribute( 'src', diff --git a/web/app/components/base/image-uploader/image-preview.tsx b/web/app/components/base/image-uploader/image-preview.tsx index 401b877e008..e3562402ad0 100644 --- a/web/app/components/base/image-uploader/image-preview.tsx +++ b/web/app/components/base/image-uploader/image-preview.tsx @@ -185,7 +185,6 @@ const ImagePreview: FC = ({ url, title, onCancel, onPrev, onN backdropClassName="bg-transparent!" >
{ const card = screen.getByRole('button', { name: 'Preview Only Dataset' }) expect(card).toHaveClass('opacity-60') - expect(card).toHaveAttribute('aria-disabled', 'true') + expect(card).not.toHaveAttribute('aria-disabled') expect(screen.getByText('Preview Only Dataset')).toBeInTheDocument() const tagArea = screen.getByTestId('tag-area') expect(tagArea).toHaveAttribute('data-can-bind-or-unbind-tags', 'false') diff --git a/web/app/components/datasets/list/dataset-card/index.tsx b/web/app/components/datasets/list/dataset-card/index.tsx index 6a8591614bf..df280b6e2de 100644 --- a/web/app/components/datasets/list/dataset-card/index.tsx +++ b/web/app/components/datasets/list/dataset-card/index.tsx @@ -120,7 +120,6 @@ const DatasetCard = ({
{ ) fireEvent.click(screen.getByText('GPT-4')) - fireEvent.click(screen.getByText('COMMON.OPERATION.ADD')) + const addButton = screen.getByRole('button', { name: 'COMMON.OPERATION.ADD' }) + expect(addButton.closest('[aria-disabled="true"]')).toBeNull() + fireEvent.click(addButton) expect(onValueChange).not.toHaveBeenCalled() expect(mockSetShowModelModal).toHaveBeenCalled() diff --git a/web/app/components/header/account-setting/model-provider-page/model-selector/popup-item.tsx b/web/app/components/header/account-setting/model-provider-page/model-selector/popup-item.tsx index 490f4fd80e5..ab86ca366fc 100644 --- a/web/app/components/header/account-setting/model-provider-page/model-selector/popup-item.tsx +++ b/web/app/components/header/account-setting/model-provider-page/model-selector/popup-item.tsx @@ -225,7 +225,7 @@ function PopupItem({ ) const itemRender = modelItem.status === ModelStatusEnum.noConfigure ? ( -
+
{rowContent} {canCreateCredential && (