Files
coder/aibridge/intercept/responses/streaming.go
T
Susana Ferreira 7b903cad73 fix: track credential hint across key failover attempts in aibridge (#25735)
## Problem

Centralized requests recorded *the first available key from the pool at
`CreateInterceptor` time* as `credential_hint`, so the interception
could be persisted in the database with a hint that didn't match the key
that actually served the request. The fix consists in storing, at
end-of-interception, the hint of the key that succeeded, or the last
attempted key if all keys are unavailable.

## Changes

- Add `Key.Hint()` and update `credential_hint` on every failover
attempt so it reflects the actually-used key.
- Stop pre-populating `credential_hint` at `CreateInterceptor`.
Centralized starts empty and is updated by the key failover loop.
- Persist the final hint via `RecordInterceptionEnded`; SQL updates
`credential_hint` only when `credential_kind = 'centralized'` so BYOK
keeps its start-time value.
- Log the actually-used hint on interception end/failure; start log uses
a `<keypool-pending>` placeholder for centralized.

> [!NOTE]
> Initially generated by Claude Opus 4.7, modified and reviewed by
@ssncferreira
2026-05-29 12:01:37 +01:00

279 lines
8.9 KiB
Go

package responses
import (
"context"
"errors"
"net/http"
"time"
"github.com/google/uuid"
"github.com/openai/openai-go/v3/option"
"github.com/openai/openai-go/v3/packages/ssestream"
"github.com/openai/openai-go/v3/responses"
oaiconst "github.com/openai/openai-go/v3/shared/constant"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/trace"
"golang.org/x/xerrors"
"cdr.dev/slog/v3"
"github.com/coder/coder/v2/aibridge/config"
aibcontext "github.com/coder/coder/v2/aibridge/context"
"github.com/coder/coder/v2/aibridge/intercept"
"github.com/coder/coder/v2/aibridge/intercept/eventstream"
"github.com/coder/coder/v2/aibridge/keypool"
"github.com/coder/coder/v2/aibridge/mcp"
"github.com/coder/coder/v2/aibridge/recorder"
"github.com/coder/coder/v2/aibridge/tracing"
"github.com/coder/quartz"
)
const (
streamShutdownTimeout = time.Second * 30 // TODO: configurable
)
type StreamingResponsesInterceptor struct {
responsesInterceptionBase
}
func NewStreamingInterceptor(
id uuid.UUID,
reqPayload RequestPayload,
providerName string,
cfg config.OpenAI,
clientHeaders http.Header,
authHeaderName string,
tracer trace.Tracer,
cred intercept.CredentialInfo,
) *StreamingResponsesInterceptor {
return &StreamingResponsesInterceptor{
responsesInterceptionBase: responsesInterceptionBase{
id: id,
providerName: providerName,
reqPayload: reqPayload,
cfg: cfg,
clientHeaders: clientHeaders,
authHeaderName: authHeaderName,
tracer: tracer,
credential: cred,
},
}
}
func (i *StreamingResponsesInterceptor) Setup(logger slog.Logger, rec recorder.Recorder, mcpProxy mcp.ServerProxier) {
i.responsesInterceptionBase.Setup(logger.Named("streaming"), rec, mcpProxy)
}
func (*StreamingResponsesInterceptor) Streaming() bool {
return true
}
func (i *StreamingResponsesInterceptor) TraceAttributes(r *http.Request) []attribute.KeyValue {
return i.responsesInterceptionBase.baseTraceAttributes(r, true)
}
func (i *StreamingResponsesInterceptor) ProcessRequest(w http.ResponseWriter, r *http.Request) (outErr error) {
ctx, span := i.tracer.Start(r.Context(), "Intercept.ProcessRequest", trace.WithAttributes(tracing.InterceptionAttributesFromContext(r.Context())...))
defer tracing.EndSpanErr(span, &outErr)
ctx, cancel := context.WithCancel(ctx)
defer cancel()
r = r.WithContext(ctx) // Rewire context for SSE cancellation.
if err := i.validateRequest(ctx, w); err != nil {
return err
}
i.injectTools()
events := eventstream.NewEventStream(ctx, i.logger.Named("sse-sender"), nil, quartz.NewReal())
go events.Start(w, r)
defer func() {
shutdownCtx, shutdownCancel := context.WithTimeout(ctx, streamShutdownTimeout)
defer shutdownCancel()
_ = events.Shutdown(shutdownCtx)
}()
var respCopy responseCopier
var firstResponseID string
var completedResponse *responses.Response
var innerLoopErr error
var streamErr error
prompt, promptFound, err := i.reqPayload.lastUserPrompt(ctx, i.logger)
if err != nil {
i.logger.Warn(ctx, "failed to get user prompt", slog.Error(err))
}
shouldLoop := true
srv := i.newResponsesService()
for shouldLoop {
shouldLoop = false
// Per-iteration walker. An iteration is either an agentic
// continuation (sending a tool result back in a new
// stream) or a failover retry (previous key marked, try
// the next one).
var walker *keypool.Walker
if i.cfg.KeyPool != nil {
walker = i.cfg.KeyPool.Walker()
}
// Failover sub-loop: try keys until a stream starts
// successfully or we hit a non-recoverable error.
var stream *ssestream.Stream[responses.ResponseStreamEventUnion]
var startErr error
for {
respCopy = responseCopier{}
opts := i.requestOptions(&respCopy)
// TODO(ssncferreira): inject actor headers directly in the client-header
// middleware instead of using SDK options.
if actor := aibcontext.ActorFromContext(r.Context()); actor != nil && i.cfg.SendActorHeaders {
opts = append(opts, intercept.ActorHeadersAsOpenAIOpts(actor)...)
}
var currentKey *keypool.Key
if walker != nil {
key, keyPoolErr := walker.Next()
if keyPoolErr != nil {
// Pool exhausted: write the error directly. In
// agentic mode the inner loop buffers events
// instead of streaming them downstream, so the
// SSE connection has not been opened yet.
i.writeUpstreamError(w, intercept.ResponseErrorFromKeyPool(keyPoolErr))
return xerrors.Errorf("key pool exhausted: %w", keyPoolErr)
}
currentKey = key
// Record the key in use so the hint reflects the last attempted key.
i.credential = intercept.NewCredentialInfo(intercept.CredentialKindCentralized, key.Value())
i.logger.Debug(ctx, "using centralized api key",
slog.F("credential_hint", i.Credential().Hint), slog.F("credential_length", i.Credential().Length))
opts = append(opts,
option.WithAPIKey(key.Value()),
// Disable SDK retries because the failover
// loop handles retries via key rotation.
option.WithMaxRetries(0),
)
}
stream = i.newStream(ctx, srv, opts)
if upstreamErr := stream.Err(); upstreamErr != nil {
// Pre-stream failure of this attempt. For
// centralized requests, mark the key and
// retry with the next one.
if currentKey != nil && i.markKeyOnError(ctx, currentKey, upstreamErr) {
stream.Close()
continue
}
// Non-key error: stop trying and let the
// existing handling below report it.
startErr = upstreamErr
break
}
// Stream started successfully: commit to this key.
break
}
// func scope to defer steam.Close()
err := func() error {
defer stream.Close()
if startErr != nil {
// events stream should never be initialized
if events.IsStreaming() {
i.logger.Warn(ctx, "event stream was initialized when no response was received from upstream")
return startErr
}
// no response received from upstream (eg. client/connection error), return custom error
if !respCopy.responseReceived.Load() {
i.sendCustomErr(ctx, w, http.StatusInternalServerError, startErr)
return startErr
}
// forward received response as-is
err := respCopy.forwardResp(w)
return errors.Join(startErr, err)
}
for stream.Next() {
ev := stream.Current()
// Not every event has response.id set (eg: fixtures/openai/responses/streaming/simple.txtar).
// First event should be of 'response.created' type and have response.id set.
// Set responseID to the first response.id that is set.
if firstResponseID == "" && ev.Response.ID != "" {
firstResponseID = ev.Response.ID
}
// Capture the response from the response.completed event.
// Only response.completed event type have 'usage' field set.
if ev.Type == string(oaiconst.ValueOf[oaiconst.ResponseCompleted]()) {
completedEvent := ev.AsResponseCompleted()
completedResponse = &completedEvent.Response
}
// If no MCP proxy is provided then no tools are injected.
// Inner loop will never iterate more than once, so events can be forwarded as soon as received.
//
// Otherwise inner loop could iterate. Only last response should be forwarded.
// This is needed to keep consistency between response.id and response.previous_response_id fields.
if i.mcpProxy == nil {
if err := events.Send(ctx, respCopy.buff.readDelta()); err != nil {
err = xerrors.Errorf("failed to relay chunk: %w", err)
return err
}
}
}
streamErr = stream.Err()
return nil
}()
if err != nil {
return err
}
if i.mcpProxy != nil && completedResponse != nil {
pending := i.getPendingInjectedToolCalls(completedResponse)
shouldLoop, innerLoopErr = i.handleInnerAgenticLoop(ctx, pending, completedResponse)
if innerLoopErr != nil {
i.sendCustomErr(ctx, w, http.StatusInternalServerError, innerLoopErr)
shouldLoop = false
}
// Record token usage for each inner loop iteration
i.recordTokenUsage(ctx, completedResponse)
}
i.recordModelThoughts(ctx, completedResponse)
}
if promptFound {
i.recordUserPrompt(ctx, firstResponseID, prompt)
}
i.recordNonInjectedToolUsage(ctx, completedResponse)
// On innerLoop error custom error has been already sent,
// exit without emptying respCopy buffer.
if innerLoopErr != nil {
return innerLoopErr
}
b, err := respCopy.readAll()
if err != nil {
return xerrors.Errorf("failed to read response body: %w", err)
}
err = events.Send(ctx, b)
return errors.Join(err, streamErr)
}
func (i *StreamingResponsesInterceptor) newStream(ctx context.Context, srv responses.ResponseService, opts []option.RequestOption) *ssestream.Stream[responses.ResponseStreamEventUnion] {
ctx, span := i.tracer.Start(ctx, "Intercept.ProcessRequest.Upstream", trace.WithAttributes(tracing.InterceptionAttributesFromContext(ctx)...))
defer span.End()
// The body is overridden by option.WithRequestBody(reqPayload) in requestOptions
return srv.NewStreaming(ctx, responses.ResponseNewParams{}, opts...)
}