mirror of
https://github.com/coder/coder.git
synced 2026-10-31 19:36:41 +08:00
**TLDR:** When someone using free Coder taps a "Start trial for free" button, we now write down which page they tapped it on, and whether they went on to actually start the trial. That tells us which locked features make people want Premium. ## Brief summary - Records two things: the button being clicked, and a trial actually being started. - Each click gets a random ID that travels with the person to the trial form, so we can tell who finished from who walked away. - Records a short label for the page (like `appearance` or `audit_log`), never the web address, so no customer names are collected. #28226 added the trial form and has since merged, so this now targets `main`. ## Description Today the "Start trial for free" button just moves you to the Premium page and nothing is recorded, so there is no way to know which feature convinced someone. This adds two events: | Event | Happens when | |---|---| | `cta_click` | Someone clicks "Start trial for free" | | `trial_signup` | A trial licence is actually issued | The click generates a random ID. It rides along to the trial form and gets saved on the signup, so a click and a signup can be matched up later. Clicks with no matching signup are the people who gave up. Trials started without a paywall (for example straight from the sidebar) are labelled `direct`, so "no label" never gets confused with "broken". A few small choices worth knowing: - The ID is kept in browser session storage, not in the web address, so the URL stays clean. It expires after 30 minutes. - The trial signup event is recorded by the server, not the browser, so nobody can fake a signup. - The browser cannot say which kind of event it is sending. It can only report a click; the server labels it. - Only people allowed to start a trial are counted. The server rejects the rest, which matters because a few paywalls show their button to everyone. - Nothing is recorded at all when telemetry is turned off. There is deliberately no "paywall was shown" event. Every admin page visit would report one, which is a lot of noise for little insight. Every paywall in the [Premium Copy Updates](https://www.notion.so/coderhq/Premium-Copy-Updates-3c1d579be59280a59557cabd54fd8a1f) table has a label. The rows that do not are badges and alerts with no button to click. ## Proof Ran a local Coder with no licence and clicked the paywall button on the Appearance page. What the browser sent, and the reply: ```json POST /api/v2/deployment/premium-funnel-events -> 204 No Content {"id":"92d96afa-f975-4789-b8a7-b1fd19d4df85","source":"appearance","variant":"premium"} ``` What the browser saved for the trial form, same ID: ```json {"id":"92d96afa-f975-4789-b8a7-b1fd19d4df85","source":"appearance","createdAt":1787268520857} ``` The click then landed on the Premium page with the trial form. Screenshots of the network panel, the saved value, and the Premium page are attached below. The form itself was not submitted, since that would contact the real licence server. ## Testing - Backend tests: a click is recorded with the server's own label, an unknown page label is refused, and a normal member is refused. - Storybook tests: button clicked and ID saved on all three paywall styles, plus the case where the viewer only sees guidance text and has nothing to click. - Unit tests for the saved ID: expiry, bad data, unknown page label, and the `direct` fallback. - `make gen` is clean, and lint, types, and formatting pass. Two stories fail on `main` today and fail the same way here: `ExternalAuthSettingsPageView > Page` and `PremiumPageView > No License`. Neither file is touched by this branch; both were verified failing on `main` with this branch checked out elsewhere. ## Follow-up coder/coder-telemetry-server#45 saves these events for reporting. It merges after this one. <details> <summary>Plan and decisions</summary> **Goal:** find out which Premium paywall drives trial signups, and tell abandons apart from completions. **Options considered and dropped:** 1. Put `?from=appearance` in the URL. Rejected: messy for users. 2. Use router state. Rejected: lost if the page is refreshed. 3. Let the browser report the signup. Rejected: it could be faked or lost during the redirect. 4. Work out the page from the URL. Rejected: URLs contain organization and template names. 5. Report every paywall impression. Rejected: one event per admin page visit is noise, and the click is the signal. 6. Separate event types and tables. Rejected: makes the matching query harder for no gain. **Event shape:** ```go type PremiumFunnelEvent struct { ID uuid.UUID // event ID; for a click this is also the matching ID EventType string // cta_click | trial_signup, set by the server Source string // appearance, audit_log, ..., direct Variant string // which paywall design was shown AttributionID uuid.UUID // the click this signup came from UserID uuid.UUID CreatedAt time.Time } ``` **Where the code lives:** nothing under `components/` imports from `modules/`, so the paywall components stay presentational and only gain an `onCTAClick` prop. New wrappers in `modules/paywall/` own the reporting, one per paywall style, each taking a fixed `source`. **Self-review:** the `frontend-review` skill caught that reading permissions inside the wrapper forced an auth context into presentational page views, which broke their stories. Every call site already passes `canViewPremium={permissions.viewAllLicenses}` and the button only renders when that is true, so the wrapper no longer reads permissions and the server stays the gate. It also flagged one unattributed paywall on the Security page, now wired up as `browser_only`. </details> > Generated with [Coder Agents](https://coder.com/agents) on behalf of @david-fraley
176 lines
7.0 KiB
Go
176 lines
7.0 KiB
Go
package codersdk
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/google/uuid"
|
|
"golang.org/x/xerrors"
|
|
)
|
|
|
|
const (
|
|
LicenseExpiryClaim = "license_expires"
|
|
LicenseTelemetryRequiredErrorText = "License requires telemetry but telemetry is disabled"
|
|
LicenseManagedAgentLimitExceededWarningText = "You have built more workspaces with managed agents than your license allows."
|
|
LicenseAIGovernance90PercentWarningText = "You have used %d%% of your AI Governance add-on seats."
|
|
LicenseAIGovernanceOverLimitWarningText = "Your organization is using %d of %d AI Governance add-on seats (%d over the limit)."
|
|
// The dashboard's LicenseBanner matches this text's pre-placeholder
|
|
// prefix to render it muted and without a sales link, so the license
|
|
// warning texts must stay pairwise distinct before their first
|
|
// placeholder. See TestLicenseAgentRuntimeHoursWarningTexts.
|
|
LicenseAgentRuntimeHoursSoftLimitWarningText = "Your deployment is approaching its Coder Agent runtime hours allocation: %d of the %d hours included in the current license term are used, at or above the advisory soft limit of %d hours."
|
|
LicenseAgentRuntimeHoursAllocationReachedWarningText = "Your deployment has used %d of the %d Coder Agent runtime hours included in the current license term."
|
|
LicenseAgentRuntimeUsageUnavailableErrorText = "Unable to determine Coder Agent runtime usage. Reported runtime hours are unavailable until the next successful refresh; workspaces are unaffected. Check the coderd logs for details."
|
|
LicenseAgentRuntimeHoursClaimsIgnoredWarningText = "A license contains unusable Coder Agent runtime hour claims, which were ignored. The rest of that license is unaffected. Check the coderd logs for the affected license and claims, and contact support to have the license re-issued."
|
|
)
|
|
|
|
type AddLicenseRequest struct {
|
|
License string `json:"license" validate:"required"`
|
|
}
|
|
|
|
// Defines the input payload for requesting a trial license.
|
|
type CreateTrialLicenseRequest struct {
|
|
Email string `json:"email" validate:"required,email,max=254" example:"jane.doe@example.com" format:"email" maxLength:"254"`
|
|
FirstName string `json:"first_name" validate:"required,min=1,max=60" example:"Jane" minLength:"1" maxLength:"60"`
|
|
LastName string `json:"last_name" validate:"required,min=1,max=60" example:"Doe" minLength:"1" maxLength:"60"`
|
|
PhoneNumber string `json:"phone_number" validate:"required,min=7,max=20" example:"+14155552671" minLength:"7" maxLength:"20"`
|
|
JobTitle string `json:"job_title" validate:"required,min=2,max=100" example:"Engineering Manager" minLength:"2" maxLength:"100"`
|
|
CompanyName string `json:"company_name" validate:"required,min=2,max=100" example:"Acme Corp" minLength:"2" maxLength:"100"`
|
|
Country string `json:"country" validate:"required" example:"United States"`
|
|
Developers string `json:"developers" validate:"required"`
|
|
// Source is the premium paywall the request came from, for telemetry. It
|
|
// is not forwarded to the licensor. Omit it to report "direct".
|
|
Source PremiumFunnelSource `json:"source,omitempty"`
|
|
// AttributionID is the ID of the cta_click funnel event that led here, so
|
|
// that a signup can be joined back to the paywall that produced it.
|
|
AttributionID uuid.UUID `json:"attribution_id,omitempty" format:"uuid"`
|
|
}
|
|
|
|
type License struct {
|
|
ID int32 `json:"id"`
|
|
UUID uuid.UUID `json:"uuid" format:"uuid"`
|
|
UploadedAt time.Time `json:"uploaded_at" format:"date-time"`
|
|
// Claims are the JWT claims asserted by the license. Here we use
|
|
// a generic string map to ensure that all data from the server is
|
|
// parsed verbatim, not just the fields this version of Coder
|
|
// understands.
|
|
Claims map[string]interface{} `json:"claims" table:"claims"`
|
|
}
|
|
|
|
// ExpiresAt returns the expiration time of the license.
|
|
// If the claim is missing or has an unexpected type, an error is returned.
|
|
func (l *License) ExpiresAt() (time.Time, error) {
|
|
expClaim, ok := l.Claims[LicenseExpiryClaim]
|
|
if !ok {
|
|
return time.Time{}, xerrors.New("license_expires claim is missing")
|
|
}
|
|
|
|
// This claim should be a unix timestamp.
|
|
// Everything is already an interface{}, so we need to do some type
|
|
// assertions to figure out what we're dealing with.
|
|
if unix, ok := expClaim.(json.Number); ok {
|
|
i64, err := unix.Int64()
|
|
if err != nil {
|
|
return time.Time{}, xerrors.Errorf("license_expires claim is not a valid unix timestamp: %w", err)
|
|
}
|
|
return time.Unix(i64, 0), nil
|
|
}
|
|
|
|
return time.Time{}, xerrors.Errorf("license_expires claim has unexpected type %T", expClaim)
|
|
}
|
|
|
|
func (l *License) Trial() bool {
|
|
if trial, ok := l.Claims["trial"].(bool); ok {
|
|
return trial
|
|
}
|
|
return false
|
|
}
|
|
|
|
func (l *License) AllFeaturesClaim() bool {
|
|
if all, ok := l.Claims["all_features"].(bool); ok {
|
|
return all
|
|
}
|
|
return false
|
|
}
|
|
|
|
// FeaturesClaims provides the feature claims in license.
|
|
// This only returns the explicit claims. If checking for actual usage,
|
|
// also check `AllFeaturesClaim`.
|
|
func (l *License) FeaturesClaims() (map[FeatureName]int64, error) {
|
|
strMap, ok := l.Claims["features"].(map[string]interface{})
|
|
if !ok {
|
|
return nil, xerrors.New("features key is unexpected type")
|
|
}
|
|
fMap := make(map[FeatureName]int64)
|
|
for k, v := range strMap {
|
|
jn, ok := v.(json.Number)
|
|
if !ok {
|
|
return nil, xerrors.Errorf("feature %q has unexpected type", k)
|
|
}
|
|
|
|
n, err := jn.Int64()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
fMap[FeatureName(k)] = n
|
|
}
|
|
|
|
return fMap, nil
|
|
}
|
|
|
|
func (c *Client) AddLicense(ctx context.Context, r AddLicenseRequest) (License, error) {
|
|
res, err := c.Request(ctx, http.MethodPost, "/api/v2/licenses", r)
|
|
if err != nil {
|
|
return License{}, err
|
|
}
|
|
defer res.Body.Close()
|
|
if res.StatusCode != http.StatusCreated {
|
|
return License{}, ReadBodyAsError(res)
|
|
}
|
|
var l License
|
|
return l, ReadBodyAsJSONUseNumber(res, &l)
|
|
}
|
|
|
|
// CreateTrialLicense requests a trial license from the Coder licensor and install it.
|
|
func (c *Client) CreateTrialLicense(ctx context.Context, r CreateTrialLicenseRequest) (License, error) {
|
|
res, err := c.Request(ctx, http.MethodPost, "/api/v2/licenses/trial", r)
|
|
if err != nil {
|
|
return License{}, err
|
|
}
|
|
defer res.Body.Close()
|
|
if res.StatusCode != http.StatusCreated {
|
|
return License{}, ReadBodyAsError(res)
|
|
}
|
|
var l License
|
|
return l, ReadBodyAsJSONUseNumber(res, &l)
|
|
}
|
|
|
|
func (c *Client) Licenses(ctx context.Context) ([]License, error) {
|
|
res, err := c.Request(ctx, http.MethodGet, "/api/v2/licenses", nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer res.Body.Close()
|
|
if res.StatusCode != http.StatusOK {
|
|
return nil, ReadBodyAsError(res)
|
|
}
|
|
var licenses []License
|
|
return licenses, ReadBodyAsJSONUseNumber(res, &licenses)
|
|
}
|
|
|
|
func (c *Client) DeleteLicense(ctx context.Context, id int32) error {
|
|
res, err := c.Request(ctx, http.MethodDelete, fmt.Sprintf("/api/v2/licenses/%d", id), nil)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer res.Body.Close()
|
|
if res.StatusCode != http.StatusOK {
|
|
return ReadBodyAsError(res)
|
|
}
|
|
return nil
|
|
}
|